diff mbox

[dpdk-dev] net/bonding: fix check slaves link properties

Message ID 20171020154926.13452-1-tomaszx.kulasek@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tomasz Kulasek Oct. 20, 2017, 3:49 p.m. UTC 
  Result of slaves link properties validation is not used when new slave
is added.

This patch uses the value of link_properties_valid() to determinate if
slave can be used in the bonding. If function fails, error is returned
preventing to add slave with invalid link properties.

Coverity issue: 158661
Fixes: deba8a2f8b0b ("net/bonding: fix link properties management")
Cc: declan.doherty@intel.com

Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
 drivers/net/bonding/rte_eth_bond_api.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit Oct. 25, 2017, 10:01 p.m. UTC | #1 
On 10/20/2017 8:49 AM, Tomasz Kulasek wrote:
> Result of slaves link properties validation is not used when new slave
> is added.
> 
> This patch uses the value of link_properties_valid() to determinate if
> slave can be used in the bonding. If function fails, error is returned
> preventing to add slave with invalid link properties.
> 
> Coverity issue: 158661
> Fixes: deba8a2f8b0b ("net/bonding: fix link properties management")
Cc: stable@dpdk.org

> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit Oct. 25, 2017, 10:02 p.m. UTC | #2 
On 10/25/2017 3:01 PM, Ferruh Yigit wrote:
> On 10/20/2017 8:49 AM, Tomasz Kulasek wrote:
>> Result of slaves link properties validation is not used when new slave
>> is added.
>>
>> This patch uses the value of link_properties_valid() to determinate if
>> slave can be used in the bonding. If function fails, error is returned
>> preventing to add slave with invalid link properties.
>>
>> Coverity issue: 158661
>> Fixes: deba8a2f8b0b ("net/bonding: fix link properties management")
> Cc: stable@dpdk.org
> 
>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
index de1d9e0..ecda494 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -302,8 +302,13 @@ 
 		internals->tx_offload_capa &= dev_info.tx_offload_capa;
 		internals->flow_type_rss_offloads &= dev_info.flow_type_rss_offloads;
 
-		link_properties_valid(bonded_eth_dev,
-				&slave_eth_dev->data->dev_link);
+		if (link_properties_valid(bonded_eth_dev,
+				&slave_eth_dev->data->dev_link) != 0) {
+			RTE_BOND_LOG(ERR, "Invalid link properties for slave %d"
+					" in bonding mode %d", slave_port_id,
+					internals->mode);
+			return -1;
+		}
 
 		/* RETA size is GCD of all slaves RETA sizes, so, if all sizes will be
 		 * the power of 2, the lower one is GCD