[dpdk-dev] app/testpmd: remove useless funciton declarations
Checks
Commit Message
The four function declarations have no funciton implementation,
remove them.
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
app/test-pmd/testpmd.h | 4 ----
1 file changed, 4 deletions(-)
Comments
16/10/2017 04:30, Zhiyong Yang:
> The four function declarations have no funciton implementation,
> remove them.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Please add Fixes: line.
Hi thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, October 16, 2017 6:18 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [PATCH] app/testpmd: remove useless funciton declarations
>
> 16/10/2017 04:30, Zhiyong Yang:
> > The four function declarations have no funciton implementation, remove
> > them.
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> Please add Fixes: line.
Fixes: 0db70a803028 ("app/testpmd: add commands for filters")
Thanks
Zhiyong
On 10/15/2017 7:30 PM, Zhiyong Yang wrote:
> The four function declarations have no funciton implementation,
> remove them.
Fixes: 0db70a803028 ("app/testpmd: add commands for filters")
Cc: stable@dpdk.org
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -698,10 +698,6 @@ void port_rss_hash_conf_show(portid_t port_id, char rss_info[],
int show_rss_key);
void port_rss_hash_key_update(portid_t port_id, char rss_type[],
uint8_t *hash_key, uint hash_key_len);
-void get_syn_filter(portid_t port_id);
-void get_ethertype_filter(portid_t port_id, uint16_t index);
-void get_2tuple_filter(portid_t port_id, uint16_t index);
-void get_5tuple_filter(portid_t port_id, uint16_t index);
int rx_queue_id_is_invalid(queueid_t rxq_id);
int tx_queue_id_is_invalid(queueid_t txq_id);
void setup_gro(const char *onoff, portid_t port_id);