From patchwork Thu Oct 12 13:07:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alok.makhariya@nxp.com X-Patchwork-Id: 30288 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB84E1B2EC; Thu, 12 Oct 2017 15:10:34 +0200 (CEST) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0045.outbound.protection.outlook.com [104.47.42.45]) by dpdk.org (Postfix) with ESMTP id 26CA31B2DC; Thu, 12 Oct 2017 15:10:32 +0200 (CEST) Received: from MWHPR03CA0006.namprd03.prod.outlook.com (10.175.133.144) by CY1PR03MB2362.namprd03.prod.outlook.com (10.166.207.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 12 Oct 2017 13:10:31 +0000 Received: from BL2FFO11FD034.protection.gbl (2a01:111:f400:7c09::120) by MWHPR03CA0006.outlook.office365.com (2603:10b6:300:117::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Thu, 12 Oct 2017 13:10:31 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; NXP1.onmicrosoft.com; dkim=none (message not signed) header.d=none;NXP1.onmicrosoft.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD034.mail.protection.outlook.com (10.173.161.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 12 Oct 2017 13:10:30 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9CDAKSL008029; Thu, 12 Oct 2017 06:10:27 -0700 From: To: CC: , , , Alok Makhariya , Date: Thu, 12 Oct 2017 18:37:22 +0530 Message-ID: <20171012130726.4332-2-alok.makhariya@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171012130726.4332-1-alok.makhariya@nxp.com> References: <20171012130726.4332-1-alok.makhariya@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131522874311953424; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(376002)(39380400002)(39860400002)(346002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(2876002)(6916009)(305945005)(498600001)(4326008)(68736007)(86152003)(50466002)(69596002)(16586007)(48376002)(316002)(1076002)(97736004)(8936002)(356003)(85426001)(36756003)(2351001)(47776003)(50986999)(76176999)(81156014)(77096006)(189998001)(2950100002)(105606002)(2906002)(106466001)(8656003)(104016004)(5660300001)(54906003)(6666003)(5003940100001)(53936002)(50226002)(86362001)(8676002)(33646002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2362; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD034; 1:NDuzddIp1s65jQrj5k/12yBqWRO7fGOA+Ov4lVoWN22BAZgZE0cIvf9DX+nLxsDh18ceUFXcq5VPCVBNHALcl28n/xUs8Imd8tX0/VXui6kD9v0OvAezAyY8bB4G4ZXx MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8b1aeb2-76a1-4d14-6a89-08d511729da8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY1PR03MB2362; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 3:Ge7jNmC0EoOtPHtJucf6zSk3RUfhXcsX2vdDCVuVw1wumGArs4UIGpUekmD+l6T4e3TmSPrF8TySYkcKVOnz5dPz10vvY0IuFuWy5FQjBV/0fTQr/hkQLK7BvoAvwcuOKQoB0HMKLOxRJbBrvyOuCqh7uuTSl5OfE7uWZZ9IvZM0XHiJybPB44UGDyFGxzD208lzzU15zKUQfLGTHYXf5vm3wZQIMvlVkh5FFyjHKv8lg14yBot7U/FP/HPSuH8nssPmD0T2SYeGVy72AA/iPe7wLY0jlWr2JIzXEiBNBhDAerUlUAheZUkviv3RLxEdyoTbiW8R0s7De1Ky20fYvJPNk/41kvaWigqH9O1wA1o=; 25:HKQuIbAtpE37RtF838nLptcov3/KX071dQ2E/k7w5F1a/9xO2EpmtpOW7TZUTTcAzn64RAZR6OFje2AGD7/iCW4tgfNNLmAWA+FCoO+XhepD7wQA38oGsjKpzaPgi7Not7/c+wXqUbzNOqwpU+r4AD+QSd/6+Cgs5PAZYPg6Jsv2le4CkwtcinUZkfQLDZfKe2dltRsL7r8171SAj8j+/Hlm+0t17kiCPU3rW8XVNxQLoXGtT10C/+RrUBn1UNUQGjBUpLWMx6RDN/B9JsKJS/f9Wc6bGxulgoevtFZQ7tVuXT9XtZcK9QsgmDD4+JrHYs9SbEJoyNUlrYuMGrTlkQ== X-MS-TrafficTypeDiagnostic: CY1PR03MB2362: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 31:1zMrljY1hHD8Z80wqRw/tUTnDHxKLc2f0vYn3fJVAlPMHBc6+SSAx8e57dH8b8Ny5AG7/1qODpPs6tRD5ncmXgUoQbuGxSi36fpCI90JOrQwi58865+3iLB+hNQdRmvOuJZVP8eDlEUv3eYa1zwp8rThUYXoDbtY7LUibVGYIVpMG0ubESJ+V40Z3oeiGG1VTtpiHd5/P3Ha7N22+vNDKHCAeXFXGaZtgZE6buywiP8=; 4:AV2oX9aeHWrjV72KnV+5pMW6CusIhBumZsf/5YZZd8z3XbZahV0NfknkFv691s4JwgMPVKTn8kFlXvAvm7RTtKBL5BNGngHoiBzVuLXVvvVP5XVO12lM6I/Kdln/eJK7eqhcWr6oBctL1CtVNCHBN6S1ZwIvClNElUh07ELnUci1jg0mUffkopXjN+3p1L8XyqcUgrboOk8VTFTBvSkmxHTGSEosasZl9jB6n+Ipy/sMNQi57DFRJ15xNq1Xb0c/28ynG+tvaWh3MmLnaeZGKbnP1fAX+R9ytOPckvbBneo= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6096035)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123563025)(20161123556025)(20161123561025)(20161123565025)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2362; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2362; X-Forefront-PRVS: 04583CED1A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR03MB2362; 23:RjwLk4hbNGQDD+cPBBdBTLYEhK47QE2rQB4kxQ9Fo?= 0F/ouWjt0tzUktyAKFvZkRWCp0qfQG6KFtwobzOqfy8nL+BBNciT3x8fyqkJxuq9bc88en7qZqc0CYPDRUA6/pbSLp5Trler2LM65KOAi/MjbCMOFteuGriPBfWq+5puluYc9Bjh89QpkWuv8DP8UQX7uD9WMOlfANXBTi7dLYSyJdGLM6V6WUg+rDafW5g+1iTDnIql/2yaYeffZOjEHEKEdBJBpBOnHDWTB51y4VXPl2H9fpUxX3mXa1qNuTHOf7YjHue1FiqDCJop3LmdXWIYNOevVpIKoKcgHGKtbAPdEus563PAAtsV3iziWHKlsksW2wJy6gyomLEPB8FjYTGEO8TdB97foOc1TOAYdAWEdT2X7tcvPXN2yjsTHRD+CrmsF5jijB8j0UysXmgNrtkqa5ErFGqDQOghpLAPmM1pUSIyxN91qJqNkMupHNGiEz7ECcIcnxRXw/bPE5VwRGYtj8Ml4wn/wp4VNLoPpbpckEwVacaPkB2mc3dPgm+x5r4I+Q/SKhffA77GPC2ciAo12VkGI3TEzSC20J4hnwxJ+l0AMf2dtA10+QginUkOcM/ogcOQJ8xxhAtLwNEV8FUefxSzJvjfMUNkj8Y98icg0K7Fag/OBSToj6b2pP415JL2nmoYLu38wTtIhU6Bohj6D8btalkGllLZFTUHqvgQwh9Jki2ifY63nz1LMybwvLuNhMi1hnCgY2E1iYp6fJ+VyJ3UPJWXjJKRNqlxYzY/ER2aTo23cqzCfqWdDa06wc+Bmlco0FYmYSRTbEKenGETDSS8UHcZsZpVLNzMNlwQeBN2MniXZYfe+7cvlXdgg6tJUhYaxL8dcN1exHHPKmoAFlW56cWvoSNDDXQ28rRkwVJtqJ6hDjSw662QNO/5SzCYyvW8+mAjwXW7KjdFs9/V1FuMhO6o13KZmbxXkiwNjkVJ0yg/YEJrFSVCzyqWMQSJlGQmXfx/3jQ3ddqRmaxLBAKGnhuv2rqfXYmPzxe01RwB6f6FHfOUZ/I5La4QU9cknyJI1ztjqodeNdwr5zWNubCKanP3UDc+pFGaGJylonODE8SNzoGoSp6LqFxDnwH6CBgmlWFMBbrEhxvyeE7BQfb2hHmFYTGnDCEjwtEqa74QHhR3UbQWBeuMm2W4aS5OMqSYr1X3p3cOKAZRYyfyBa7NRuZanJtHfG/2ZWe/UcD3eDxR6kEIjv75DbXQf8Y9lHrauPtGyAQ6irgiVxp X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 6:TaP2ChJ1nU7WuPe+t29yhA+4lCSBAfBvtBMCR7XW0B2R33QZ5y3Uxg1V8M8ROSaUMbDFhjvPgjjqarlEMZuuYGeU2NMciPDZihfTr0/Pahdwl+tWWLAdxjaHLnqJQ6tdQy/eQNQH2MPrpFaRjKFkgJ4Jc8+sQ7hhPVH14qr5i5nNEDcJy6OeTP6OB1TfOdLiQ5XMmUGnQqT8x5+vSK+431+RuKmI9H9WhAzOhPCcpwia4V9YNwTmH/fMBx55gXBi+uYDMf3d9Vzn1B8PHJhArRUskrDvSSFEAGLEZu8jzx4Wqhwllisk7ZrY612O4a5/Vxik/JATcZAQa49ozfCzmg==; 5:hlPP4bVKbsfb6H5DJsQ39zuaz84Qv45rJOriEjRqgCtYvOHObM929Z++kRG/iZ2oVMMQLO9hC3wy88G78M6u+ucPYTwrrWDK+9kdVGYBqGMuLGf8+VpnetaRtaLW4Gww0NA8RZ36HpTKlRwEZFs2aw==; 24:EqDJIsk0hZf2BXRa7dSXB6mOeZM1j4P4vwgenv1WDeSfrRLOboB8JWE8GgsheEsRaBzmm3MWlCg7SIbMRE1r9RXOfXJFxy1ZcbzWAxM2VP8=; 7:ibohdzlPjEsAcaK4ZAgwaQbh7mG2JB45Wze6kNnQaG71wX1jq9LEv+35bOFQRf4YGK0e01hMW7oXSMTwSmfYXP9PDrrgodMYOnaHlEp4drVTqvyfjiGOqU4U1CkRPi2BA0plvTTwnYo5JphsFJgc4+8Gler3Yq6Sh8h7GhU2ntLPMJD03KuiImXp/W2xkPVyZqsFKJSEhJHWx0yL/p3AmfWW2qVgwvZB6q8Tw718e0M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 13:10:30.9456 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2362 Subject: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for segmented buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Alok Makhariya The code would crash for segmented buffer if no check. Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: stable@dpdk.org Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 672cacf..9895300 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -551,7 +551,13 @@ build_sec_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, int ret = -1; PMD_INIT_FUNC_TRACE(); - + /* + * Segmented buffer is not supported. + */ + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { + op->status = RTE_CRYPTO_OP_STATUS_ERROR; + return -ENOTSUP; + } switch (sess->ctxt_type) { case DPAA2_SEC_CIPHER: ret = build_cipher_fd(sess, op, fd, bpid);