From patchwork Mon Oct 9 02:43:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuanhan Liu X-Patchwork-Id: 29922 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B58C1AFE8; Mon, 9 Oct 2017 04:43:10 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id F40662A5E for ; Mon, 9 Oct 2017 04:43:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 89124F80; Sun, 8 Oct 2017 22:43:08 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 08 Oct 2017 22:43:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=s2mv9Xd1Lm9/ZzGwwK89CpLJn8G4CR2QThA+sU4QJ 0E=; b=m+EqeSl1VfC1j0eG3vbP0aP34aadNVvsYJZD7UXgPUqNxHkc2GCqUKrIh Xb4v2qapmqAsMyppZE+s0XIUDIrPJEgeLGX14fJVv/YdbI1O+FwdriD2miwbMu2s y5sY9b9scbbH0VDCotB3jmv2zzputLbR87429XujsMO1yL36oCHwCrD8ZQWyBg0z UjMiziFFV79VFdjxzqRUXt2q5xQOQInEjDSVUXqTRTybWMUxM5UfjR7tw7FheZeQ z2gghy1K1ZMqLkVQNZXPT2AP0Qkw56unfzK53fiwRQ2Yo5LxunS4OBULGi52ye3m tUmNS5vfHkusDvzQAEFCFGuxI/vxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=s2mv9Xd1Lm9/ZzGwwK 89CpLJn8G4CR2QThA+sU4QJ0E=; b=qj/1puAmrc79LxTpLl69ciqGP1DdWKVACn K/rVx/EWM3ZFx1EYL3RdpZCRxz53mYxJBW1UUUOiGJWpBFgX/6ku2pZlMDkIS+8G hMGhRNMU8GrILCUfxuSYo3Z1hVLPDcqnqG9n/CCgvlPZjzAjSE2gn4klL/19ITrQ 8rWJS7s2uPeEEQJo7Cuvmqsn8q2WyDAjtmEuci7ajXU4eqMSNWOhJF1MUJypF5Hi LtBGLO96ZqdymfhammYBit+gMMxZ8DcjI6kZqGqA1lq8/g0KJY8BilwDCeg1/7Gj 0lomguXmjlRmoj4pDftbVq7anWLXZc7PeI/4HEWrxavAuVtPpA5A== X-ME-Sender: X-Sasl-enc: iMxlmhAqb7mTWZWJGjWMVMfVpJz5a4iW/FZOsLq2Ee6d 1507516987 Received: from yliu-home (unknown [222.64.136.243]) by mail.messagingengine.com (Postfix) with ESMTPA id A455924586; Sun, 8 Oct 2017 22:43:06 -0400 (EDT) Date: Mon, 9 Oct 2017 10:43:02 +0800 From: Yuanhan Liu To: Thomas Monjalon Cc: Olivier MATZ , maxime.coquelin@redhat.com, dev@dpdk.org Message-ID: <20171009024302.GH1545@yliu-home> References: <20171006064558.GE1545@yliu-home> <1963011.gX7c8kfyiN@xps> <20171008201006.7gqmyeofcw3m4ech@neon> <2218306.fYRWOIo4Bx@xps> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2218306.fYRWOIo4Bx@xps> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [git pull] virtio changes for 17.11-rc1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Oct 08, 2017 at 10:16:29PM +0200, Thomas Monjalon wrote: > 08/10/2017 22:10, Olivier MATZ: > > Hi Thomas, > > > > On Sat, Oct 07, 2017 at 04:37:53PM +0200, Thomas Monjalon wrote: > > > 06/10/2017 08:45, Yuanhan Liu: > > > > Hi Thomas, > > > > > > > > Please consider pulling following virtio changes for 17.11-rc1 at > > > > git://dpdk.org/next/dpdk-next-virtio master > > > > > > There is a compilation error on ARM with > > > "net/virtio: rationalize setting of Rx/Tx handlers" > > > An include of rte_cpuflags.h is missing. > > > > I confirm that this include is missing in virtio_ethdev.c, breaking > > compilation on arm (thanks for spotting it): > > > > virtio_ethdev.c: In function 'virtio_dev_configure': > > virtio_ethdev.c:1748:7: error: implicit declaration of function > > 'rte_cpu_get_flag_enabled' [-Werror=implicit-function-declaration] > > if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON)) { > > ^ > > > > Thomas, about this issue, what do you expect? I can send another patch > > if required. > > It can be fixed by Yuanhan in next-virtio tree. Yes, I will fix them and then send another pull request. Olivier and Maxime, please confirm the following fixes. Thanks. --yliu Acked-by: Maxime Coquelin diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 9fb71e6..42c2836 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -49,6 +49,7 @@ #include #include #include +#include #include #include diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 45a9c91..609b413 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -50,7 +50,6 @@ #include #include #include -#include #include #include #include diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index f891f57..207fda5 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -1352,7 +1352,7 @@ int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm) { int ret; struct VhostUserMsg msg = { - .request = VHOST_USER_SLAVE_IOTLB_MSG, + .request = (enum VhostUserRequest)VHOST_USER_SLAVE_IOTLB_MSG, .flags = VHOST_USER_VERSION, .size = sizeof(msg.payload.iotlb), .payload.iotlb = {