From patchwork Sun Oct 8 13:53:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 29920 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C82137CE1; Sun, 8 Oct 2017 15:53:28 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0040.outbound.protection.outlook.com [104.47.34.40]) by dpdk.org (Postfix) with ESMTP id 66B72374C for ; Sun, 8 Oct 2017 15:53:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ESdQxkZbPxs61cgwwbCmEkUQHQodfPHIJ8e8ZirEXvk=; b=BHHZpm3M/AuyumRLNhL2Pg7SLRW2EK+EfMWZB75Fd76yoNklKgRVWXYs1ITNlpim6hgDiweKIEhDjbZxh6z+jOOFvuDW5HGtTo7JsUulHhHD7QuMGI1YZUOA8uKdwd1lPXLyGbVc7rtrbEjE2Cw6ipWGWiRmzbyYhCTdoUxa6pQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.61.81.39) by BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sun, 8 Oct 2017 13:53:23 +0000 Date: Sun, 8 Oct 2017 19:23:05 +0530 From: Jerin Jacob To: "Van Haaren, Harry" Cc: "Eads, Gage" , "dev@dpdk.org" Message-ID: <20171008135304.GA28566@jerin> References: <1505920863-14826-1-git-send-email-gage.eads@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [171.61.81.39] X-ClientProxiedBy: MA1PR01CA0116.INDPRD01.PROD.OUTLOOK.COM (10.174.56.160) To BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30b5bc0c-e4ea-4968-08e8-08d50e53f1f2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:zGPflN9Ha0koy2z/4malVV9tWmECXw6tchbjvM2eSs0Ure3QajfYkKRVwfeLhByLve8eTpVeVdQN6J0AUQ76qzu4/QIUI8V9yC1yngmKOFruO+r/x8iqpshErbS+mrVfrTpnKVapXA3lmtGyuIl82MrbtrdF6Zuuj4lin9m1zxfU+zhFtom3mb7ry2vpmUFe+HFRcFOAK/U2T1QntQjrXwBEW9d5yf+Ajv0w6XTsOTZProqnb265eIb/9BqaLqes; 25:B1gVY2SCdcbW2vHCGsT4uFI+pBcWsQBcs+0mktKHuzwiWm/IE9+za/ls8G/nNkpQkWF9j1Wz9y4RX9U/584OHs9bEBgWM1hccnAAGerge7sCIRC7ph0AQf0RCnJ6rf/jKTmzclgXNXkbVQiiMiP+RP/ksuiV1DAn/J5axf2bVqQIKkv+A0OY5kxRWj5PaqPMbNos2NkeBP3p+OIcUigGz9P3nUU0lxCk/ps2bqfhsOEBtNUSPEPl1Wrk7hNYUYZzczbQ1ppujPktL5HnauQp/SS+q8MxHAuD8C7mpYTtgOhJMI2pkTZ2I59af2F3McHXI+Wp6u5G6efcMJxGXcbRQA==; 31:9weCCzVFl7rdicE2ikbDiCdGVnnd2WeJbH4sRuT5KRxZCHPG/YSjL4fl1c43zGxoFgsaNkgzyJlNactMKeYA9+fPgVjyApXM5/lkrAUqxJFlRq8U475JIvOZlVVfjU0ieGw+FR8LCTcU2Al8Aq9af9WdVP5odAiSfYHuhh3luT7znpywOYcUa3MIhoxj/J3wJoQMTcOior5ZpH3foXQhkfgYnYCSizQxwG6X3VxblpY= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:Sy0DqZJICTvwCW4r7CXXpmlpEoB7pCz/oK0jgeUq1w+EyaMJJYqISsuxC6fh21abtsUUaR8/lCnTWnNJkB7DS1dj7U27juDAq5D7H9xJdd+6f5ShtCbwZ2sfSXrLf5Ouy5XsjcElNNU96ZUy5Jt8jzGb64PUdCxfdVIxvEzUQ6RcwnwQaqRVKQJnxDElTRgX8Kr58Uaev+TTTTeZUUBMuRU2MpGeBzRI6iSqH41eCMijkBzHguhEl28ic5oKOKV7jyfs7VMKmV5fjadqJxnr6t92gNSouWGywMJkaXdu+SgHwI0C4dMq9dr84Sb192rB24HgYOP8xARxV67HuZ9eJpe02HmPyIAZh0VEPtpeVpoHciJceiJelYMr+Tm2QeMBvOayyvGKkf6zE7l5hNqY8uUKFaPQTgbf+MSkqT6Jaly2SgnfiC3AzAUuHNVY3DXp9A0f48yxz6l5sPbE2aaD+wK6p+3ivi6+o9NbiotQHN9wrD7FjUmj6q1d1bJtDqU2yZhECv4vVf7qNgTM/hMx8qUbGJgP7qfsbSe00OzHn9Y0xu5Zc/UW+ACfcDFFRlaPsmLoPQeqTRoZnM+MNdpNbQbQJ98ajN6N8IQrKbHfQPk=; 4:s1+eRjk6kx2eW1AWc8NICvemwo3PyK0GCufQp5hYIPLFuYzhx31az+ceyGkUZAFn3XXPFIKYxtrNe6IhVcJTXI3/N9KNU5D6px20oJlFnctWM7ETcQmdbsVJ+2jFGYXwcIkw9qe+PIiU1Y50EM7Ndm3WAnoioo/JbjIOtRyMwxgl5yhJOPVm/xCytyFnEZfdJnPK41IwmRtp4X2FSSVSVirCutXuBeq+A2YtoXfBG0D6TgrU00FRjRXzGmEUAjPi7fj6ya4Ctfu5yT8Dy7QLQTdoa3OxFJwC9wVTYuPt6tA= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR07MB2513; X-Forefront-PRVS: 0454444834 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(199003)(13464003)(189002)(377454003)(5660300001)(16526018)(50466002)(1076002)(47776003)(58126008)(6116002)(3846002)(2906002)(33656002)(6666003)(316002)(54906003)(229853002)(25786009)(97736004)(478600001)(72206003)(4326008)(68736007)(54356999)(6916009)(42882006)(6246003)(2950100002)(105586002)(8936002)(53936002)(50986999)(81166006)(33716001)(6496005)(9686003)(101416001)(76176999)(7736002)(81156014)(23676002)(189998001)(66066001)(106356001)(55016002)(53546010)(8676002)(83506001)(2870700001)(305945005)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BBN3PR07MB2513=3B23=3AWuyg?= =?utf-8?q?as1dDEQMDb8hPt69awbjIvPx/Ds+WKXJeabcjz9YGu35LXD9rv7RV91N?= =?utf-8?q?zs7lSxZrnMHSFx1tMPjah+42EvZlh1ia/3c7LdSakoxgu+VZfT4iYe4Q?= =?utf-8?q?k/bsG4EZIZq30vkVe016FmNDw93xCxze9SynTZkZnX+GURFDNbF2liIb?= =?utf-8?q?FmEw5PUw/BxdV+i9a9jOIrGnGpL6LntUPJA7TnHRyeAxJsg2UWLAZNru?= =?utf-8?q?O+zTyupByN6ArWfplbjEODLKgaHdfxYFb0MT38n45Y1NHe1iDyRZxwft?= =?utf-8?q?DBwF8ZIfpZvZ6z2obrYZ4JBJvVBnYNkELHZvvj6cQLYKR6kA4u+GhEau?= =?utf-8?q?3De9v63SYTlHNsT73TXTc/OcjtwtynyUI7X9phJyIV5ITxezs9yHl0dw?= =?utf-8?q?eZuNFp+L9NMhr3Y06bqhqbmZu8eh3o2c1I/IkVgPmabmEn/KY08A2+C1?= =?utf-8?q?RTTZk1e2veULriM7Vrv13plUfzgLZqySRouAvbkll7FL73qG1zYIrp0H?= =?utf-8?q?p1b1CrpGDs9/5TjQZBe7X0Mry4DJMnnUT0+KjRna6piekOUtO6hvPit3?= =?utf-8?q?JjxBctRu8wCISaC2vQHDtqdfc4imtA8SUFkadHDGebTN5zXAsPzXF1Vq?= =?utf-8?q?cbQ7GLovmrNif0sLZ7ppZXi9KKNpgrAdM+sk3GNxOD9TMav6a0IdfLdc?= =?utf-8?q?gh+Df7YVjbx89DXJDpy4Z1Q1KjeRvB9Hj5q8SC2XIQ9BZ7UWOS1rIKiD?= =?utf-8?q?Ez42ennrcymkN08uF/GouVcM+mzZDwPPQXASnp0CaYfSIpUXfLFh+QeJ?= =?utf-8?q?QxtQWW8TBlGcBHMxpA7yZV0BUKQB+IhBWih9SBoZhSaKRHDcUuu917+5?= =?utf-8?q?twvwYuqZtXhNy1ynME26BxgUMtkS2Vrb20Edb4TdrVUVsfjHrFUNVXur?= =?utf-8?q?T07BsOLWVtYaZNC805e4Lhg48Hr3hQgZVHipZ4DLt4WLXs7pZcRBO97v?= =?utf-8?q?RejrayzqTCdLuph1bPHEHF9ovSl+5Whzq+JMf/E4ddThODjp5LZjsbQW?= =?utf-8?q?MFTzgVbnLKZ28X9VEirAL0uJOZX/SsSCVHDlME5n5gVj+SybGbgKUVn4?= =?utf-8?q?TxskvsemtwGENgvKA/P1T4oPcF6SvpEgV07LulwH8YvwczZFYvqZAWCf?= =?utf-8?q?/3jB4EwKPFisQvU6vewKvHwmdEi5rS7vLxDtdS4H8UsgbtGKZAcHsNiW?= =?utf-8?q?c0YZaQvrwqvoQsbjDHwgaI+69nw5olxGN/kxfmrzErZhu2r8Nl8Bb1ye?= =?utf-8?q?HN+fdIEZKdiF45OeMlMDPtJl9JCcojJPF1ZQU70PCShQ?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:B0gXPUB9444Oz1L1gFvJhEV9YxSDx67OeXIsIbxKX1Ce0qx09quHrbCdik/mFpJOY3XedcLEBZ2cVS4+cSuhMIBP0cOVeQN9ca1z2D9uM1HgMRYe8jnqx2/skHVcDJZdg6FG3vePc2Vv+uv7z1hFjydtflvkvrqI8gInCtkTB51Jqyb0WAgEBU+DU2Pibq68hQgoTMeeNLelddEUH2JLtZkMP4Epgov7b/+CkBGgIkWtBvC0wWSg+TQjhUh2IyvmjXeGn55X4JooGu82ARbjup5bzwuGFjDiviODae29e25wI9eYAn6tEw6hpQV8NmNn5jmKvBzc48dJmUYhmWMMIA==; 5:fMaXSvTp3bBWXHXXHWCzoUfrPvQJZjcoBb8ivFIiZ2CzEpkeNfNfiO2TKcnQZ0sVnaCpgnuYGLYbPFf07dg/fd0a3qNj512deKUOb3jQJBJkhG2+xdqjc+vKlHgcm+F0RDVM/VHW2CPsTLNNctyedwS8DEGbkpJB1sXKHz7yBhw=; 24:3iik3ePhN7r+mYahskkOIU0LenoJkJX8RNvtFIDBYmWBPTVYRSAeHYZKM8X9mQwdHofDZxHUKFgsrR/ls1iTKuw5+N3xwQCkItapciTFfGQ=; 7:ZZwa8xE1PEw5Z/J9NxtgR45fKljglquskm96DL63D+tReaYMkSuzA/Ej81fWQSFTNGSF/81IEJzAjDQIYtPC16Th/cz7QcpPVlbc1wbBnnMyPaNn5NOVJp6nDmXHIDoJPLJwWASopvo2VGzJYA6ejH1HEXDElA6lMe93yuOora4vI/nQJw3YU3+gfLVXgZ3VYtSYdZUQML4KmOXmRYjcRR0XkujW7mKM7fgW4LEALKA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2017 13:53:23.0944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH 0/3] Extend port and queue attribute get functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Wed, 4 Oct 2017 14:12:50 +0000 > From: "Van Haaren, Harry" > To: "Eads, Gage" , "dev@dpdk.org" > CC: "jerin.jacob@caviumnetworks.com" > Subject: RE: [PATCH 0/3] Extend port and queue attribute get functions > > > From: Eads, Gage > > Sent: Wednesday, September 20, 2017 4:21 PM > > To: dev@dpdk.org > > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > > > > Subject: [PATCH 0/3] Extend port and queue attribute get functions > > > > This patchset makes the full queue and port configuration structures > > accessible > > through the attribute get functions, adds tests for the new attributes, and > > fixes one bug in a port attribute get test. > > > > This patchset is based on patches 29019 through 29023. > > > > Gage Eads (3): > > eventdev: extend queue attribute get function > > eventdev: extend port attribute get function > > test/eventdev: fix bug in port enqueue depth test > > > > lib/librte_eventdev/rte_eventdev.c | 125 ++++++++++++-------------- > > lib/librte_eventdev/rte_eventdev.h | 26 ++++-- > > test/test/test_eventdev.c | 179 > > +++++++++++++++++++++++++++++++++++-- > > 3 files changed, 245 insertions(+), 85 deletions(-) > > Thanks - good to see the attrs API get more value! > > Series-Reviewed-by: Harry van Haaren Applied after fixing the build issue found in my system(gcc 7.2.0) to dpdk-next-eventdev/master. Thanks. == Build test/cmdline_test CC test_eventdev.o In file included from /export/dpdk-next-eventdev/test/test/test_eventdev.c:41:0: /export/dpdk-next-eventdev/test/test/test_eventdev.c: In function ‘test_eventdev_queue_attr_event_queue_cfg’: /export/dpdk-next-eventdev/test/test/test.h:149:4: error: ‘i’ may be used uninitialized in this function [-Werror=maybe-uninitialized] printf("TestCase %s() line %d failed (err %d): " \ ^~~~~~ /export/dpdk-next-eventdev/test/test/test_eventdev.c:494:6: note: ‘i’ was declared here int i, ret; ^ ➜ [master][dpdk-next-eventdev] $ git diff diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c index 1d9e9fe4c..de3a964c2 100644 --- a/test/test/test_eventdev.c +++ b/test/test/test_eventdev.c @@ -505,7 +505,7 @@ test_eventdev_queue_attr_event_queue_cfg(void) "Queue count get failed"); ret = rte_event_queue_default_conf_get(TEST_DEV_ID, 0, &qconf); - TEST_ASSERT_SUCCESS(ret, "Failed to get queue%d def conf", i); + TEST_ASSERT_SUCCESS(ret, "Failed to get queue0 def conf"); qconf.event_queue_cfg = RTE_EVENT_QUEUE_CFG_PARALLEL_ONLY;