From patchwork Fri Sep 22 15:21:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Mrzyglod X-Patchwork-Id: 29115 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A001199A9; Fri, 22 Sep 2017 17:22:06 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0A3F36D45; Fri, 22 Sep 2017 17:22:03 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP; 22 Sep 2017 08:22:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.42,427,1500966000"; d="scan'208"; a="1198002769" Received: from unknown (HELO Sent) ([10.103.102.81]) by fmsmga001.fm.intel.com with SMTP; 22 Sep 2017 08:22:00 -0700 Received: by Sent (sSMTP sendmail emulation); Fri, 22 Sep 2017 17:21:52 +0200 From: Daniel Mrzyglod To: yliu@fridaylinux.org Cc: dev@dpdk.org, Daniel Mrzyglod , jianfeng.tan@intel.com, stable@dpdk.org Date: Fri, 22 Sep 2017 17:21:49 +0200 Message-Id: <20170922152149.16876-1-danielx.t.mrzyglod@intel.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170920132556.5310-1-danielx.t.mrzyglod@intel.com> References: <20170920132556.5310-1-danielx.t.mrzyglod@intel.com> Subject: [dpdk-dev] [PATCH v3] net/virtio: fix of untrusted scalar value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The unscrutinized value may be incorrectly assumed to be within a certain range by later operations. In vhost_user_read: An unscrutinized value from an untrusted source used in a trusted context - the value of sz_payload may be harmfull and we need limit them to the max value of payload. Coverity issue: 139601 Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer") Cc: jianfeng.tan@intel.com Cc: stable@dpdk.org Signed-off-by: Daniel Mrzyglod --- v3: * there were wrong v2 email adress for stable dpdk mailinglist * fix compilation errors v2: * Add Cc for stable in gitlog massage * Add Coverity line * v1 was acked by Acked-by: Jianfeng Tan drivers/net/virtio/virtio_user/vhost_user.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c index 4ad7b21..97bd832 100644 --- a/drivers/net/virtio/virtio_user/vhost_user.c +++ b/drivers/net/virtio/virtio_user/vhost_user.c @@ -130,6 +130,10 @@ vhost_user_read(int fd, struct vhost_user_msg *msg) } sz_payload = msg->size; + + if ((size_t)sz_payload > sizeof(msg->payload)) + goto fail; + if (sz_payload) { ret = recv(fd, (void *)((char *)msg + sz_hdr), sz_payload, 0); if (ret < sz_payload) {