From patchwork Wed Aug 23 14:12:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 27809 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 8A81B9A14; Wed, 23 Aug 2017 16:03:43 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0057.outbound.protection.outlook.com [104.47.36.57]) by dpdk.org (Postfix) with ESMTP id 391309A02 for ; Wed, 23 Aug 2017 16:03:41 +0200 (CEST) Received: from BN6PR03CA0066.namprd03.prod.outlook.com (10.173.137.28) by CY4PR03MB3318.namprd03.prod.outlook.com (10.171.246.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Wed, 23 Aug 2017 14:03:39 +0000 Received: from BY2FFO11OLC004.protection.gbl (2a01:111:f400:7c0c::181) by BN6PR03CA0066.outlook.office365.com (2603:10b6:404:4c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18 via Frontend Transport; Wed, 23 Aug 2017 14:03:39 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11OLC004.mail.protection.outlook.com (10.1.15.184) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1341.15 via Frontend Transport; Wed, 23 Aug 2017 14:03:38 +0000 Received: from Tophie.ap.freescale.net ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7NE2Q3N004389; Wed, 23 Aug 2017 07:03:36 -0700 From: Shreyansh Jain To: CC: , Date: Wed, 23 Aug 2017 19:42:10 +0530 Message-ID: <20170823141213.25476-38-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170823141213.25476-1-shreyansh.jain@nxp.com> References: <1499179471-19145-1-git-send-email-shreyansh.jain@nxp.com> <20170823141213.25476-1-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131479706190503819; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(626005)(356003)(33646002)(4326008)(8676002)(81166006)(105606002)(76176999)(36756003)(106466001)(305945005)(68736007)(2351001)(50226002)(5003940100001)(81156014)(8936002)(8656003)(2950100002)(77096006)(6916009)(47776003)(50986999)(6666003)(85426001)(189998001)(5660300001)(498600001)(110136004)(97736004)(104016004)(54906002)(86362001)(50466002)(2906002)(48376002)(1076002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB3318; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC004; 1:woANoSbZ/LX2wgJWOinu51Wz56+pCLsf+DH9gvAGp9ArlI527kp5HaO6YN9JTBearTOxIZuTHZgqPachbPB84Sliv/V2oaWtam5I6j4ZGB4aUfCcfnU3QjsCmMsyS6bQ MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c989eea7-9c5e-4cf1-54fb-08d4ea2fc10c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR03MB3318; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3318; 3:+cm/PZslN5b9uwUeOu/gsBSIY/C+JZ6sTYwwoMu7tpP7T2/LqiYDCAtSaldHsjdfPPhz6G3HlHZupO0XoenKmusxGk4nmRJXgJa83xRSN3d3A/MmolTi4n0IdDviZ80lqFntQ+oGY9apo9aaTzS3OhmXEMmFYVAsjBXiEk2w8NwQfGl5Spw9zA+pUjLyEapTmNoziaqeKpf2k5o8JsH+JE32AmZlzb9uzUdj2cu2/FDT1eC+IHHLRS6K7hcMJ9DLscYYCs6q29eZ8SJAQrc53C3elBi8fWFffUxl3ha5sBeWzfvQ+aSzNm3GY+B60r/jxMgKM4O3xyoQt8e3KiDrIqlg6R/JI5uepemZW1WHZBw=; 25:Qbue7EDRqjiqG3B321EPW8a9VnGYrLaMopqgKQvNvmWo0i8y7t0h9toSavrsEIPRNy65AKJ3hyHoa/XOMWwZwk2ePhfIvsZhLl35eh4uw4SgyxcK/mzO+IipwvE7s9txhpw5Ct+3zQ+od3rEmNGnUYJh/IG0M1NELfgoddRpDmg0/9Dkyr75z8qadRpJ290HAwl3ChniobkDGJ0KNKEYt43rvJpLvx2gPpqwiIARMOqAcXiG30KjSoIcdrzoaNKaShWEGandLDBCDS9LObRw3o9bu62I2NZCrn7Ow0sHGSZr7L5sISSuhXSPUfG0R6bnXGI+oIGyc0lK37lLfL9fkg== X-MS-TrafficTypeDiagnostic: CY4PR03MB3318: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3318; 31:38cL+TAfq0pohd5VGCehG+pt9fMuXxr0ysYA5yQLz3sfkLMzyh67lDebh91BFveqwcNMzCsntIBTIwfPWlq1PTC8Zwzq7GoO5tdCkJgusSGfup+vGqJDhyhiEcqGJ9X3ogv6jAvU2Dxi6qA/mGlgUE02zUrJCbTYw1yDMA7Cy3fHjcoxn8xt+tn01s80c/MB+/O5t2fa0PNz4o37hQAfElWrF4kDgCE/7jTl0TAC8YY=; 4:QqZEK1UAc38TUaj8we0tB61vy4ZjpIMuqIYMx6wklUCZpWticxngAHUkBzR2EBcNzm+GRGjO+REs1EucLcox+JGhFIT1l8dnEPhSfNAa9HPAjI3/Z8UL1vRQmbsmTzwKHQv+PsS3nTuXB66CoEXC1L9IH3wILA3ZWyESUcxkXGZE47rKrYrecGb1pDVmGryvmTIXdX3AlLfkYfzXZWenx0h1AcQd5BWXD1dxK5VeOWsUKf3toVmiPKaM8B8PZULhmFVV3mpPvRcsSUKF6WWABIwyHG+od/9dEp6pwre0mF0= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13018025)(13016025)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6096035)(20161123561025)(20161123559100)(20161123563025)(20161123556025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR03MB3318; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR03MB3318; X-Forefront-PRVS: 040866B734 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR03MB3318; 23:B7ttJsdu5O1MaF9klk51NBnc4jHpjCt/In3BCi+l7?= LJLplLLlUa4JefI3cFfIFzg71jC/bwmBBCmlhOJQWgjr+cOpX/HoSEe0HUq1H9qcm88MrGurntzJmNtpGeFSq9/UVmZe0gQmHOziATW0oTZ5omoZ2xIeYxPZEXQU3KBvXEV2AqXxueS+N3RNc1P52vlI5MNGd+oEkm/qgGcxXQr+6l2O+4HfhsYFl8Giaa1BUFKYLkiqFDczxjnb3GsYF9fjkK3dcXCoHpOQGkD9MxWje+ckD+4RXOri9WyZCo4KyEMpqIUX1wi4IUYJl1vLzuuSvX4GdAF3lE2YeG6hHfT9p7/pT0q1CAj2pJpW0uCHzDEZ7tq8ccIy0Rxz2YQXmhNwSw/gs4ztKWimreRf9eM4/OP1gN1tvhThJgL6LWF5rzBTbD8UcXPOHFgMV3pG/syhPUAGpJetD4ALRywdGAWxhxZlgNFH+zLZ2pD+l51LL+DBywbvYBUQWPBG0RIuuLovv6V6YuXVNnIWrGFPgnSxbJ/jHwMnqHKLuRHNh0OgoaHw5WHW7RknpZuANWL4TYdBOGARqlBfUrS4Fvkg5u+eGQzKInaNFwao9udK/Og4cHm5/MxqAolHGV8yaZOI4XH6mNywQnDjWC3Ky1Ej8MyOxaTfT1Jpl63W9gCK0u+lBvSunet/H0Qopim+xLWILjcBAl5m9DNgJmP2VJE55mvj2hiqwv7MBEKLA74FurAZwLmmVLfyPw7bVZqlFD0Idrn+/N2u27jlUzuTfr+6ijjmgnTmyrnLFCinOLitzsP8t8kXsGCBx08NoPsZbHINr/ZYgK9oXIbU5bD4vNpOo4kYXxcbb/Q7yPameXquakEt6GP30xROlKKagmlvS/QQuaI3QD8nTp4+DSJk3YIDozBeEW+p0ODonRsl4z2AcTe6aNHTkOGchBnBbqOQNvxaIj1hETiJjBLYt0oYRcZW121nLOprM3hss7MjuE/sdWcSq7xBJFTWk0GBunp/7yOWk/IRAHVIllEhWV7kH2Dk13utwp9fn1jbjyDkS6KaurNvVVmuXQOHomuJAZsglgSY6vG4moBo1/tx1Zl+kmFoWlUFNKeFYohPnsji/n26rkYiQzOAIDcMjSLqvRc5pnxjcTh X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3318; 6:lma4F5qWrA/Pbh0gQYj+vdyArFfLrAMh6Ey53+B3kPIpTYMnw/U89DOq3BC9mPTz+Xq82BTikfay0cw9tqQ4h9E7bVL5zMBFvzTWHY2ZgJKDSLtO/LDHPUoeY/d7azDnUIMsJAo3bKiyiAkDHzrgBgT0ad02rUJOwdyexj7B1D/byFMKiB0gM6KUD9gWrfDiLylmyIuPVUf4In9C4F/zHrffxSYzZ/M8UGLlxFfCm3rlis3zpaIELIKgGsR86WFzMufMeYTWNs+3LNhZGtgIAomooRSdgCTAP5ZQrGYOjxyhDQ2Rr+uUAwvsGwoWBKYnrJLqmhQNeZsUKhYALfqqxw==; 5:Ljhx0Iuen0aLwyg1/Nl4JEq1eDdjS+eHRRftBMsGvCM3tZ7cdM1hwgxeIrFvd1SVydK7/eWDDEKXb8EW6eXVhbAA6SOc7WJ5L7h/1THEi9AFXntaYRNf42+3bTE8GuIxn3GCyqk60sqfaMfA0Bs41Q==; 24:fEq9gi0LBKUf010K+6Dr42TV07xXqsN6y1BjRKh/kXyyaFRLAu47RQcD91BdG3c/aeRDbinT+/82ptdPEdcM2U4VVEK/SlYzB9/76KHqUNk=; 7:a3iJWCbp3Wz/gKk6rvkaUpzkDBcE+kpLcZMebe5WC8GVp9Jj0DdnpnZBF3vKCWaxKq9sj86cDGyd/oW3nrMmOz5R3s6VIaTGyGGbQst9tIhDVauAMOyz/QopgG6a+gPhVHHw0g/Zm0u/3x/8hYu8kvxfAxnQnk7wrqrzeUi5gxoTCrHYAv3EtEWjtl+rojXAkTXI7T5+cTyheu2DBXUp1Xp+i92asaTomr8Xlw75xII= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 14:03:38.7228 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3318 Subject: [dpdk-dev] [PATCH v3 37/40] net/dpaa: add support for checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 2 + drivers/net/dpaa/dpaa_ethdev.c | 4 ++ drivers/net/dpaa/dpaa_rxtx.c | 89 +++++++++++++++++++++++++++++++++++++++ drivers/net/dpaa/dpaa_rxtx.h | 19 +++++++++ 4 files changed, 114 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index 2ef1b56..23626c0 100644 --- a/doc/guides/nics/features/dpaa.ini +++ b/doc/guides/nics/features/dpaa.ini @@ -13,6 +13,8 @@ Allmulticast mode = Y Unicast MAC filter = Y RSS hash = Y Flow control = Y +L3 checksum offload = Y +L4 checksum offload = Y Packet type parsing = Y Basic stats = Y ARMv8 = Y diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index bcb69ad..96924b6 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -186,6 +186,10 @@ static void dpaa_eth_dev_info(struct rte_eth_dev *dev, (DEV_RX_OFFLOAD_IPV4_CKSUM | DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM); + dev_info->tx_offload_capa = + (DEV_TX_OFFLOAD_IPV4_CKSUM | + DEV_TX_OFFLOAD_UDP_CKSUM | + DEV_TX_OFFLOAD_TCP_CKSUM); } static int dpaa_eth_link_update(struct rte_eth_dev *dev, diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 90be40d..0f43bb4 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@ -200,6 +200,82 @@ static inline void dpaa_eth_packet_info(struct rte_mbuf *m, /* Packet received without stripping the vlan */ } +static inline void dpaa_checksum(struct rte_mbuf *mbuf) +{ + struct ether_hdr *eth_hdr = rte_pktmbuf_mtod(mbuf, struct ether_hdr *); + char *l3_hdr = (char *)eth_hdr + mbuf->l2_len; + struct ipv4_hdr *ipv4_hdr = (struct ipv4_hdr *)l3_hdr; + struct ipv6_hdr *ipv6_hdr = (struct ipv6_hdr *)l3_hdr; + + DPAA_TX_LOG(DEBUG, "Calculating checksum for mbuf: %p", mbuf); + + if (((mbuf->packet_type & RTE_PTYPE_L3_MASK) == RTE_PTYPE_L3_IPV4) || + ((mbuf->packet_type & RTE_PTYPE_L3_MASK) == + RTE_PTYPE_L3_IPV4_EXT)) { + ipv4_hdr = (struct ipv4_hdr *)l3_hdr; + ipv4_hdr->hdr_checksum = 0; + ipv4_hdr->hdr_checksum = rte_ipv4_cksum(ipv4_hdr); + } else if (((mbuf->packet_type & RTE_PTYPE_L3_MASK) == + RTE_PTYPE_L3_IPV6) || + ((mbuf->packet_type & RTE_PTYPE_L3_MASK) == + RTE_PTYPE_L3_IPV6_EXT)) + ipv6_hdr = (struct ipv6_hdr *)l3_hdr; + + if ((mbuf->packet_type & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_TCP) { + struct tcp_hdr *tcp_hdr = (struct tcp_hdr *)(l3_hdr + + mbuf->l3_len); + tcp_hdr->cksum = 0; + if (eth_hdr->ether_type == htons(ETHER_TYPE_IPv4)) + tcp_hdr->cksum = rte_ipv4_udptcp_cksum(ipv4_hdr, + tcp_hdr); + else /* assume ethertype == ETHER_TYPE_IPv6 */ + tcp_hdr->cksum = rte_ipv6_udptcp_cksum(ipv6_hdr, + tcp_hdr); + } else if ((mbuf->packet_type & RTE_PTYPE_L4_MASK) == + RTE_PTYPE_L4_UDP) { + struct udp_hdr *udp_hdr = (struct udp_hdr *)(l3_hdr + + mbuf->l3_len); + udp_hdr->dgram_cksum = 0; + if (eth_hdr->ether_type == htons(ETHER_TYPE_IPv4)) + udp_hdr->dgram_cksum = rte_ipv4_udptcp_cksum(ipv4_hdr, + udp_hdr); + else /* assume ethertype == ETHER_TYPE_IPv6 */ + udp_hdr->dgram_cksum = rte_ipv6_udptcp_cksum(ipv6_hdr, + udp_hdr); + } +} + +static inline void dpaa_checksum_offload(struct rte_mbuf *mbuf, + struct qm_fd *fd, char *prs_buf) +{ + struct dpaa_eth_parse_results_t *prs; + + DPAA_TX_LOG(DEBUG, " Offloading checksum for mbuf: %p", mbuf); + + prs = GET_TX_PRS(prs_buf); + prs->l3r = 0; + prs->l4r = 0; + if (((mbuf->packet_type & RTE_PTYPE_L3_MASK) == RTE_PTYPE_L3_IPV4) || + ((mbuf->packet_type & RTE_PTYPE_L3_MASK) == + RTE_PTYPE_L3_IPV4_EXT)) + prs->l3r = DPAA_L3_PARSE_RESULT_IPV4; + else if (((mbuf->packet_type & RTE_PTYPE_L3_MASK) == + RTE_PTYPE_L3_IPV6) || + ((mbuf->packet_type & RTE_PTYPE_L3_MASK) == + RTE_PTYPE_L3_IPV6_EXT)) + prs->l3r = DPAA_L3_PARSE_RESULT_IPV6; + + if ((mbuf->packet_type & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_TCP) + prs->l4r = DPAA_L4_PARSE_RESULT_TCP; + else if ((mbuf->packet_type & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_UDP) + prs->l4r = DPAA_L4_PARSE_RESULT_UDP; + + prs->ip_off[0] = mbuf->l2_len; + prs->l4_off = mbuf->l3_len + mbuf->l2_len; + /* Enable L3 (and L4, if TCP or UDP) HW checksum*/ + fd->cmd = DPAA_FD_CMD_RPD | DPAA_FD_CMD_DTC; +} + static inline struct rte_mbuf *dpaa_eth_fd_to_mbuf(struct qm_fd *fd, uint32_t ifid) { @@ -358,6 +434,19 @@ tx_on_dpaa_pool_unsegmented(struct rte_mbuf *mbuf, } rte_pktmbuf_free(mbuf); } + + if (mbuf->ol_flags & DPAA_TX_CKSUM_OFFLOAD_MASK) { + if (mbuf->data_off < (DEFAULT_TX_ICEOF + + sizeof(struct dpaa_eth_parse_results_t))) { + DPAA_TX_LOG(DEBUG, "Checksum offload Err: " + "Not enough Headroom " + "space for correct Checksum offload." + "So Calculating checksum in Software."); + dpaa_checksum(mbuf); + } else { + dpaa_checksum_offload(mbuf, fd_arr, mbuf->buf_addr); + } + } } /* Handle all mbufs on dpaa BMAN managed pool */ diff --git a/drivers/net/dpaa/dpaa_rxtx.h b/drivers/net/dpaa/dpaa_rxtx.h index 68d2c41..624ddda 100644 --- a/drivers/net/dpaa/dpaa_rxtx.h +++ b/drivers/net/dpaa/dpaa_rxtx.h @@ -41,6 +41,22 @@ /* IC offsets from buffer header address */ #define DEFAULT_RX_ICEOF 16 +#define DEFAULT_TX_ICEOF 16 + +/* + * Values for the L3R field of the FM Parse Results + */ +/* L3 Type field: First IP Present IPv4 */ +#define DPAA_L3_PARSE_RESULT_IPV4 0x80 +/* L3 Type field: First IP Present IPv6 */ +#define DPAA_L3_PARSE_RESULT_IPV6 0x40 +/* Values for the L4R field of the FM Parse Results + * See $8.8.4.7.20 - L4 HXS - L4 Results from DPAA-Rev2 Reference Manual. + */ +/* L4 Type field: UDP */ +#define DPAA_L4_PARSE_RESULT_UDP 0x40 +/* L4 Type field: TCP */ +#define DPAA_L4_PARSE_RESULT_TCP 0x20 #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63 /**