diff mbox

[dpdk-dev,v3,21/40] maintainers: claim ownership of DPAA Mempool driver

Message ID 20170823141213.25476-22-shreyansh.jain@nxp.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Shreyansh Jain Aug. 23, 2017, 2:11 p.m. UTC 
  Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon Sept. 21, 2017, 9:56 p.m. UTC | #1 
23/08/2017 16:11, Shreyansh Jain:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -409,6 +409,7 @@ NXP dpaa
>  M: Hemant Agrawal <hemant.agrawal@nxp.com>
>  M: Shreyansh Jain <shreyansh.jain@nxp.com>
>  F: drivers/bus/dpaa/
> +F: drivers/mempool/dpaa/
>  F: doc/guides/nics/dpaa.rst
>  F: doc/guides/nics/features/dpaa.ini

This kind of patch can be squashed in the first patch introducing
this new directory.
Shreyansh Jain Sept. 22, 2017, 6:47 a.m. UTC | #2 
On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote:
> 23/08/2017 16:11, Shreyansh Jain:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -409,6 +409,7 @@ NXP dpaa
>>   M: Hemant Agrawal <hemant.agrawal@nxp.com>
>>   M: Shreyansh Jain <shreyansh.jain@nxp.com>
>>   F: drivers/bus/dpaa/
>> +F: drivers/mempool/dpaa/
>>   F: doc/guides/nics/dpaa.rst
>>   F: doc/guides/nics/features/dpaa.ini
> 
> This kind of patch can be squashed in the first patch introducing
> this new directory.
> 

Then the patch script (devtools/check-git-log.sh) reports error - I 
think. That is the primary reason I split them across multiple patches.
You sure that doesn't matter?
Thomas Monjalon Sept. 22, 2017, 6:53 a.m. UTC | #3 
22/09/2017 08:47, Shreyansh Jain:
> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote:
> > 23/08/2017 16:11, Shreyansh Jain:
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -409,6 +409,7 @@ NXP dpaa
> >>   M: Hemant Agrawal <hemant.agrawal@nxp.com>
> >>   M: Shreyansh Jain <shreyansh.jain@nxp.com>
> >>   F: drivers/bus/dpaa/
> >> +F: drivers/mempool/dpaa/
> >>   F: doc/guides/nics/dpaa.rst
> >>   F: doc/guides/nics/features/dpaa.ini
> > 
> > This kind of patch can be squashed in the first patch introducing
> > this new directory.
> > 
> 
> Then the patch script (devtools/check-git-log.sh) reports error - I 
> think. That is the primary reason I split them across multiple patches.
> You sure that doesn't matter?

Which error?

To be clear I suggest to squash with patch 19 where
drivers/mempool/dpaa/Makefile is introduced.
Thomas Monjalon Sept. 22, 2017, 7:35 a.m. UTC | #4 
22/09/2017 09:37, Shreyansh Jain:
> On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote:
> > 22/09/2017 08:47, Shreyansh Jain:
> >> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote:
> >>> 23/08/2017 16:11, Shreyansh Jain:
> >>>> --- a/MAINTAINERS
> >>>> +++ b/MAINTAINERS
> >>>> @@ -409,6 +409,7 @@ NXP dpaa
> >>>>    M: Hemant Agrawal <hemant.agrawal@nxp.com>
> >>>>    M: Shreyansh Jain <shreyansh.jain@nxp.com>
> >>>>    F: drivers/bus/dpaa/
> >>>> +F: drivers/mempool/dpaa/
> >>>>    F: doc/guides/nics/dpaa.rst
> >>>>    F: doc/guides/nics/features/dpaa.ini
> >>>
> >>> This kind of patch can be squashed in the first patch introducing
> >>> this new directory.
> >>
> >> Then the patch script (devtools/check-git-log.sh) reports error - I
> >> think. That is the primary reason I split them across multiple patches.
> >> You sure that doesn't matter?
> > 
> > Which error?
> > 
> > To be clear I suggest to squash with patch 19 where
> > drivers/mempool/dpaa/Makefile is introduced.
> 
> Yes, I understand that.
> It would report error that the headline is wrong because I am hitting 
> different directories - "MAINTAINERS" and "drivers/mempool/*" with the 
> same patch having headline "mempool/*".

The test you are talking about has this comment:
	# check headline prefix when touching only drivers, e.g. net/<driver name>
If you hit a warning, there is a bug.
Shreyansh Jain Sept. 22, 2017, 7:37 a.m. UTC | #5 
On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote:
> 22/09/2017 08:47, Shreyansh Jain:
>> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote:
>>> 23/08/2017 16:11, Shreyansh Jain:
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -409,6 +409,7 @@ NXP dpaa
>>>>    M: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>    M: Shreyansh Jain <shreyansh.jain@nxp.com>
>>>>    F: drivers/bus/dpaa/
>>>> +F: drivers/mempool/dpaa/
>>>>    F: doc/guides/nics/dpaa.rst
>>>>    F: doc/guides/nics/features/dpaa.ini
>>>
>>> This kind of patch can be squashed in the first patch introducing
>>> this new directory.
>>>
>>
>> Then the patch script (devtools/check-git-log.sh) reports error - I
>> think. That is the primary reason I split them across multiple patches.
>> You sure that doesn't matter?
> 
> Which error?
> 
> To be clear I suggest to squash with patch 19 where
> drivers/mempool/dpaa/Makefile is introduced.
> 

Yes, I understand that.
It would report error that the headline is wrong because I am hitting 
different directories - "MAINTAINERS" and "drivers/mempool/*" with the 
same patch having headline "mempool/*".
Shreyansh Jain Sept. 27, 2017, 8:30 a.m. UTC | #6 
On Friday 22 September 2017 01:05 PM, Thomas Monjalon wrote:
> 22/09/2017 09:37, Shreyansh Jain:
>> On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote:
>>> 22/09/2017 08:47, Shreyansh Jain:
>>>> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote:
>>>>> 23/08/2017 16:11, Shreyansh Jain:
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -409,6 +409,7 @@ NXP dpaa
>>>>>>     M: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>>>     M: Shreyansh Jain <shreyansh.jain@nxp.com>
>>>>>>     F: drivers/bus/dpaa/
>>>>>> +F: drivers/mempool/dpaa/
>>>>>>     F: doc/guides/nics/dpaa.rst
>>>>>>     F: doc/guides/nics/features/dpaa.ini
>>>>>
>>>>> This kind of patch can be squashed in the first patch introducing
>>>>> this new directory.
>>>>
>>>> Then the patch script (devtools/check-git-log.sh) reports error - I
>>>> think. That is the primary reason I split them across multiple patches.
>>>> You sure that doesn't matter?
>>>
>>> Which error?
>>>
>>> To be clear I suggest to squash with patch 19 where
>>> drivers/mempool/dpaa/Makefile is introduced.
>>
>> Yes, I understand that.
>> It would report error that the headline is wrong because I am hitting
>> different directories - "MAINTAINERS" and "drivers/mempool/*" with the
>> same patch having headline "mempool/*".
> 
> The test you are talking about has this comment:
> 	# check headline prefix when touching only drivers, e.g. net/<driver name>
> If you hit a warning, there is a bug.

Somehow I had the impression it throws an error in such cases. I changed 
as suggested and check-git-log.sh script didn't throw any error - I was 
wrong. Thanks for correcting.

-
Shreyansh
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 10646a4..74b7aba 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -409,6 +409,7 @@  NXP dpaa
 M: Hemant Agrawal <hemant.agrawal@nxp.com>
 M: Shreyansh Jain <shreyansh.jain@nxp.com>
 F: drivers/bus/dpaa/
+F: drivers/mempool/dpaa/
 F: doc/guides/nics/dpaa.rst
 F: doc/guides/nics/features/dpaa.ini