From patchwork Wed Aug 23 07:10:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 27739 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 01E707D53; Wed, 23 Aug 2017 09:11:09 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0052.outbound.protection.outlook.com [104.47.2.52]) by dpdk.org (Postfix) with ESMTP id 18C747D4F for ; Wed, 23 Aug 2017 09:11:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GRwZ7Uc7lRvyPJIcnaRw9kmHjlJyf6QAlkhmgSsUI+o=; b=FD5Pmndej6g4H/h9qbTgwJvFr/FUilr1MlrO5M2Xt9oVHZkqFUUdTr+5JTnGKQU+aa34qVaEqqbtbmryZ1efCUrkxY8BIINUbzokz/MyvenRZqEptKF84AG7JVjfgLGAtY3+8Txs+1NoWu9VkEJFa2CsU3g+wjhBmk91vssVY5o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by HE1PR05MB3146.eurprd05.prod.outlook.com (2603:10a6:7:36::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Wed, 23 Aug 2017 07:11:04 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, Xueming Li Date: Wed, 23 Aug 2017 10:10:58 +0300 Message-Id: <20170823071058.115338-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: VI1PR0102CA0014.eurprd01.prod.exchangelabs.com (2603:10a6:802::27) To HE1PR05MB3146.eurprd05.prod.outlook.com (2603:10a6:7:36::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef2e620e-f058-4630-1280-08d4e9f61eaf X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:HE1PR05MB3146; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3146; 3:tuNWKJAml3mRpLIi9tA3I48oN3GPjfXZ0rCB+Ce43kQq0aAy0IjiCaF98Ta0Kxlrzkz/f92XMdHgqfifbFxzNC+Bz6APkC57zhwIJqHUqU9+ko6b1HDlCZu2S7H3SRkVi/o9Jn7LGOfyLrz122vo0a3N0SE9GHnS0+cHf4VeTVvhpvEkTfmHEPUBmX3zV9DAbBKbXuU244tedGEr0jjraVWu2Cj/3G2bmbWWrozm2cpKytBihXgoYPhxnQjAfZrM; 25:xQlpkHLwbAUwBROOv8B3Gkv9NQ6vzbRmo+Y8Jk8BgNZzSKi/tNmtPbhzU1CXNNRAqKc1HoM6D7xcQFgVsZPMRpmgZD87VT9YC7AkotpRByoIeSVvMERcXTDL5PZAQBmf54vxmEZU1KaJmlRqpKf2hfD2mGBMeMnHkjyIV7FNNgu2Y8y9P17s8PU5L54rxXCs5Fyh0WvtVI3Gc108C/NPzagd2tWM2dpXoAqbI48AEyzP/idjakB3UluO3UkcnSWtVkDC2L1P/8QVAU+wT+0B8Bj3v1qJWxVIt9iycC6/mk4dR63fU/qAt0Vxl9+poK4SKBXRdSaiGVfp375d/vu4TA==; 31:J0m9UMt8SKbtjfDA5ovob5vZb9qZfLNVF36sNReeGHS68Yjzi9xSgFWiyEl2UkOhPqWxbMV5lN9eVD9aaepsfo1vxaXKonKdghCPz0Uvn9hcrKcr67L3k/Dmqp28+xeSGds6oSUudQYw7GdHbxIzIM4+F4/QmlcXbLAQlUZmxmA+keY3sg/0wgYWvShe5o3oLHdVkSA8BtK2FB5LY36vL3AYH78Shq8oAu2FEcKZzcs= X-MS-TrafficTypeDiagnostic: HE1PR05MB3146: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3146; 20:Lkh9BiGUih2Po/lYt2MfPCej4766YBk3yACYNnBcNBC2lsNDu2ow0eo89i/91knWLSr8s1+kRkEK1NIeVJo41uKrY+pp+i3G4iesqwAyKggso0Jg4dT3G/6kfRo+vpwofK87u3NxEu8trqTCTm/lvc3RFXa2aq+ZwL8b4ES3xp2gXLygzMmxy9ftb7hdVeCgQ9DVfFpRopE1OkZN8Ik0YHwcfVGgYRrRCd2MpDSFzAFlVIRIRKSdS6Xbqx4cfx7gCOg4obvvmFTWVGpdOx/ZhA8J+ASf468Xb/Q5ntWDTPkIiPsU4Lj5lbfb0zBxjey3THMvpMIV8a6strqxYbgrrpU6R9Vc5tx1n9eJ/SzvbbtgGAj6gQIfkxq/vRbLHGpzMzRPUNSulmepW2L5jTM/E8chmaOfYAXi6skatxeU6xXbApqKzK1/JBxHMVGsREal3ee7QVJO7xyAjDXe4Jh00H7KRrbvXGX5BAwQM771G71T+t7tMZJ0Sra94BrfycdX; 4:Ax8ye+Vpv273KqVrnRzO4z40uXJkmFw3Xmdh8Fp89nCQTTdDOGdZIOukAHMFsPl7BfaGiujVhOJc6rGpdpNT4+4nK1nT+lK5hZS7HJCEc4LwUW5G+fIoA2I4bjf+cc6Lp3FbexqzHCeej0HCpoi/5W4h6JD3bE8egZv/xZuLQgFiZaJ/j7/Gi7DHEozbwdzRGkh6dqbcG+4tE+bGkByjqJD3k0er3MDD5qq1JYca2Zs2QkmS1x5XKu1A6KsxC8CE X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR05MB3146; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR05MB3146; X-Forefront-PRVS: 040866B734 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(189002)(199003)(189998001)(966005)(5003940100001)(2906002)(36756003)(7350300001)(50986999)(105586002)(33646002)(106356001)(81166006)(97736004)(69596002)(42186005)(478600001)(33026002)(86362001)(8676002)(4326008)(50226002)(25786009)(68736007)(81156014)(101416001)(66066001)(48376002)(47776003)(50466002)(6666003)(53376002)(21086003)(107886003)(110136004)(5660300001)(6306002)(305945005)(55016002)(1076002)(3846002)(6116002)(7736002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB3146; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB3146; 23:ODpqm5r99v9svSwca9Oi3H2QfhCwuOLSeI6hvNWwN?= G49GOxgZhCS3GiBs6U022mVf0khWHCP/SCLcuNRnWawAQLRnjVfwipBHxloxMDBQTGc69xdd8Y3nqK4rjnCw+91PJQniKrU6Z8IRhuIXQZ4GhvuJx5Cao+JulbmrfRUDAiuirPfRs+qTscNft+SEnQb5dO6inxgVvYxZk22+zvuNoOtKRB2ryxRx2peueFYZtPJBLQTAdHZYp5FIDS5UxiodpFXCZuot2UtgZmBk9LmXYH1tLJkhNNgYp0YI55ekYUdPWnXOQGaFbHH/0jKIFuAetbY1QN4q5SBthlJA0YfHhNuiibfgDPTK8KxeppAhfLUUYanTX9HoCeRFdDmySeIRTSFnMfTO/tgXnkuOCvXUFe/QLf0tGBF6SvDl7b3Svo0EbAsqxZw51BKqcBQo+/Bo6j4Q85OnApc1MqjWGnujwe6wVHRw1LrU0ZNbVDBT7fNp59hF3QNej/SOcLFwTVptKitZMfyNY294iy1oCkAGTLIYeWotp33K+am+vBJDfcRznDK2bvq5pEAK0HtDfnWWU0zn8gJb7KRy3/nntTtj9aa2cZ7udwgny9sZJ8z3p9wbdx4ijUxcnaF/2T9RBEWkkrWVDkQZxMLwHs2H5R3Uc0RK5CslmDCCA5543fmmg6lPgDFaE25osv55I8CZQdnnHnvZwFBid+zNm1Dw2mAUemkUQe8+i6NISAFzzLEaUmgqLD24zTrv22p/fHDhjXzrAYjqtnOVQ/6YSPbnUiGrXixpbKiqoY58gRGRZspzu3PU9aLzrZEtarUHcXVP6ym7hT+z47tdUTs5dMsgBoKEFCbETznCoRvR6xosQ1W9C9W3MpreDu5aPN2q853dAH3FFwJs89NxSdrn2nDLAR7bZgNhGGirJoHCJfdGJrSK2ZlYaEln95ncCo4DPe2Rs2rysjqnPyAZusz+DIjSJh/1YvM/rGDdD7cn08jpAtKdpsATbDjWryCuGeSdlY+nb1MbtuAun6iO7zti3QBflmdDwPNCAVqTVJogBgSprnXTMSHzQ44I3QlWfm9+9BSQV1T/QwJj/pKCJy+EvvrWM0UHwmSpMHFhdRSOTxiFaQ3z+SSQqHkBmvHlETMkXLZYs2F1EaOpvEEAPtgc5f14+rxwA== X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3146; 6:K5dMw9LBs+tP3tOL25UNsiikVFmno+121HGULV4vk+dHI9yvMPLc/RRcEpvwXIGl1CPChSE+qYfRXSNdBPGPotdYW588Asf7PZH1aThwhcLEXIuvB2YFOa19sfepXZV9KUDhmRVaXdnAQW/R8o9hNIEUdTstdtTHeOJJjJqvrp92i26WS4xoXTQCXnKOGHwZFgZV7Fo8LLwNL7V9MMWsSOeReqlHnS+r1Yis0b1RbjJ3NBwDjcS+GonBGqAwfDqS0Rg9xEWEglYSZtbfGuc+B4xk2XI00fRFh9jTI4xiGDqol7OOwa8Ew0oS/ZznbvqasGc2LPQyTLlaUj1oFzEEvw==; 5:Ea8//z+NvSVBE1yFmmKP4B1A6pfpRjTr6BSw83YXabfFx23z21GyG4QUtFbNbSU9gnYMc/1cTCzGZAzz/9eSis9ghPElNRW2V1zFL+ej40ep25f6vY4UBYer6s7ch+IbqprLeK7rRAiNaJEA3kQYSQ==; 24:x+ZTm1UfVavoYQRFkwyjwCKpA1q01IdIKB2zw9Gi9f8Qm2exZWsAGfkpantR4U9eQ0QJcWQiRCiC9X1zuAKm2Knb9Fm8jrqLJ6yLEBnVGu8=; 7:tLR2ISauHDRDIX9Kd9W7xMNMvbe4pPUenjroFO4PU+LNbeN3Bu9jT3y8MyVKnmhR+Fwi/ngXzcPLTzzFcn8ysXDK9Odu0Xk54bqF6SNdYT5G/zQFQ0hu0b5hzuAoqHxCkWQzZhqRvqZ/OgA9F+NCulEGSlTayGluzU+Wjq1FEDWMmzMN0LM8f5HJdkuMSQ1WEShajWkzMl/FNuNPzZITr5fskFZERjoWNSqepxY2cfk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 07:11:04.2880 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB3146 Subject: [dpdk-dev] [PATCH] net/mlx5: extend debug logs verbosity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Extend debug logs verbosity by printing the full completion with error along with the entire txq in case of error. For the Rx case no logs were added since such errors are counted and recovered by the Rx data path. Such prints are essential to understand the root cause for the error. Signed-off-by: Shahaf Shuler Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- This patch should be applied only after the series: http://dpdk.org/dev/patchwork/patch/27367/ --- drivers/net/mlx5/mlx5_rxtx.h | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index 7de1d1086..43debb309 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -55,6 +55,7 @@ #include #include #include +#include #ifdef PEDANTIC #pragma GCC diagnostic error "-Wpedantic" #endif @@ -419,16 +420,24 @@ check_cqe(volatile struct mlx5_cqe *cqe, if ((syndrome == MLX5_CQE_SYNDROME_LOCAL_LENGTH_ERR) || (syndrome == MLX5_CQE_SYNDROME_REMOTE_ABORTED_ERR)) return 0; - if (!check_cqe_seen(cqe)) + if (!check_cqe_seen(cqe)) { ERROR("unexpected CQE error %u (0x%02x)" " syndrome 0x%02x", op_code, op_code, syndrome); + rte_hexdump(stderr, "MLX5 Error CQE:", + (const void *)((uintptr_t)err_cqe), + sizeof(*err_cqe)); + } return 1; } else if ((op_code != MLX5_CQE_RESP_SEND) && (op_code != MLX5_CQE_REQ)) { - if (!check_cqe_seen(cqe)) + if (!check_cqe_seen(cqe)) { ERROR("unexpected CQE opcode %u (0x%02x)", op_code, op_code); + rte_hexdump(stderr, "MLX5 CQE:", + (const void *)((uintptr_t)cqe), + sizeof(*cqe)); + } return 1; } #endif /* NDEBUG */ @@ -483,8 +492,13 @@ mlx5_tx_complete(struct txq *txq) #ifndef NDEBUG if ((MLX5_CQE_OPCODE(cqe->op_own) == MLX5_CQE_RESP_ERR) || (MLX5_CQE_OPCODE(cqe->op_own) == MLX5_CQE_REQ_ERR)) { - if (!check_cqe_seen(cqe)) + if (!check_cqe_seen(cqe)) { ERROR("unexpected error CQE, TX stopped"); + rte_hexdump(stderr, "MLX5 TXQ:", + (const void *)((uintptr_t)txq->wqes), + ((1 << txq->wqe_n) * + MLX5_WQE_SIZE)); + } return; } #endif /* NDEBUG */