diff mbox

[dpdk-dev] drivers/aesni_gcm: fix zero data operation

Message ID 20170814004521.75366-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo Aug. 14, 2017, 12:45 a.m. UTC 
  When data length passed to the PMD was zero,
the PMD was trying to get more data from a non-existent
next segment.

Fixes: 9c2a5775c028 ("crypto/aesni_gcm: migrate from MB library to ISA-L")
Cc: stable@dpdk.org

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rybalchenko, Kirill Sept. 4, 2017, 1:14 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Monday 14 August 2017 01:45
> To: Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] drivers/aesni_gcm: fix zero data operation
> 
> When data length passed to the PMD was zero, the PMD was trying to get
> more data from a non-existent next segment.
> 
> Fixes: 9c2a5775c028 ("crypto/aesni_gcm: migrate from MB library to ISA-L")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
De Lara Guarch, Pablo Sept. 6, 2017, 10:27 a.m. UTC | #2 
> -----Original Message-----
> From: Rybalchenko, Kirill
> Sent: Monday, September 4, 2017 2:14 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] drivers/aesni_gcm: fix zero data operation
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Monday 14 August 2017 01:45
> > To: Doherty, Declan <declan.doherty@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] drivers/aesni_gcm: fix zero data operation
> >
> > When data length passed to the PMD was zero, the PMD was trying to get
> > more data from a non-existent next segment.
> >
> > Fixes: 9c2a5775c028 ("crypto/aesni_gcm: migrate from MB library to
> > ISA-L")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> >  drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> 
> Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> 
> 

Fixed title to "crypto/aesni_gcm: ..."

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
index e051624..5c9004f 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
@@ -224,7 +224,7 @@  process_gcm_crypto_op(struct aesni_gcm_qp *qp, struct rte_crypto_op *op,
 
 	RTE_ASSERT(m_src != NULL);
 
-	while (offset >= m_src->data_len) {
+	while (offset >= m_src->data_len && data_length != 0) {
 		offset -= m_src->data_len;
 		m_src = m_src->next;