From patchwork Fri Jul 21 11:25:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonid Myravjev X-Patchwork-Id: 27101 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 07C7C324D; Fri, 21 Jul 2017 10:23:45 +0200 (CEST) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 194B02C55 for ; Fri, 21 Jul 2017 10:23:44 +0200 (CEST) Received: by mail-lf0-f65.google.com with SMTP id h63so1880894lfg.4 for ; Fri, 21 Jul 2017 01:23:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=aeE+H/8ZjyYXJVZBEhFH5NBZ2untRz1U5XXHBDZ0VFU=; b=mHamkgqtqx9oAmiQl5h3zQV56Bb5M+ax6qkM0A7bVYo+A37RnUSciYXFddOUhsLtCk NqSLKvafDRIYtw0xzrvjXY/ySajGThOkFLcueOjOAiAVPvdYs+GawG2vhBmGI2JeeU9y 3NzNTPbpu4JbfDO8xVhwiorCBRQxQuKw38DJBgtDC5ITHRCIeLzKsnBjnb4D3PuJWcJS BQWpb0E+HzACknvRlD5mtuuzMlpKRJfNkm9bsvhYwFtA91etEbxJPq2pnBvUv3XNlzp0 tmZL/Pzg2uNzvzmskWOeA6NPtbf5UApp9cNrX1+Pv4LzWQpvio03TPaF90HjRP7l5pcO fu5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=aeE+H/8ZjyYXJVZBEhFH5NBZ2untRz1U5XXHBDZ0VFU=; b=reElvLl/baihll5WmzCcRVeILvdbPZTk+N9sPOKlQ6LM/tGDXXsRGGFcBY2L6Aqs/C 794Eqc+l+DpTYjZNKqqKe0VQVFxqPv9s6DOKGzwpozSKDlK5Ea4LVBZ8YJDdRoeDgVDO sTsIUdibvr9jUxUxDb44OIivsEi3dF66wJg7ZdeyqoXymWDhPRpD8vMf4Elqt8OtmiLL Ajy+4bLD2KRk2mhbEdlTsKWr3f6oQvBOw4T3h4gVZdomB1O/ZshdKYXcTwpzNXLkWHXu NcaWupn2srW69eR/I8IgRDXHBtaoIhWfBhZMLiLZEVsEIocbC9qJMw71VeonNdPAXhDM ybQg== X-Gm-Message-State: AIVw112j0xnueHdIewmpzcxSQfSucRUM5D9nmEKkCoBOtxA6Si4IT/+l XHB/NblN5ysXaqNHdiQ= X-Received: by 10.46.21.78 with SMTP id 14mr2039578ljv.47.1500625423509; Fri, 21 Jul 2017 01:23:43 -0700 (PDT) Received: from localhost.localdomain ([77.108.111.101]) by smtp.gmail.com with ESMTPSA id n103sm817453lfi.57.2017.07.21.01.23.42 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 21 Jul 2017 01:23:42 -0700 (PDT) From: Leonid Myravjev To: dev@dpdk.org Cc: Leonid Myravjev , Leonid Myravjev Date: Fri, 21 Jul 2017 11:25:38 +0000 Message-Id: <20170721112538.13523-1-asm@asm.pp.ru> X-Mailer: git-send-email 2.13.0 Subject: [dpdk-dev] [PATCH] net/ixgbe: Wrong PCI ids for PMD_INFO_STRING. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The pci_id_ixgbe_map table has only PCI_ANY_ID for .subvend and .subdev in all entries. Using of IXGBE_SUBDEV_ID_82599_SFP for 'dev' is not correct. It generates the wrong PMD_INFO_STRING. The output of the program "dpdk-pmdinfo.py" is confusing. Signed-off-by: Leonid Myravjev Reviewed-by: Ferruh Yigit --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 194058fb8..9473a0fee 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -442,13 +442,8 @@ static const struct rte_pci_id pci_id_ixgbe_map[] = { { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_KX4_MEZZ) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_KR) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_COMBO_BACKPLANE) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_KX4_KR_MEZZ) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_CX4) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_SFP) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_RNDC) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_560FLR) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_ECNA_DP) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_BACKPLANE_FCOE) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP_FCOE) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP_EM) },