diff mbox

[dpdk-dev] net/ixgbe: Wrong PCI ids for PMD_INFO_STRING.

Message ID 20170721112538.13523-1-asm@asm.pp.ru (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Leonid Myravjev July 21, 2017, 11:25 a.m. UTC
The pci_id_ixgbe_map table has only PCI_ANY_ID for
.subvend and .subdev in all entries. Using of IXGBE_SUBDEV_ID_82599_SFP
for 'dev' is not correct. It generates the wrong PMD_INFO_STRING.
The output of the program "dpdk-pmdinfo.py" is confusing.

Signed-off-by: Leonid Myravjev <myravjev@amicon.ru>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Ferruh Yigit July 21, 2017, 10:29 a.m. UTC | #1
On 7/21/2017 12:25 PM, Leonid Myravjev wrote:
> The pci_id_ixgbe_map table has only PCI_ANY_ID for
> .subvend and .subdev in all entries. Using of IXGBE_SUBDEV_ID_82599_SFP
> for 'dev' is not correct. It generates the wrong PMD_INFO_STRING.
> The output of the program "dpdk-pmdinfo.py" is confusing.
> 
> Signed-off-by: Leonid Myravjev <myravjev@amicon.ru>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit July 21, 2017, 10:51 a.m. UTC | #2
On 7/21/2017 11:29 AM, Ferruh Yigit wrote:
> On 7/21/2017 12:25 PM, Leonid Myravjev wrote:
>> The pci_id_ixgbe_map table has only PCI_ANY_ID for
>> .subvend and .subdev in all entries. Using of IXGBE_SUBDEV_ID_82599_SFP
>> for 'dev' is not correct. It generates the wrong PMD_INFO_STRING.
>> The output of the program "dpdk-pmdinfo.py" is confusing.
>>
>> Signed-off-by: Leonid Myravjev <myravjev@amicon.ru>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 194058fb8..9473a0fee 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -442,13 +442,8 @@  static const struct rte_pci_id pci_id_ixgbe_map[] = {
 	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_KX4_MEZZ) },
 	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_KR) },
 	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_COMBO_BACKPLANE) },
-	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_KX4_KR_MEZZ) },
 	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_CX4) },
 	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP) },
-	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_SFP) },
-	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_RNDC) },
-	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_560FLR) },
-	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_ECNA_DP) },
 	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_BACKPLANE_FCOE) },
 	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP_FCOE) },
 	{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP_EM) },