From patchwork Fri Jul 21 10:56:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonid Myravjev X-Patchwork-Id: 27099 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id CA0CA2C55; Fri, 21 Jul 2017 09:56:16 +0200 (CEST) Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 2CC862C2B for ; Fri, 21 Jul 2017 09:56:15 +0200 (CEST) Received: by mail-lf0-f66.google.com with SMTP id l200so2814299lfb.3 for ; Fri, 21 Jul 2017 00:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=pxmoZzWovYxY5podV3VAYdS35CiFH2BLOiuFZh+0HHg=; b=G4Fo5N/j32+FD1DyfBOtLh4jQ9/OnZEhA6w5SmPOf/Bngxk8Eedk8t0LnNlmlhri+3 CDLzf4vxJ+vmC3ZfX/Sls8OMdgNUyxXL20YzPwYR0jt0j8nXcDxg3OKTNwtu5Xe4NcfC gUPh3Zsp+f8cwVR8fLJnjV1oO84LFG4O4thMlblY52JgFOS/WmHVDrde4Os75GoZdZmf ShsKY/pB1/B+6xW12wiGnyH9PVw0QGKQhDc+mI2XQw67oqDNsdtpu1iB9dFsDlhhCfh9 yWiQG3j1nwe4gS75Isf4LhjQT2eeJ/X7TqcO6C1fa6ND4XrmkbZxEiz6uoPQmzCm75oN crCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=pxmoZzWovYxY5podV3VAYdS35CiFH2BLOiuFZh+0HHg=; b=BGFOw87aHNNpjzULApMesP6q24KQ2hRt2ByFis/RBxNHjoof3M29FimjX2GUHzs8Pc aOSkxF6MUTTYNV44sxJzfEb2H1eV+anpqdYeWgy6dcFfxzpPmfyPYesKQo7KUXZbZqqy 4jXU1XCIpAm9XQyLYPEyBBIa/iwcHUd9PW6EizrtFkdKIU+HFmVQ8yFS5Lwhfz9Xbieg gswHmxlnxIPXYDmnt1pJstkfyEJktw9PpPzZ0xr66aCtKNje7sfnpdtwkwzm/NSPNMnj Zlow068YYTSmismguLKSDwBsvsl7MHdwCEkDr2U5xKSqDpOCbI8a21IldJ3TPHZYKD8j S2Dg== X-Gm-Message-State: AIVw113oF9bJKf89dYQQpb2nGuNJEfmmJbPAlgD2m2EOGe0dfUme2z7t 7lzpnUguOuUjIZp1AsY= X-Received: by 10.25.193.193 with SMTP id r184mr1445732lff.158.1500623774503; Fri, 21 Jul 2017 00:56:14 -0700 (PDT) Received: from localhost.localdomain ([77.108.111.101]) by smtp.gmail.com with ESMTPSA id y10sm810887lja.49.2017.07.21.00.56.13 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 21 Jul 2017 00:56:13 -0700 (PDT) From: Leonid Myravjev To: dev@dpdk.org Cc: konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, Leonid Myravjev Date: Fri, 21 Jul 2017 10:56:57 +0000 Message-Id: <20170721105657.4101-1-asm@asm.pp.ru> X-Mailer: git-send-email 2.13.0 Subject: [dpdk-dev] [PATCH] net/ixgbe: Wrong PCI ids for PMD_INFO_STRING. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The pci_id_ixgbe_map table has only PCI_ANY_ID for .subvend and .subdev in all entries. Using of IXGBE_SUBDEV_ID_82599_SFP for 'dev' is not correct. It generates the wrong PMD_INFO_STRING. The output of the program "dpdk-pmdinfo.py" is confusing. --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 194058fb8..9473a0fee 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -442,13 +442,8 @@ static const struct rte_pci_id pci_id_ixgbe_map[] = { { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_KX4_MEZZ) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_KR) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_COMBO_BACKPLANE) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_KX4_KR_MEZZ) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_CX4) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_SFP) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_RNDC) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_560FLR) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_ECNA_DP) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_BACKPLANE_FCOE) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP_FCOE) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP_EM) },