From patchwork Fri Jul 14 21:12:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Blunck X-Patchwork-Id: 26930 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id DF9077CAB; Fri, 14 Jul 2017 23:12:39 +0200 (CEST) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 5BBB2568A for ; Fri, 14 Jul 2017 23:12:32 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id p204so12802626wmg.1 for ; Fri, 14 Jul 2017 14:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=XXhqxQAEGPR58LP8WJfDHExCqYtPmUCfbz0HcHsv7JE=; b=bFRDOzc+Tp41N8/T4WhYzOtFe0TnCVP+r1HpheI//cMEF1qye6XJF8VxvnMJciC4yt F56lYZFDmijMaQzrVNBRqZoauuj4vzYNWt//+hPqdzyC6v1Ea7QUe/ukzCEgOdmYmHuD 88fDDWJxU8Tc+6h9GF7CSJzARe6xCofqViFGJAMzVeIMSeiMJ4QMA4kwLwmF4ywIdyZZ ZFsRojgLxsh5lL5913BUZLV8Uk1+D2gwDTjHgz6+AZ0LmwwMCLFgXEd5GjltA3TIuuRc HLIekybeYhIH5hrw2YAoobdK/4LSyDBAcGxXGD75OTPF9uXvLmdvqALNYmBnIXNz65Gf jXLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=XXhqxQAEGPR58LP8WJfDHExCqYtPmUCfbz0HcHsv7JE=; b=uBBlRH+B/ZbM4eT62tBMXeqgH5nDdjzC9Oj1PUghcfVUON2be0oObD8DlCP0XpKMFy /mXHQbkILiN+qcAFM6T0sSrM+RkEie/cM89JlmsxZRVkrHFEEZGJwlBPRAYEFUCicnWH uXWVQC99GuNWDD2yZGaIkC5l7tp/1KRjkWaStqirkD4Wcs1rt44LNxn3lin+C+KbrNGf v6Z7LyhrimDUiBLEFFbIFGRGA1w8TPbyy7WJU3HWuNYidzlEWg6EdEkm34Pvnveu5HSG 80Pbe2TbQkNemxUUjkbxOk9Fq4ryhC/bCDlAzhWgXtkHgPMNlH8BffA7luTmUdy06REE Vnlw== X-Gm-Message-State: AIVw112hx45Zau4AuoXaeNtLn6ZaIgqmOEdINTAAJu8R628y/BugbZG8 /moTTWFhFxwP06Tt X-Received: by 10.80.165.164 with SMTP id a33mr8310595edc.53.1500066751899; Fri, 14 Jul 2017 14:12:31 -0700 (PDT) Received: from localhost.localdomain ([37.228.147.16]) by smtp.gmail.com with ESMTPSA id c11sm4892223eda.0.2017.07.14.14.12.30 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 14 Jul 2017 14:12:30 -0700 (PDT) From: Jan Blunck To: dev@dpdk.org Date: Fri, 14 Jul 2017 17:12:01 -0400 Message-Id: <20170714211213.34436-4-jblunck@infradead.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170714211213.34436-1-jblunck@infradead.org> References: <20170711232512.54641-1-jblunck@infradead.org> <20170714211213.34436-1-jblunck@infradead.org> Subject: [dpdk-dev] [PATCH v2 03/15] devargs: extend unittest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This is extending the existing unittest to also cover corner cases of rte_eal_devargs_parse(). Signed-off-by: Jan Blunck --- test/test/test_devargs.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/test/test/test_devargs.c b/test/test/test_devargs.c index 02fec8b1f..178c3b243 100644 --- a/test/test/test_devargs.c +++ b/test/test/test_devargs.c @@ -58,6 +58,7 @@ test_devargs(void) { struct rte_devargs_list save_devargs_list; struct rte_devargs *devargs; + struct rte_devargs devargs_stack; /* save the real devargs_list, it is restored at the end of the test */ save_devargs_list = devargs_list; @@ -121,6 +122,25 @@ test_devargs(void) if (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, "000f:0:0") == 0) goto fail; + if (rte_eal_devargs_parse("", &devargs_stack) == 0) { + printf("Error in rte_eal_devargs_parse()\n"); + goto fail; + } + + if (rte_eal_devargs_parse("08:00.1,foo=bar", &devargs_stack) != 0) { + printf("Error in rte_eal_devargs_parse(08:00.1,foo=bar)\n"); + goto fail; + } + devargs = TAILQ_FIRST(&devargs_list); + if (devargs != NULL) + goto fail; + devargs = &devargs_stack; + if (strcmp(devargs->name, "08:00.1") != 0) + goto fail; + if (!devargs->args || strcmp(devargs->args, "foo=bar") != 0) + goto fail; + + free_devargs_list(); devargs_list = save_devargs_list; return 0;