From patchwork Sun Jul 9 09:28:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Blunck X-Patchwork-Id: 26686 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C6B305699; Sun, 9 Jul 2017 11:29:15 +0200 (CEST) Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 583B637AF for ; Sun, 9 Jul 2017 11:29:12 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id 77so17828043wrb.3 for ; Sun, 09 Jul 2017 02:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=MA0SVnlJErAy7ZGLJkXJfrGO56QTn4t4OMNDHe5vZm4=; b=T0phl2vNNNQVxwXNjCDfaUtjpbmJvY9wym17e3wzj/RHeTL4rJAM7ftW7mWM4Kjy+J ZpDU00tQ5fypYScVzNQmkUdi/84RPcyLM5bnojOBLPq2dlmgcmfmFXm21MrUU9P+qPYd Y6kGcjLNBtQPBkcYvBrrUGJlWPLMBjajAL879pN9QeU5dY+H9atIHdoEgM08G50WDs31 hjtLg5w6bLwKDoctYxQy++pybOv2fae7av8gBZfFDLz0hprjGy22ToJWPF8s7ob1GuYq vTZ340DoIj1vXDKXoOYiwhm35RKR8fvkr6Vf4KktZBhE/QPsDrcBLcUtBvMH720Yi/Ig HV1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=MA0SVnlJErAy7ZGLJkXJfrGO56QTn4t4OMNDHe5vZm4=; b=e1NX8rsYU+B0z4Ham4RmtJcYmgNMODdr29r3h+1klBhy4cBySl+FD0//HyXLpHoA3b TaKqMjSJuInEdXXnEa7wsw4YheALPy+qTHaMo99gQuHHlH2VolgJaSDk0XswbRoGwsc1 DkHbGZZAJlJIQiTdwUfMu2ue4mKcABO/0AUiKsoK3tYfeKD7q2MRtMrB+s61wKaatp7q TJLYL+71wZY4Rx+j7f7KdYSaYhoAGYIkobmBGntTOSIsDjkfHmdAag5DuJ9GiA3bcx1M 0Enca7oKng1PaQQXHreY8aQ11Iga8ispd0tfkbfFakGyOifuh2StzO3KWQG4uQulFWIQ N54Q== X-Gm-Message-State: AIVw112dnraG/i59ZQsVS1Jbgs4eNPzoTIezw4iawZrLqjhl9ov6YLdz drmBDzrc4F1IxXjt X-Received: by 10.80.177.29 with SMTP id k29mr7949127edd.83.1499592551926; Sun, 09 Jul 2017 02:29:11 -0700 (PDT) Received: from localhost.localdomain ([37.228.147.16]) by smtp.gmail.com with ESMTPSA id o15sm4817357edo.68.2017.07.09.02.29.10 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 09 Jul 2017 02:29:10 -0700 (PDT) From: Jan Blunck To: dev@dpdk.org Date: Sun, 9 Jul 2017 05:28:46 -0400 Message-Id: <20170709092847.13339-2-jblunck@infradead.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170709092847.13339-1-jblunck@infradead.org> References: <20170709092847.13339-1-jblunck@infradead.org> Subject: [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This is going to get cleaned up in future releases so lets not expose this API unnecessarily. Signed-off-by: Jan Blunck --- doc/guides/rel_notes/deprecation.rst | 2 +- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 - lib/librte_eal/common/eal_common_devargs.c | 2 +- lib/librte_eal/common/include/rte_devargs.h | 20 -------------------- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 - 5 files changed, 2 insertions(+), 24 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 257dcba32..33e8b93db 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -63,4 +63,4 @@ Deprecation Notices * eal: the following function is deprecated starting from 17.08 and will be removed in 17.11: - - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_parse`` + - ``rte_eal_parse_devargs_str`` diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map index 381f895cd..0295ea948 100644 --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map @@ -206,7 +206,6 @@ DPDK_17.08 { EXPERIMENTAL { global: - rte_eal_devargs_parse; rte_eal_hotplug_add; rte_eal_hotplug_remove; diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 49d43a328..40b6ced82 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -83,7 +83,7 @@ bus_name_cmp(const struct rte_bus *bus, const void *name) return strncmp(bus->name, name, strlen(bus->name)); } -int +static int rte_eal_devargs_parse(const char *dev, struct rte_devargs *da) { struct rte_bus *bus = NULL; diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h index a0427cd8a..a5c4a4ae5 100644 --- a/lib/librte_eal/common/include/rte_devargs.h +++ b/lib/librte_eal/common/include/rte_devargs.h @@ -119,26 +119,6 @@ int rte_eal_parse_devargs_str(const char *devargs_str, char **drvname, char **drvargs); /** - * Parse a device string. - * - * Verify that a bus is capable of handling the device passed - * in argument. Store which bus will handle the device, its name - * and the eventual device parameters. - * - * @param dev - * The device declaration string. - * @param da - * The devargs structure holding the device information. - * - * @return - * - 0 on success. - * - Negative errno on error. - */ -int -rte_eal_devargs_parse(const char *dev, - struct rte_devargs *da); - -/** * Add a device to the user device list * * For PCI devices, the format of arguments string is "PCI_ADDR" or diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map index 0f9e009b6..a118fb160 100644 --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map @@ -211,7 +211,6 @@ DPDK_17.08 { EXPERIMENTAL { global: - rte_eal_devargs_parse; rte_eal_hotplug_add; rte_eal_hotplug_remove;