diff mbox

[dpdk-dev,5/5] doc: update documentation for dpaa2_sec supported algos

Message ID 20170629204904.23684-6-akhil.goyal@nxp.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Akhil Goyal June 29, 2017, 8:49 p.m. UTC 
  From: Akhil Goyal <akhil.goyal@nxp.com>

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/cryptodevs/dpaa2_sec.rst          | 9 ++++++++-
 doc/guides/cryptodevs/features/dpaa2_sec.ini | 6 ++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo June 29, 2017, 9:07 p.m. UTC | #1 
Hi Akhil

> -----Original Message-----
> From: akhil.goyal@nxp.com [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, June 29, 2017 9:49 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH 5/5] doc: update documentation for dpaa2_sec supported
> algos
> 
> From: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

Patch number 3 adds these algorithms, so I believe that's the right place to include
this documentation change.

Also, you should add an entry in release notes.

Lastly, I spotted a typo below: openssl -> dpaa2_sec

...
> 
>  ;
> @@ -32,3 +35,6 @@ SHA512 HMAC  = Y
>  ; Supported AEAD algorithms of the 'openssl' crypto driver.
Akhil Goyal June 29, 2017, 9:54 p.m. UTC | #2 
Hi Pablo,

On 6/30/2017 2:37 AM, De Lara Guarch, Pablo wrote:
> Hi Akhil
>
>> -----Original Message-----
>> From: akhil.goyal@nxp.com [mailto:akhil.goyal@nxp.com]
>> Sent: Thursday, June 29, 2017 9:49 PM
>> To: dev@dpdk.org
>> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
>> <declan.doherty@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
>> Subject: [PATCH 5/5] doc: update documentation for dpaa2_sec supported
>> algos
>>
>> From: Akhil Goyal <akhil.goyal@nxp.com>
>>
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Patch number 3 adds these algorithms, so I believe that's the right place to include
> this documentation change.
>
> Also, you should add an entry in release notes.
>
> Lastly, I spotted a typo below: openssl -> dpaa2_sec
>
> ...
>>
>>  ;
>> @@ -32,3 +35,6 @@ SHA512 HMAC  = Y
>>  ; Supported AEAD algorithms of the 'openssl' crypto driver.
>
>
Thanks for a quick review.
I will update the patch set and send again.

Also, I could see my 2nd patch is missing. All my patches are at same 
location but somehow the patch is not received. Even the git-send-email 
is showing that all the patches are successfully accepted for delivery.
I will send patch set again as soon as this problem is resolved.

Regards,
Akhil
diff mbox

Patch

diff --git a/doc/guides/cryptodevs/dpaa2_sec.rst b/doc/guides/cryptodevs/dpaa2_sec.rst
index becb910..1444a91 100644
--- a/doc/guides/cryptodevs/dpaa2_sec.rst
+++ b/doc/guides/cryptodevs/dpaa2_sec.rst
@@ -126,7 +126,7 @@  fits in the DPAA2 Bus model
 Features
 --------
 
-The DPAA2 PMD has support for:
+The DPAA2_SEC PMD has support for:
 
 Cipher algorithms:
 
@@ -134,6 +134,9 @@  Cipher algorithms:
 * ``RTE_CRYPTO_CIPHER_AES128_CBC``
 * ``RTE_CRYPTO_CIPHER_AES192_CBC``
 * ``RTE_CRYPTO_CIPHER_AES256_CBC``
+* ``RTE_CRYPTO_CIPHER_AES128_CTR``
+* ``RTE_CRYPTO_CIPHER_AES192_CTR``
+* ``RTE_CRYPTO_CIPHER_AES256_CTR``
 
 Hash algorithms:
 
@@ -144,6 +147,10 @@  Hash algorithms:
 * ``RTE_CRYPTO_AUTH_SHA512_HMAC``
 * ``RTE_CRYPTO_AUTH_MD5_HMAC``
 
+AEAD algorithms:
+
+* ``RTE_CRYPTO_AEAD_AES_GCM``
+
 Supported DPAA2 SoCs
 --------------------
 
diff --git a/doc/guides/cryptodevs/features/dpaa2_sec.ini b/doc/guides/cryptodevs/features/dpaa2_sec.ini
index db0ea4f..9eb07aa 100644
--- a/doc/guides/cryptodevs/features/dpaa2_sec.ini
+++ b/doc/guides/cryptodevs/features/dpaa2_sec.ini
@@ -15,6 +15,9 @@  HW Accelerated         = Y
 AES CBC (128) = Y
 AES CBC (192) = Y
 AES CBC (256) = Y
+AES CTR (128) = Y
+AES CTR (192) = Y
+AES CTR (256) = Y
 3DES CBC      = Y
 
 ;
@@ -32,3 +35,6 @@  SHA512 HMAC  = Y
 ; Supported AEAD algorithms of the 'openssl' crypto driver.
 ;
 [AEAD]
+AES GCM (128) = Y
+AES GCM (192) = Y
+AES GCM (256) = Y