diff mbox

[dpdk-dev] vhost: fix MTU device feature check

Message ID 20170629075810.4225-1-maxime.coquelin@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Yuanhan Liu
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Maxime Coquelin June 29, 2017, 7:58 a.m. UTC 
  The MTU feature support check has to be done against MTU
feature bit mask, and not bit position.

Cc: stable@dpdk.org
Fixes: 72e8543093df ("vhost: add API to get MTU value")

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---

This is a follow-up of Ivan's patch, which made me check I didn't
introduced same bug elsewhere.

 lib/librte_vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jianfeng Tan June 29, 2017, 8:01 a.m. UTC | #1 
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Thursday, June 29, 2017 3:58 PM
> To: dev@dpdk.org; yliu@fridaylinux.org
> Cc: i.dyukov@samsung.com; Tan, Jianfeng; stable@dpdk.org; Maxime
> Coquelin
> Subject: [PATCH] vhost: fix MTU device feature check
> 
> The MTU feature support check has to be done against MTU
> feature bit mask, and not bit position.
> 
> Cc: stable@dpdk.org
> Fixes: 72e8543093df ("vhost: add API to get MTU value")
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>
Yuanhan Liu July 1, 2017, 11:36 p.m. UTC | #2 
On Thu, Jun 29, 2017 at 08:01:45AM +0000, Tan, Jianfeng wrote:
> 
> 
> > -----Original Message-----
> > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > Sent: Thursday, June 29, 2017 3:58 PM
> > To: dev@dpdk.org; yliu@fridaylinux.org
> > Cc: i.dyukov@samsung.com; Tan, Jianfeng; stable@dpdk.org; Maxime
> > Coquelin
> > Subject: [PATCH] vhost: fix MTU device feature check
> > 
> > The MTU feature support check has to be done against MTU
> > feature bit mask, and not bit position.
> > 
> > Cc: stable@dpdk.org
> > Fixes: 72e8543093df ("vhost: add API to get MTU value")
> > 
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu
diff mbox

Patch

diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
index 19c5a43..653152f 100644
--- a/lib/librte_vhost/vhost.c
+++ b/lib/librte_vhost/vhost.c
@@ -272,7 +272,7 @@  rte_vhost_get_mtu(int vid, uint16_t *mtu)
 	if (!(dev->flags & VIRTIO_DEV_READY))
 		return -EAGAIN;
 
-	if (!(dev->features & VIRTIO_NET_F_MTU))
+	if (!(dev->features & (1ULL << VIRTIO_NET_F_MTU)))
 		return -ENOTSUP;
 
 	*mtu = dev->mtu;