diff mbox

[dpdk-dev] net/ixgbe: fix duplicated check

Message ID 20170411152034.23784-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit April 11, 2017, 3:20 p.m. UTC 
  Same check duplicated, updated check according what commend states.

Coverity issue: 1407507
Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/ixgbe/ixgbe_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit April 13, 2017, 9:48 a.m. UTC | #1 
On 4/11/2017 4:20 PM, Ferruh Yigit wrote:
> Same check duplicated, updated check according what commend states.
> 
> Coverity issue: 1407507
> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Superseded by http://dpdk.org/dev/patchwork/patch/23606/
Zhao1, Wei April 14, 2017, 3:52 a.m. UTC | #2 
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, April 11, 2017 11:21 PM
> To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/ixgbe: fix duplicated check
> 
> Same check duplicated, updated check according what commend states.
> 
> Coverity issue: 1407507
> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index e2ba9c2..803d6f8 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> rte_flow_attr *attr,
>  	index++;
>  	NEXT_ITEM_OF_PATTERN(item, pattern, index);
>  	if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) &&
> -		(item->type != RTE_FLOW_ITEM_TYPE_VLAN)) {
> +		(item->type != RTE_FLOW_ITEM_TYPE_IPV4)) {
>  		memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
>  		rte_flow_error_set(error, EINVAL,
>  			RTE_FLOW_ERROR_TYPE_ITEM,
> --
> 2.9.3

Acked-by Wei Zhao<wei.zhao1 @intel.com>
Ferruh Yigit April 14, 2017, 9:04 a.m. UTC | #3 
On 4/14/2017 4:52 AM, Zhao1, Wei wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Tuesday, April 11, 2017 11:21 PM
>> To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [PATCH] net/ixgbe: fix duplicated check
>>
>> Same check duplicated, updated check according what commend states.
>>
>> Coverity issue: 1407507
>> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  drivers/net/ixgbe/ixgbe_flow.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>> index e2ba9c2..803d6f8 100644
>> --- a/drivers/net/ixgbe/ixgbe_flow.c
>> +++ b/drivers/net/ixgbe/ixgbe_flow.c
>> @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct
>> rte_flow_attr *attr,
>>  	index++;
>>  	NEXT_ITEM_OF_PATTERN(item, pattern, index);
>>  	if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) &&
>> -		(item->type != RTE_FLOW_ITEM_TYPE_VLAN)) {
>> +		(item->type != RTE_FLOW_ITEM_TYPE_IPV4)) {
>>  		memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
>>  		rte_flow_error_set(error, EINVAL,
>>  			RTE_FLOW_ERROR_TYPE_ITEM,
>> --
>> 2.9.3
> 
> Acked-by Wei Zhao<wei.zhao1 @intel.com>

OK.
So, will continue with this patch, your version [1] marked as rejected.

[1]
http://dpdk.org/dev/patchwork/patch/23606/
Zhao1, Wei April 14, 2017, 9:06 a.m. UTC | #4 
Ok.

> -----Original Message-----

> From: Yigit, Ferruh

> Sent: Friday, April 14, 2017 5:04 PM

> To: Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Helin

> <helin.zhang@intel.com>; Ananyev, Konstantin

> <konstantin.ananyev@intel.com>

> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>

> Subject: Re: [PATCH] net/ixgbe: fix duplicated check

> 

> On 4/14/2017 4:52 AM, Zhao1, Wei wrote:

> >

> >

> >> -----Original Message-----

> >> From: Yigit, Ferruh

> >> Sent: Tuesday, April 11, 2017 11:21 PM

> >> To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin

> >> <konstantin.ananyev@intel.com>

> >> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo

> >> <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>

> >> Subject: [PATCH] net/ixgbe: fix duplicated check

> >>

> >> Same check duplicated, updated check according what commend states.

> >>

> >> Coverity issue: 1407507

> >> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")

> >>

> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

> >> ---

> >>  drivers/net/ixgbe/ixgbe_flow.c | 2 +-

> >>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>

> >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c

> >> b/drivers/net/ixgbe/ixgbe_flow.c index e2ba9c2..803d6f8 100644

> >> --- a/drivers/net/ixgbe/ixgbe_flow.c

> >> +++ b/drivers/net/ixgbe/ixgbe_flow.c

> >> @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct

> >> rte_flow_attr *attr,

> >>  	index++;

> >>  	NEXT_ITEM_OF_PATTERN(item, pattern, index);

> >>  	if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) &&

> >> -		(item->type != RTE_FLOW_ITEM_TYPE_VLAN)) {

> >> +		(item->type != RTE_FLOW_ITEM_TYPE_IPV4)) {

> >>  		memset(rule, 0, sizeof(struct ixgbe_fdir_rule));

> >>  		rte_flow_error_set(error, EINVAL,

> >>  			RTE_FLOW_ERROR_TYPE_ITEM,

> >> --

> >> 2.9.3

> >

> > Acked-by Wei Zhao<wei.zhao1 @intel.com>

> 

> OK.

> So, will continue with this patch, your version [1] marked as rejected.

> 

> [1]

> http://dpdk.org/dev/patchwork/patch/23606/
Ferruh Yigit April 14, 2017, 9:08 a.m. UTC | #5 
On 4/14/2017 4:52 AM, Zhao1, Wei wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Tuesday, April 11, 2017 11:21 PM
>> To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [PATCH] net/ixgbe: fix duplicated check
>>
>> Same check duplicated, updated check according what commend states.
>>
>> Coverity issue: 1407507
>> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

<...>

> Acked-by Wei Zhao<wei.zhao1 @intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index e2ba9c2..803d6f8 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2231,7 +2231,7 @@  ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,
 	index++;
 	NEXT_ITEM_OF_PATTERN(item, pattern, index);
 	if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) &&
-		(item->type != RTE_FLOW_ITEM_TYPE_VLAN)) {
+		(item->type != RTE_FLOW_ITEM_TYPE_IPV4)) {
 		memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
 		rte_flow_error_set(error, EINVAL,
 			RTE_FLOW_ERROR_TYPE_ITEM,