From patchwork Tue Apr 11 14:33:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 23505 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 402BF69C6; Tue, 11 Apr 2017 16:33:21 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 18D7A69C5 for ; Tue, 11 Apr 2017 16:33:18 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2017 07:33:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.37,185,1488873600"; d="scan'208"; a="1118195161" Received: from sivswdev02.ir.intel.com ([10.237.217.46]) by orsmga001.jf.intel.com with ESMTP; 11 Apr 2017 07:33:16 -0700 From: Ferruh Yigit To: Ferruh Yigit Cc: dev@dpdk.org Date: Tue, 11 Apr 2017 15:33:11 +0100 Message-Id: <20170411143311.12172-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.8.4 Subject: [dpdk-dev] [PATCH] net/kni: remove unnecessary null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue: 1419721 Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Signed-off-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index 59205e7..ed4478e 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -489,12 +489,10 @@ eth_kni_remove(const char *name) eth_kni_dev_stop(eth_dev); - if (eth_dev->data) { - internals = eth_dev->data->dev_private; - rte_kni_release(internals->kni); + internals = eth_dev->data->dev_private; + rte_kni_release(internals->kni); - rte_free(internals); - } + rte_free(internals); rte_free(eth_dev->data); rte_eth_dev_release_port(eth_dev);