diff mbox

[dpdk-dev] doc: pvp: fix typo in host's testpmd command line

Message ID 20170407150614.9963-1-maxime.coquelin@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Maxime Coquelin April 7, 2017, 3:06 p.m. UTC 
  This patch adds missing backslash in host's testpmd command
line.

Without it the command works, but a single core is used
instead of four, which might create confusion.

Fixes: 58a2551a160f ("doc: introduce PVP reference benchmark")

Cc: John McNamara <john.mcnamara@intel.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 doc/guides/howto/pvp_reference_benchmark.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John McNamara April 10, 2017, 7:54 a.m. UTC | #1 
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Friday, April 7, 2017 4:06 PM
> To: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Cc: jfreiman@redhat.com; Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] doc: pvp: fix typo in host's testpmd command line
> 
> This patch adds missing backslash in host's testpmd command line.
> 
> Without it the command works, but a single core is used instead of four,
> which might create confusion.
> 
> Fixes: 58a2551a160f ("doc: introduce PVP reference benchmark")
> 
> Cc: John McNamara <john.mcnamara@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon April 21, 2017, 12:46 a.m. UTC | #2 
10/04/2017 09:54, Mcnamara, John:
> > -----Original Message-----
> > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > Sent: Friday, April 7, 2017 4:06 PM
> > To: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> > Cc: jfreiman@redhat.com; Maxime Coquelin <maxime.coquelin@redhat.com>
> > Subject: [PATCH] doc: pvp: fix typo in host's testpmd command line
> > 
> > This patch adds missing backslash in host's testpmd command line.
> > 
> > Without it the command works, but a single core is used instead of four,
> > which might create confusion.
> > 
> > Fixes: 58a2551a160f ("doc: introduce PVP reference benchmark")
> > 
> > Cc: John McNamara <john.mcnamara@intel.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/doc/guides/howto/pvp_reference_benchmark.rst b/doc/guides/howto/pvp_reference_benchmark.rst
index 6d514ff..208e4c7 100644
--- a/doc/guides/howto/pvp_reference_benchmark.rst
+++ b/doc/guides/howto/pvp_reference_benchmark.rst
@@ -158,7 +158,7 @@  Testpmd launch
       $RTE_SDK/install/bin/testpmd -l 0,2,3,4,5 --socket-mem=1024 -n 4 \
           --vdev 'net_vhost0,iface=/tmp/vhost-user1' \
           --vdev 'net_vhost1,iface=/tmp/vhost-user2' -- \
-          --portmask=f --disable-hw-vlan -i --rxq=1 --txq=1
+          --portmask=f --disable-hw-vlan -i --rxq=1 --txq=1 \
           --nb-cores=4 --forward-mode=io
 
    With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.