From patchwork Fri Mar 31 18:31:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 23046 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 09EF1108D; Fri, 31 Mar 2017 20:31:27 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7FC083B5 for ; Fri, 31 Mar 2017 20:31:25 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84EB9C04B927 for ; Fri, 31 Mar 2017 18:31:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 84EB9C04B927 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=aconole@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 84EB9C04B927 Received: from dhcp-25-97.bos.redhat.com (ovpn-123-88.rdu2.redhat.com [10.10.123.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3120A62926 for ; Fri, 31 Mar 2017 18:31:24 +0000 (UTC) From: Aaron Conole To: dev@dpdk.org Date: Fri, 31 Mar 2017 14:31:22 -0400 Message-Id: <20170331183122.22961-1-aconole@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 31 Mar 2017 18:31:24 +0000 (UTC) Subject: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It's likely that this function isn't used anywhere, but since it was part of the public API, mark the function for deprecation for at least one release. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++++++ lib/librte_eal/common/arch/x86/rte_cpuflags.c | 1 + lib/librte_eal/common/arch/x86/rte_spinlock.c | 1 + lib/librte_eal/common/include/generic/rte_cpuflags.h | 3 ++- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++++++ 5 files changed, 18 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map index 67f2ffb..82f0f9f 100644 --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map @@ -182,3 +182,10 @@ DPDK_17.02 { rte_bus_unregister; } DPDK_16.11; + +DPDK_17.05 { + global; + + rte_cpu_is_supported; + +} DPDK_17.02; diff --git a/lib/librte_eal/common/arch/x86/rte_cpuflags.c b/lib/librte_eal/common/arch/x86/rte_cpuflags.c index 0138257..04f0852 100644 --- a/lib/librte_eal/common/arch/x86/rte_cpuflags.c +++ b/lib/librte_eal/common/arch/x86/rte_cpuflags.c @@ -31,6 +31,7 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include "rte_common.h" #include "rte_cpuflags.h" #include diff --git a/lib/librte_eal/common/arch/x86/rte_spinlock.c b/lib/librte_eal/common/arch/x86/rte_spinlock.c index c383e9f..f1b1a4e 100644 --- a/lib/librte_eal/common/arch/x86/rte_spinlock.c +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c @@ -33,6 +33,7 @@ #include +#include "rte_common.h" #include "rte_cpuflags.h" uint8_t rte_rtm_supported; /* cache the flag to avoid the overhead diff --git a/lib/librte_eal/common/include/generic/rte_cpuflags.h b/lib/librte_eal/common/include/generic/rte_cpuflags.h index f01624d..df66939 100644 --- a/lib/librte_eal/common/include/generic/rte_cpuflags.h +++ b/lib/librte_eal/common/include/generic/rte_cpuflags.h @@ -78,9 +78,10 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature); * This function checks that the currently used CPU supports the CPU features * that were specified at compile time. It is called automatically within the * EAL, so does not need to be used by applications. + * This version is replaced by rte_cpu_is_supported */ void -rte_cpu_check_supported(void); +rte_cpu_check_supported(void) __rte_deprecated; /** * This function checks that the currently used CPU supports the CPU features diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map index 9c134b4..461f15d 100644 --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map @@ -186,3 +186,10 @@ DPDK_17.02 { rte_bus_unregister; } DPDK_16.11; + +DPDK_17.05 { + global; + + rte_cpu_is_supported; + +} DPDK_17.02;