[dpdk-dev,v3,7/7] net/tap: move closing fds to pmd close from pmd stop
Checks
Commit Message
At the same time remove closing fds code from pmd stop routine.
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
drivers/net/tap/rte_eth_tap.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
Comments
On Mon, 6 Feb 2017 13:40:38 -0600
Keith Wiles <keith.wiles@intel.com> wrote:
> At the same time remove closing fds code from pmd stop routine.
>
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 966e91a..0a7f4af 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -350,14 +350,7 @@ tap_dev_start(struct rte_eth_dev *dev)
> static void
> tap_dev_stop(struct rte_eth_dev *dev)
> {
> - int i;
> - struct pmd_internals *internals = dev->data->dev_private;
> -
> tap_link_set_down(dev);
> -
> - for (i = 0; i < internals->nb_queues; i++)
> - if (internals->rxq[i].fd != -1)
> - close(internals->rxq[i].fd);
> }
>
> static int
> @@ -431,6 +424,17 @@ tap_stats_reset(struct rte_eth_dev *dev)
> static void
> tap_dev_close(struct rte_eth_dev *dev __rte_unused)
> {
> + int i;
> + struct pmd_internals *internals = dev->data->dev_private;
> +
> + tap_link_set_down(dev);
> +
> + for (i = 0; i < internals->nb_queues; i++) {
> + if (internals->rxq[i].fd != -1)
> + close(internals->rxq[i].fd);
> + internals->rxq[i].fd = -1;
> + internals->txq[i].fd = -1;
> + }
> }
>
> static void
Ok, the series looks good to me.
Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
On 2/7/2017 8:51 AM, Pascal Mazon wrote:
<...>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
<...>
> Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
Series applied to dpdk-next-net/master, thanks.
(
patch 1/7: docs: fix tap PMD docs for device name
patch 4/7: Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
patch 5/7: checkpatch warning fixed
patch 6/7: Fixes: 082fdb7361d7 ("net/tap: implement link up and down
callbacks")
)
@@ -350,14 +350,7 @@ tap_dev_start(struct rte_eth_dev *dev)
static void
tap_dev_stop(struct rte_eth_dev *dev)
{
- int i;
- struct pmd_internals *internals = dev->data->dev_private;
-
tap_link_set_down(dev);
-
- for (i = 0; i < internals->nb_queues; i++)
- if (internals->rxq[i].fd != -1)
- close(internals->rxq[i].fd);
}
static int
@@ -431,6 +424,17 @@ tap_stats_reset(struct rte_eth_dev *dev)
static void
tap_dev_close(struct rte_eth_dev *dev __rte_unused)
{
+ int i;
+ struct pmd_internals *internals = dev->data->dev_private;
+
+ tap_link_set_down(dev);
+
+ for (i = 0; i < internals->nb_queues; i++) {
+ if (internals->rxq[i].fd != -1)
+ close(internals->rxq[i].fd);
+ internals->rxq[i].fd = -1;
+ internals->txq[i].fd = -1;
+ }
}
static void