diff mbox

[dpdk-dev] drivers/net: make PCI device id struct const

Message ID 20170126140744.21626-3-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Ferruh Yigit Jan. 26, 2017, 2:07 p.m. UTC 
  Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++--
 drivers/net/bnxt/bnxt_ethdev.c   | 2 +-
 drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
 drivers/net/ena/ena_ethdev.c     | 2 +-
 drivers/net/nfp/nfp_net.c        | 2 +-
 drivers/net/qede/qede_ethdev.c   | 4 ++--
 6 files changed, 8 insertions(+), 8 deletions(-)

Comments

Shreyansh Jain Jan. 27, 2017, 7:10 a.m. UTC | #1 
On Thursday 26 January 2017 07:37 PM, Ferruh Yigit wrote:
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++--
>  drivers/net/bnxt/bnxt_ethdev.c   | 2 +-
>  drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
>  drivers/net/ena/ena_ethdev.c     | 2 +-
>  drivers/net/nfp/nfp_net.c        | 2 +-
>  drivers/net/qede/qede_ethdev.c   | 4 ++--
>  6 files changed, 8 insertions(+), 8 deletions(-)
>
<snip>
Do you think making this change in test_pci.c also makes sense?
Either way:

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Ferruh Yigit Jan. 27, 2017, 9:37 a.m. UTC | #2 
On 1/27/2017 7:10 AM, Shreyansh Jain wrote:
> On Thursday 26 January 2017 07:37 PM, Ferruh Yigit wrote:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++--
>>  drivers/net/bnxt/bnxt_ethdev.c   | 2 +-
>>  drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
>>  drivers/net/ena/ena_ethdev.c     | 2 +-
>>  drivers/net/nfp/nfp_net.c        | 2 +-
>>  drivers/net/qede/qede_ethdev.c   | 4 ++--
>>  6 files changed, 8 insertions(+), 8 deletions(-)
>>
> <snip>
> Do you think making this change in test_pci.c also makes sense?

Yes it does, I will send a patch, thanks.

> Either way:
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>
Ferruh Yigit Jan. 27, 2017, 11:01 a.m. UTC | #3 
On 1/27/2017 7:10 AM, Shreyansh Jain wrote:
> On Thursday 26 January 2017 07:37 PM, Ferruh Yigit wrote:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++--
>>  drivers/net/bnxt/bnxt_ethdev.c   | 2 +-
>>  drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
>>  drivers/net/ena/ena_ethdev.c     | 2 +-
>>  drivers/net/nfp/nfp_net.c        | 2 +-
>>  drivers/net/qede/qede_ethdev.c   | 4 ++--
>>  6 files changed, 8 insertions(+), 8 deletions(-)
>>
> <snip>
> Do you think making this change in test_pci.c also makes sense?
> Either way:
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index d149468..a0b0dfa 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -17,7 +17,7 @@ 
  * The set of PCI devices this driver supports
  */
 #define BROADCOM_PCI_VENDOR_ID 0x14E4
-static struct rte_pci_id pci_id_bnx2x_map[] = {
+static const struct rte_pci_id pci_id_bnx2x_map[] = {
 	{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) },
 	{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) },
 	{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810) },
@@ -33,7 +33,7 @@  static struct rte_pci_id pci_id_bnx2x_map[] = {
 	{ .vendor_id = 0, }
 };
 
-static struct rte_pci_id pci_id_bnx2xvf_map[] = {
+static const struct rte_pci_id pci_id_bnx2xvf_map[] = {
 	{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800_VF) },
 	{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) },
 	{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) },
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 501c97d..d1b2518 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -92,7 +92,7 @@  static const char bnxt_version[] =
 #define BROADCOM_DEV_ID_57414_MF 0x16ec
 #define BROADCOM_DEV_ID_57416_MF 0x16ee
 
-static struct rte_pci_id bnxt_pci_id_map[] = {
+static const struct rte_pci_id bnxt_pci_id_map[] = {
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57302) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57304_PF) },
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
index 64345e3..4d543a7 100644
--- a/drivers/net/cxgbe/cxgbe_ethdev.c
+++ b/drivers/net/cxgbe/cxgbe_ethdev.c
@@ -68,7 +68,7 @@ 
  * Macros needed to support the PCI Device ID Table ...
  */
 #define CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN \
-	static struct rte_pci_id cxgb4_pci_tbl[] = {
+	static const struct rte_pci_id cxgb4_pci_tbl[] = {
 #define CH_PCI_DEVICE_ID_FUNCTION 0x4
 
 #define PCI_VENDOR_ID_CHELSIO 0x1425
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 88a4977..a580345 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -177,7 +177,7 @@  static const struct ena_stats ena_stats_ena_com_strings[] = {
 #define	ENA_TX_OFFLOAD_NOTSUP_MASK	\
 	(PKT_TX_OFFLOAD_MASK ^ ENA_TX_OFFLOAD_MASK)
 
-static struct rte_pci_id pci_id_ena_map[] = {
+static const struct rte_pci_id pci_id_ena_map[] = {
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_AMAZON, PCI_DEVICE_ID_ENA_VF) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_AMAZON, PCI_DEVICE_ID_ENA_LLQ_VF) },
 	{ .device_id = 0 },
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index ab2d331..1020d9e 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2583,7 +2583,7 @@  nfp_net_init(struct rte_eth_dev *eth_dev)
 	return 0;
 }
 
-static struct rte_pci_id pci_id_nfp_net_map[] = {
+static const struct rte_pci_id pci_id_nfp_net_map[] = {
 	{
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_NETRONOME,
 			       PCI_DEVICE_ID_NFP6000_PF_NIC)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 5e8e97e..0494dbd 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2288,7 +2288,7 @@  static int qedevf_eth_dev_uninit(struct rte_eth_dev *eth_dev)
 	return qede_dev_common_uninit(eth_dev);
 }
 
-static struct rte_pci_id pci_id_qedevf_map[] = {
+static const struct rte_pci_id pci_id_qedevf_map[] = {
 #define QEDEVF_RTE_PCI_DEVICE(dev) RTE_PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, dev)
 	{
 		QEDEVF_RTE_PCI_DEVICE(PCI_DEVICE_ID_QLOGIC_NX2_VF)
@@ -2302,7 +2302,7 @@  static struct rte_pci_id pci_id_qedevf_map[] = {
 	{.vendor_id = 0,}
 };
 
-static struct rte_pci_id pci_id_qede_map[] = {
+static const struct rte_pci_id pci_id_qede_map[] = {
 #define QEDE_RTE_PCI_DEVICE(dev) RTE_PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, dev)
 	{
 		QEDE_RTE_PCI_DEVICE(PCI_DEVICE_ID_QLOGIC_NX2_57980E)