From patchwork Mon Nov 7 15:11:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 16970 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E8515558B; Mon, 7 Nov 2016 16:12:00 +0100 (CET) Received: from relay.smtp.broadcom.com (unknown [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 1E853558A for ; Mon, 7 Nov 2016 16:11:59 +0100 (CET) Received: from mail-irv-17.broadcom.com (mail-irv-17.broadcom.com [10.15.198.34]) by relay.smtp.broadcom.com (Postfix) with ESMTP id E44A62802B5; Mon, 7 Nov 2016 07:11:57 -0800 (PST) Received: from C02PT1RBG8WP.wifi.aus.avagotech.net (c02pt1rbg8wp.wifi.aus.avagotech.net [10.10.168.137]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id E50A881F52; Mon, 7 Nov 2016 07:11:56 -0800 (PST) Date: Mon, 7 Nov 2016 09:11:55 -0600 From: Ajit Khaparde To: dev@dpdk.org Cc: Ferruh Yigit Message-ID: <20161107151155.GA24815@C02PT1RBG8WP.wifi.aus.avagotech.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Subject: [dpdk-dev] [PATCH 2/3] bnxt: add a FALLTHROUGH comment in the cascading switch statement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The cascading switch statement in bnxt_hwrm.c is missing the FALLTHROUGH comment. Adding that. Coverity: 127552 Signed-off-by: Ajit Khaparde Acked-by: Ferruh Yigit --- drivers/net/bnxt/bnxt_hwrm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index cf79fc6..07e7124 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -606,6 +606,7 @@ int bnxt_hwrm_ring_alloc(struct bnxt *bp, switch (ring_type) { case HWRM_RING_ALLOC_INPUT_RING_TYPE_TX: req.queue_id = bp->cos_queue[0].id; + /* FALLTHROUGH */ case HWRM_RING_ALLOC_INPUT_RING_TYPE_RX: req.ring_type = ring_type; req.cmpl_ring_id =