From patchwork Thu Nov 3 18:58:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 16922 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 366B02BA3; Thu, 3 Nov 2016 19:59:00 +0100 (CET) Received: from mail-gw3-out.broadcom.com (mail-gw3-out.broadcom.com [216.31.210.64]) by dpdk.org (Postfix) with ESMTP id 1BEFF2B8C for ; Thu, 3 Nov 2016 19:58:43 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.31,587,1473145200"; d="scan'208";a="109234214" Received: from smtphost.broadcom.com (HELO mail-irv-17.broadcom.com) ([10.15.198.34]) by mail-gw3-out.broadcom.com with ESMTP; 03 Nov 2016 12:38:46 -0700 Received: from C02PT1RBG8WP.wifi.aus.avagotech.net (c02pt1rbg8wp.wifi.aus.avagotech.net [10.10.168.137]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id C9E8882028 for ; Thu, 3 Nov 2016 11:58:42 -0700 (PDT) Date: Thu, 3 Nov 2016 13:58:42 -0500 From: Ajit Khaparde To: dev@dpdk.org Message-ID: <20161103185842.GA88409@C02PT1RBG8WP.wifi.aus.avagotech.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Subject: [dpdk-dev] [PATCH 2/2] bnxt: add a FALLTHROUGH comment in the cascading switch statement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The cascading switch statement in bnxt_hwrm.c is missing the FALLTHROUGH comment. Adding that. Coverity: 127552 Signed-off-by: Ajit Khaparde Acked-by: Ferruh Yigit --- drivers/net/bnxt/bnxt_hwrm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index cf79fc6..07e7124 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -606,6 +606,7 @@ int bnxt_hwrm_ring_alloc(struct bnxt *bp, switch (ring_type) { case HWRM_RING_ALLOC_INPUT_RING_TYPE_TX: req.queue_id = bp->cos_queue[0].id; + /* FALLTHROUGH */ case HWRM_RING_ALLOC_INPUT_RING_TYPE_RX: req.ring_type = ring_type; req.cmpl_ring_id =