From patchwork Thu Sep 29 20:56:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 16258 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id F03AC568A; Thu, 29 Sep 2016 22:57:01 +0200 (CEST) Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 3AE5529CD for ; Thu, 29 Sep 2016 22:56:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=752; q=dns/txt; s=iport; t=1475182619; x=1476392219; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=/9zCJqszcrEcpMfn7Q0Pm+CsNS/39OpM82eNazg9g0w=; b=isGVwDWXI6fQ8HwwPQTcFDXWbYu5WDic3DZGtOCLNLeQVACMzZviazWs vAOmrqJWoLZ4IXDJRtmUvjLSc+x7RsOQISOVNzs54nyDVGuUIT/KhkHs7 LCSAhitl3h5PZ9QXXoiFEJ3BBu6MhbtOCFnbqv1CRePTnBNCHeG8lrM1m A=; X-IronPort-AV: E=Sophos;i="5.31,417,1473120000"; d="scan'208";a="329024593" Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2016 20:56:58 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by rcdn-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id u8TKuwmq027418; Thu, 29 Sep 2016 20:56:58 GMT Received: by cisco.com (Postfix, from userid 392789) id 2E1F43FAAE0D; Thu, 29 Sep 2016 13:56:58 -0700 (PDT) From: John Daley To: bruce.richardson@intel.com Cc: dev@dpdk.org, John Daley Date: Thu, 29 Sep 2016 13:56:37 -0700 Message-Id: <20160929205639.1175-2-johndale@cisco.com> X-Mailer: git-send-email 2.10.0 In-Reply-To: <20160929205639.1175-1-johndale@cisco.com> References: <20160929205639.1175-1-johndale@cisco.com> Subject: [dpdk-dev] [PATCH 2/4] net/enic: fix segfault when restarting with fdir filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When flow director filters where removed when an enic device is stopped, the filters were freed but the pointer was not set to NULL so the next stop would try to free them again. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: John Daley --- drivers/net/enic/enic_clsf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c index b251b7f..111b194 100644 --- a/drivers/net/enic/enic_clsf.c +++ b/drivers/net/enic/enic_clsf.c @@ -240,6 +240,7 @@ void enic_clsf_destroy(struct enic *enic) vnic_dev_classifier(enic->vdev, CLSF_DEL, &key->fltr_id, NULL); rte_free(key); + enic->fdir.nodes[index] = NULL; } }