Message ID | 20150520142427.4b977210@miho (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 40098C320; Wed, 20 May 2015 14:24:36 +0200 (CEST) Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21]) by dpdk.org (Postfix) with SMTP id 205CA5A9B for <dev@dpdk.org>; Wed, 20 May 2015 14:24:35 +0200 (CEST) Received: from miho (unverified [10.100.1.152]) by ernst.netinsight.se (EMWAC SMTPRS 0.83) with SMTP id <B0029951500@ernst.netinsight.se>; Wed, 20 May 2015 14:24:27 +0200 Date: Wed, 20 May 2015 14:24:27 +0200 From: Simon Kagstrom <simon.kagstrom@netinsight.net> To: dev@dpdk.org Message-ID: <20150520142427.4b977210@miho> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Simon Kagstrom
May 20, 2015, 12:24 p.m. UTC
Needed to run as non-root but with higher memory allocations. Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net> Signed-off-by: Johan Faltstrom <johan.faltstrom@netinsight.net> --- lib/librte_eal/common/eal_common_options.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Simon Kagstrom > Sent: Wednesday, May 20, 2015 1:24 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and -- > no-huge > > Needed to run as non-root but with higher memory allocations. > > Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net> > Signed-off-by: Johan Faltstrom <johan.faltstrom@netinsight.net> > --- > lib/librte_eal/common/eal_common_options.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > index 8fcb1ab..89b867d 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -851,8 +851,8 @@ eal_check_common_options(struct internal_config > *internal_cfg) > return -1; > } > if (internal_cfg->no_hugetlbfs && > - (mem_parsed || internal_cfg->force_sockets == 1)) { > - RTE_LOG(ERR, EAL, "Options -m or --"OPT_SOCKET_MEM" cannot " > + (internal_cfg->force_sockets == 1)) { > + RTE_LOG(ERR, EAL, "Option --"OPT_SOCKET_MEM" cannot " > "be specified together with --"OPT_NO_HUGE"\n"); > return -1; > } Hi, Minor comments. * Without mem_parsed the () aren't required and the conditional will fit on one line. * The section prefix on the first/subject line should be "eal:" and the commit message/justification could be clearer. It would be worth doing a "git log" on the file and following the previous conventions for commit message on that component/file. John
Hello Simon, On Wed, May 20, 2015 at 2:24 PM, Simon Kagstrom < simon.kagstrom@netinsight.net> wrote: > Needed to run as non-root but with higher memory allocations. > > Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net> > Signed-off-by: Johan Faltstrom <johan.faltstrom@netinsight.net> > --- > lib/librte_eal/common/eal_common_options.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > index 8fcb1ab..89b867d 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -851,8 +851,8 @@ eal_check_common_options(struct internal_config > *internal_cfg) > return -1; > } > if (internal_cfg->no_hugetlbfs && > - (mem_parsed || internal_cfg->force_sockets == 1)) { > - RTE_LOG(ERR, EAL, "Options -m or --"OPT_SOCKET_MEM" cannot > " > + (internal_cfg->force_sockets == 1)) { > + RTE_LOG(ERR, EAL, "Option --"OPT_SOCKET_MEM" cannot " > "be specified together with --"OPT_NO_HUGE"\n"); > return -1; > } > Hum, déjà vu. Well, I asked some question last time : http://dpdk.org/ml/archives/dev/2015-March/015867.html This patch looks good but since I don't use this --no-huge that often, I would like to know how you tested this. And please, when resending a patch, it should be marked as vX.
Hi John and David! On 2015-05-27 09:29, Mcnamara, John wrote:> > Minor comments. > > * Without mem_parsed the () aren't required and the conditional will fit on one line. > > * The section prefix on the first/subject line should be "eal:" and the commit message/justification could be clearer. It would be worth doing a "git log" on the file and following the previous conventions for commit message on that component/file. OK, I'll fix these issues. On 2015-05-27 09:43, David Marchand wrote: > Well, I asked some question last time : > http://dpdk.org/ml/archives/dev/2015-March/015867.html > > This patch looks good but since I don't use this --no-huge that often, I > would like to know how you tested this. I used the pcap PMD driver with file input, basically ./test-dpdk --no-huge -m 1024 -l 0,1 -n3 --vdev 'eth_pcap0,rx_pcap=/tmp/eth-out.pcap,tx_pcap=/tmp/eth0.pcap' this patch allows me to run this as myself (i.e., not root) > And please, when resending a patch, it should be marked as vX. Sorry about that, I stashed it and forgot about it for a while, and then just re-made the commit. (Not only that: I lost the reply in the flood of DPDK mails, so sort of what I was complaining about in the first place!) Anyway, I'll update the patch and resend. // Simon
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 8fcb1ab..89b867d 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -851,8 +851,8 @@ eal_check_common_options(struct internal_config *internal_cfg) return -1; } if (internal_cfg->no_hugetlbfs && - (mem_parsed || internal_cfg->force_sockets == 1)) { - RTE_LOG(ERR, EAL, "Options -m or --"OPT_SOCKET_MEM" cannot " + (internal_cfg->force_sockets == 1)) { + RTE_LOG(ERR, EAL, "Option --"OPT_SOCKET_MEM" cannot " "be specified together with --"OPT_NO_HUGE"\n"); return -1; }