From patchwork Sat Dec 27 17:41:35 2014
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Stephen Hemminger <stephen@networkplumber.org>
X-Patchwork-Id: 2174
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@dpdk.org
Delivered-To: patchwork@dpdk.org
Received: from [92.243.14.124] (localhost [IPv6:::1])
	by dpdk.org (Postfix) with ESMTP id E55753195;
	Sat, 27 Dec 2014 18:41:52 +0100 (CET)
Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com
	[209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 2DF1C3005
	for <dev@dpdk.org>; Sat, 27 Dec 2014 18:41:51 +0100 (CET)
Received: by mail-pa0-f46.google.com with SMTP id lf10so14797507pab.33
	for <dev@dpdk.org>; Sat, 27 Dec 2014 09:41:47 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:date:from:to:subject:message-id:mime-version
	:content-type:content-transfer-encoding;
	bh=wHE3w2v1VCr0+xtGHdcSnRfaNTber3a/7eQT4laXdAw=;
	b=YrAJyHNhhrTvekudSguhZvar+mlobXbNQ0TJU4mRUSNvWI1BEqZCBowXd/b6i1cmhv
	MeQ/SNaMPXRpaQtEnFOpXUFrIH30BbXSkis+OO/R+t0FCkor3x8roEBmRxI8N1AY987Y
	7t/hUKfTdJixUwQ1TldkZpnvb319ulpeAO6ggJBxM51Xl/hDwIlZJhQkvjd7OsMMwaVc
	5B40xIrnMmj8sC48Kw5lc8+/DmWdMPJ825RmhZIxUoYtG9n9IquC4+hRoew7JC5ssGHc
	CEG7g+zjcExf03ozxDPl+MdMGE+cMkJCr3zocB9F9ZJ1qcAIDpL1/uHd2+vVDSbzVWPO
	iAEg==
X-Gm-Message-State: 
 ALoCoQlf/LUyPeAzdEIPGa18Pq3fwk76sr/MQ5A5eniKxL+N8rPDhB43KQ2kDcWSGx+TDZRXzXtZ
X-Received: by 10.66.163.10 with SMTP id ye10mr2142937pab.21.1419702107299;
	Sat, 27 Dec 2014 09:41:47 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
	[50.53.82.155]) by mx.google.com with ESMTPSA id
	ip1sm31373939pbc.0.2014.12.27.09.41.45 for <dev@dpdk.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Sat, 27 Dec 2014 09:41:46 -0800 (PST)
Date: Sat, 27 Dec 2014 09:41:35 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Message-ID: <20141227094135.680f211a@urahara>
MIME-Version: 1.0
Subject: [dpdk-dev] [PATCH] ixgbe: initialize link status on initialization
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
	<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
	<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The link_status variable is not set when device is initialized.
This can lead to problems with link never being reported as up
if using some SFP modules where the link is instantly on.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -1314,6 +1314,8 @@
 	err = ixgbe_check_link(hw, &speed, &link_up, 0);
 	if (err)
 		goto error;
+	dev->data->dev_link.link_status = link_up;
+
 	err = ixgbe_get_link_capabilities(hw, &speed, &negotiate);
 	if (err)
 		goto error;