diff mbox series

regexdev: enable to be compiled on Windows

Message ID 1746827534-19881-1-git-send-email-andremue@linux.microsoft.com (mailing list archive)
State New
Delegated to: David Marchand
Headers
Series regexdev: enable to be compiled on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/aws-unit-testing success Unit Testing PASS

Commit Message

Andre Muezerie May 9, 2025, 9:52 p.m. UTC 
Now that mbuf is compiling on Windows, this library can be enabled as
well.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 lib/regexdev/meson.build | 6 ------
 1 file changed, 6 deletions(-)

Comments

David Marchand May 16, 2025, 8:01 a.m. UTC | #1 
On Fri, May 9, 2025 at 11:52 PM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> Now that mbuf is compiling on Windows, this library can be enabled as
> well.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>

The test-regex app can probably be compiled too.
Yet.. why do you want to enable this library on Windows?

Support for this device class is defacto deprecated, as no vendor is
providing recent hardware implementing this feature.

Also note that it was not built with clang on Windows so far (I did
not double check this assertion, I just based on the fact this patch
removes a is_windows, and not a is_ms_compiler).
Andre Muezerie May 16, 2025, 12:50 p.m. UTC | #2 
On Fri, May 16, 2025 at 10:01:42AM +0200, David Marchand wrote:
> On Fri, May 9, 2025 at 11:52 PM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > Now that mbuf is compiling on Windows, this library can be enabled as
> > well.
> >
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> 
> The test-regex app can probably be compiled too.
> Yet.. why do you want to enable this library on Windows?
> 
> Support for this device class is defacto deprecated, as no vendor is
> providing recent hardware implementing this feature.
> 
> Also note that it was not built with clang on Windows so far (I did
> not double check this assertion, I just based on the fact this patch
> removes a is_windows, and not a is_ms_compiler).
> 
> 

I was not aware this code was deprecated. You're right that it was not
being compiled with Clang. This was just part of the effort to increase
code compatibility on Windows.

I see no harm in enabling it, but at the same time, there's no clear
benefit either. I'll let you decide what to do with this.

> -- 
> David Marchand
Thomas Monjalon May 16, 2025, 2:44 p.m. UTC | #3 
16/05/2025 14:50, Andre Muezerie:
> On Fri, May 16, 2025 at 10:01:42AM +0200, David Marchand wrote:
> > On Fri, May 9, 2025 at 11:52 PM Andre Muezerie
> > <andremue@linux.microsoft.com> wrote:
> > >
> > > Now that mbuf is compiling on Windows, this library can be enabled as
> > > well.
> > >
> > > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > 
> > The test-regex app can probably be compiled too.
> > Yet.. why do you want to enable this library on Windows?
> > 
> > Support for this device class is defacto deprecated, as no vendor is
> > providing recent hardware implementing this feature.
> > 
> > Also note that it was not built with clang on Windows so far (I did
> > not double check this assertion, I just based on the fact this patch
> > removes a is_windows, and not a is_ms_compiler).
> > 
> > 
> 
> I was not aware this code was deprecated. You're right that it was not
> being compiled with Clang. This was just part of the effort to increase
> code compatibility on Windows.
> 
> I see no harm in enabling it, but at the same time, there's no clear
> benefit either. I'll let you decide what to do with this.

The benefit is to remove special handling for Windows,
so I vote for enabling it.
There was no regex development recently but we never know
how it could be used in future :)
diff mbox series

Patch

diff --git a/lib/regexdev/meson.build b/lib/regexdev/meson.build
index 426e764ece..7e12d8cd6d 100644
--- a/lib/regexdev/meson.build
+++ b/lib/regexdev/meson.build
@@ -1,12 +1,6 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2020 Mellanox Technologies, Ltd
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
 sources = files('rte_regexdev.c')
 headers = files('rte_regexdev.h', 'rte_regexdev_driver.h')
 indirect_headers += files('rte_regexdev_core.h')