diff mbox series

[v3,6/6] mbuf: enable to be compiled with MSVC

Message ID 1740083508-6703-7-git-send-email-andremue@linux.microsoft.com (mailing list archive)
State Changes Requested
Delegated to: David Marchand
Headers
Series mbuf: enable to be compiled with MSVC |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS

Commit Message

Andre Muezerie Feb. 20, 2025, 8:31 p.m. UTC 
Now that the issues preventing this lib from be compiled with MSVC
are fixed it can be included in the compilation.

The "net" library will automatically get compiled as well as it
has a dependency on "mbuf" which will now get fulfilled.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/mbuf/meson.build | 6 ------
 1 file changed, 6 deletions(-)

Comments

David Marchand April 7, 2025, 1:53 p.m. UTC | #1 
Hello Andre,

On Thu, Feb 20, 2025 at 9:32 PM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> Now that the issues preventing this lib from be compiled with MSVC
> are fixed it can be included in the compilation.
>
> The "net" library will automatically get compiled as well as it
> has a dependency on "mbuf" which will now get fulfilled.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

I just merged the symbol export / versioning rework series.
Could you please resend this patch only, for the CI to have a go?

Thank you.
Andre Muezerie April 8, 2025, 8:53 p.m. UTC | #2 
On Mon, Apr 07, 2025 at 03:53:06PM +0200, David Marchand wrote:
> Hello Andre,
> 
> On Thu, Feb 20, 2025 at 9:32 PM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > Now that the issues preventing this lib from be compiled with MSVC
> > are fixed it can be included in the compilation.
> >
> > The "net" library will automatically get compiled as well as it
> > has a dependency on "mbuf" which will now get fulfilled.
> >
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> I just merged the symbol export / versioning rework series.
> Could you please resend this patch only, for the CI to have a go?
> 

That's great news!
I'll send out the updated patch, and also review the other patches to
see if they need changes.

> Thank you.
> 
> 
> -- 
> David Marchand
diff mbox series

Patch

diff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build
index 2cee9057a5..0435c5e628 100644
--- a/lib/mbuf/meson.build
+++ b/lib/mbuf/meson.build
@@ -1,12 +1,6 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-if is_ms_compiler
-    build = false
-    reason = 'not supported building with Visual Studio Toolset'
-    subdir_done()
-endif
-
 sources = files(
         'rte_mbuf.c',
         'rte_mbuf_ptype.c',