diff mbox series

mbuf: enable to be compiled with MSVC

Message ID 1739224265-4158-1-git-send-email-andremue@linux.microsoft.com (mailing list archive)
State Superseded
Delegated to: Thomas Monjalon
Headers
Series mbuf: enable to be compiled with MSVC |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing fail Testing issues
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Andre Muezerie Feb. 10, 2025, 9:51 p.m. UTC 
Now that the issues preventing this lib from be compiled with MSVC
are fixed it can be included in the compilation.

The "net" library will automatically get compiled as well as it
has a dependency on "mbuf" which will now get fulfilled.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 lib/mbuf/meson.build | 6 ------
 1 file changed, 6 deletions(-)

Comments

Stephen Hemminger Feb. 10, 2025, 10:34 p.m. UTC | #1 
On Mon, 10 Feb 2025 13:51:05 -0800
Andre Muezerie <andremue@linux.microsoft.com> wrote:

> Now that the issues preventing this lib from be compiled with MSVC
> are fixed it can be included in the compilation.
> 
> The "net" library will automatically get compiled as well as it
> has a dependency on "mbuf" which will now get fulfilled.
> 
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---

Getting close to building test-pmd on Windows?

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Andre Muezerie Feb. 11, 2025, 2:19 a.m. UTC | #2 
On Mon, Feb 10, 2025 at 02:34:29PM -0800, Stephen Hemminger wrote:
> On Mon, 10 Feb 2025 13:51:05 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > Now that the issues preventing this lib from be compiled with MSVC
> > are fixed it can be included in the compilation.
> > 
> > The "net" library will automatically get compiled as well as it
> > has a dependency on "mbuf" which will now get fulfilled.
> > 
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > ---
> 
> Getting close to building test-pmd on Windows?
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

We are getting closer, yes :-)
Thomas Monjalon Feb. 12, 2025, 2:23 p.m. UTC | #3 
11/02/2025 03:19, Andre Muezerie:
> On Mon, Feb 10, 2025 at 02:34:29PM -0800, Stephen Hemminger wrote:
> > On Mon, 10 Feb 2025 13:51:05 -0800
> > Andre Muezerie <andremue@linux.microsoft.com> wrote:
> > 
> > > Now that the issues preventing this lib from be compiled with MSVC
> > > are fixed it can be included in the compilation.
> > > 
> > > The "net" library will automatically get compiled as well as it
> > > has a dependency on "mbuf" which will now get fulfilled.
> > > 
> > > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > > ---
> > 
> > Getting close to building test-pmd on Windows?
> > 
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> We are getting closer, yes :-)

Good news

Applied, thanks.
Thomas Monjalon Feb. 12, 2025, 4:24 p.m. UTC | #4 
Mer 12 févr 2025, à 15:23, Thomas Monjalon a écrit :
> 11/02/2025 03:19, Andre Muezerie:
>> On Mon, Feb 10, 2025 at 02:34:29PM -0800, Stephen Hemminger wrote:
>> > On Mon, 10 Feb 2025 13:51:05 -0800
>> > Andre Muezerie <andremue@linux.microsoft.com> wrote:
>> > 
>> > > Now that the issues preventing this lib from be compiled with MSVC
>> > > are fixed it can be included in the compilation.
>> > > 
>> > > The "net" library will automatically get compiled as well as it
>> > > has a dependency on "mbuf" which will now get fulfilled.
>> > > 
>> > > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
>> > > ---
>> > 
>> > Getting close to building test-pmd on Windows?
>> > 
>> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>> 
>> We are getting closer, yes :-)
>
> Good news
>
> Applied, thanks.

The patch has been removed from main because Andre reported a compilation issue.
diff mbox series

Patch

diff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build
index 2cee9057a5..0435c5e628 100644
--- a/lib/mbuf/meson.build
+++ b/lib/mbuf/meson.build
@@ -1,12 +1,6 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-if is_ms_compiler
-    build = false
-    reason = 'not supported building with Visual Studio Toolset'
-    subdir_done()
-endif
-
 sources = files(
         'rte_mbuf.c',
         'rte_mbuf_ptype.c',