From patchwork Wed Apr 17 23:41:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 139464 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B06DF43E97; Thu, 18 Apr 2024 01:42:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB18340685; Thu, 18 Apr 2024 01:42:10 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 23D96402D4 for ; Thu, 18 Apr 2024 01:42:03 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 095B920FD4CE; Wed, 17 Apr 2024 16:42:01 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 095B920FD4CE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1713397322; bh=1UgesD7xdvLHA9+rwinkWvJvo0cgvqofqVp5wXh3rSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K6GtwC5rXa7OZbEE5/iEkVMfQHYUvBoJCIYOnu1ea833hrQjyY2Asg8/kbXZ3pooM z6CZZHdZghkRE0jquWlS3vi37sZubkJWAPp1WQMzxQgHeZauRGIvqo96FgbJwH4Imu LPE+vF0IEL8My5eMRqjY90q5ONfpeZm9ztI2cscA= From: Tyler Retzlaff To: dev@dpdk.org Cc: =?utf-8?q?Morten_Br=C3=B8rup?= , Akhil Goyal , Aman Singh , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Dariusz Sosnowski , Dmitry Kozlyuk , Fan Zhang , Ferruh Yigit , Harry van Haaren , Honnappa Nagarahalli , Jiayu Hu , Jingjing Wu , Kevin Laatz , Konstantin Ananyev , Matan Azrad , Ori Kam , Pallavi Kadam , Reshma Pattan , Sameh Gobriel , Suanming Mou , Thomas Monjalon , Tyler Retzlaff , Viacheslav Ovsiienko , Vladimir Medvedkin , Volodymyr Fialko , Yipeng Wang , Yuying Zhang Subject: [PATCH 03/16] ethdev: remove use of VLAs for Windows built code Date: Wed, 17 Apr 2024 16:41:46 -0700 Message-Id: <1713397319-26135-4-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- lib/ethdev/rte_ethdev.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index f1c658f..cd2ed74 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -3241,7 +3241,8 @@ enum { } /* Get id-name lookup table */ - struct rte_eth_xstat_name xstats_names[cnt_xstats]; + struct rte_eth_xstat_name *xstats_names = + alloca(sizeof(struct rte_eth_xstat_name) * cnt_xstats); if (cnt_xstats != rte_eth_xstats_get_names_by_id( port_id, xstats_names, cnt_xstats, NULL)) { @@ -3342,7 +3343,7 @@ enum { return -EINVAL; if (ids && dev->dev_ops->xstats_get_names_by_id != NULL && size > 0) { - uint64_t ids_copy[size]; + uint64_t *ids_copy = alloca(sizeof(uint64_t) * size); for (i = 0; i < size; i++) { if (ids[i] < basic_count) { @@ -3535,7 +3536,7 @@ enum { if (ret < 0) return ret; expected_entries = (uint16_t)ret; - struct rte_eth_xstat xstats[expected_entries]; + struct rte_eth_xstat *xstats = alloca(sizeof(struct rte_eth_xstat) * expected_entries); basic_count = eth_dev_get_xstats_basic_count(dev); /* Return max number of stats if no ids given */ @@ -3551,7 +3552,7 @@ enum { if (ids && dev->dev_ops->xstats_get_by_id != NULL && size) { unsigned int basic_count = eth_dev_get_xstats_basic_count(dev); - uint64_t ids_copy[size]; + uint64_t *ids_copy = alloca(sizeof(uint64_t) * size); for (i = 0; i < size; i++) { if (ids[i] < basic_count) {