From patchwork Tue Feb 13 18:34:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136673 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF46343B0D; Tue, 13 Feb 2024 19:37:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B617742EFC; Tue, 13 Feb 2024 19:35:19 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1E6F842D7B for ; Tue, 13 Feb 2024 19:34:57 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id EE7ED20B2014; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EE7ED20B2014 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=vAFbWuH3EQmhq208jJcWNqYnzvXlxMwI6iAxf97lD44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mQsAcs7UCQ8YeZO33RddpVZRwhmilSBngwyiQ9EdbuPzIcU25dkQ8qStH7Cn0SJV0 GQKlBCoYcUUU0/wv/GG9E2JavUK+15WG91dqCHHrmp4TZa1twv74Q0s4bTODi34EM5 umZ9fBQQg8JkKzR6wF3nNGFui6b+BNdSxNGclc08= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 21/21] devtools: forbid direct use of compiler alignof and typeof Date: Tue, 13 Feb 2024 10:34:52 -0800 Message-Id: <1707849292-19519-22-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add 2 checks forbidding direct use of __alignof__ and __typeof__ instead C11 alignof and rte_common.h typeof macros should be used. Signed-off-by: Tyler Retzlaff --- devtools/checkpatches.sh | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index c9e466f..e379700 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -151,6 +151,22 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # forbid use of __alignof__ + awk -v FOLDERS="lib drivers app examples" \ + -v EXPRESSIONS='\\<__alignof__\\>' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using __alignof__, prefer C11 alignof' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + + # forbid use of __typeof__ + awk -v FOLDERS="lib drivers app examples" \ + -v EXPRESSIONS='\\<__typeof__\\>' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using __typeof__, prefer typeof' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # forbid use of non abstracted bit count operations awk -v FOLDERS="lib drivers app examples" \ -v EXPRESSIONS='\\<__builtin_(clz|clzll|ctz|ctzll|popcount|popcountll)\\>' \