diff mbox series

common/cnxk: removed stale condition

Message ID 1686810682-24888-1-git-send-email-skoteshwar@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series common/cnxk: removed stale condition |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Satha Koteswara Rao Kottidi June 15, 2023, 6:31 a.m. UTC 
  From: Satha Rao <skoteshwar@marvell.com>

Removed condition that doesn't have any effect on code flow.

Coverity issue: 385405
Fixes: 4d00b8c6a331 ("common/cnxk: allocate dynamic BPIDs")

Signed-off-by: Satha Rao <skoteshwar@marvell.com>
---
 drivers/common/cnxk/roc_nix_fc.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Jerin Jacob June 15, 2023, 8:43 a.m. UTC | #1 
On Thu, Jun 15, 2023 at 12:01 PM <skoteshwar@marvell.com> wrote:
>
> From: Satha Rao <skoteshwar@marvell.com>
>
> Removed condition that doesn't have any effect on code flow.
>
> Coverity issue: 385405
> Fixes: 4d00b8c6a331 ("common/cnxk: allocate dynamic BPIDs")
>
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>

Applied to dpdk-next-net-mrvl/for-next-net. Thanks


> ---
>  drivers/common/cnxk/roc_nix_fc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c
> index f79baf9..d8ca5f9 100644
> --- a/drivers/common/cnxk/roc_nix_fc.c
> +++ b/drivers/common/cnxk/roc_nix_fc.c
> @@ -750,8 +750,6 @@ enum roc_nix_fc_mode
>         req->read = 0;
>
>         rc = mbox_process(mbox);
> -       if (rc)
> -               goto exit;
>  exit:
>         mbox_put(mbox);
>         return rc;
> --
> 1.8.3.1
>
diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c
index f79baf9..d8ca5f9 100644
--- a/drivers/common/cnxk/roc_nix_fc.c
+++ b/drivers/common/cnxk/roc_nix_fc.c
@@ -750,8 +750,6 @@  enum roc_nix_fc_mode
 	req->read = 0;
 
 	rc = mbox_process(mbox);
-	if (rc)
-		goto exit;
 exit:
 	mbox_put(mbox);
 	return rc;