diff mbox series

[v8,01/14] eal: use rdtsc intrinsic

Message ID	1682997341-2271-2-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, thomas@monjalon.net, mb@smartsharesystems.com, konstantin.ananyev@huawei.com, Tyler Retzlaff <roretzla@linux.microsoft.com> Subject: [PATCH v8 01/14] eal: use rdtsc intrinsic Date: Mon, 1 May 2023 20:15:28 -0700 Message-Id: <1682997341-2271-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1682997341-2271-1-git-send-email-roretzla@linux.microsoft.com> References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> <1682997341-2271-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	msvc integration changes \| [v8,00/14] msvc integration changes [v8,01/14] eal: use rdtsc intrinsic [v8,02/14] eal: use rtm and xtest intrinsics [v8,03/14] eal: use barrier intrinsics [v8,04/14] eal: use cpuid and cpuidex intrinsics [v8,05/14] eal: use umonitor umwait and tpause intrinsics [v8,06/14] eal: use prefetch intrinsics [v8,07/14] eal: use byte swap intrinsics [v8,08/14] eal: hide GCC extension based alignment markers [v8,09/14] eal: hide typedefs based on GCC vector extensions [v8,10/14] eal: expand most macros to empty when using MSVC [v8,11/14] eal: exclude exposure of rte atomic APIs for MSVC builds [v8,12/14] telemetry: avoid expanding versioned symbol macros on MSVC [v8,13/14] eal: always define MSVC as little endian [v8,14/14] eal: do not define typeof macro when building with MSVC

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Tyler Retzlaff May 2, 2023, 3:15 a.m. UTC

  Inline assembly is not supported for MSVC x64. Convert code to use
__rdtsc intrinsic.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 lib/eal/x86/include/rte_cycles.h | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff mbox series

Patch

diff --git a/lib/eal/x86/include/rte_cycles.h b/lib/eal/x86/include/rte_cycles.h
index a461a4d..cca5122 100644
--- a/lib/eal/x86/include/rte_cycles.h
+++ b/lib/eal/x86/include/rte_cycles.h
@@ -6,6 +6,12 @@ 
 #ifndef _RTE_CYCLES_X86_64_H_
 #define _RTE_CYCLES_X86_64_H_
 
+#ifndef RTE_TOOLCHAIN_MSVC
+#include <x86intrin.h>
+#else
+#include <intrin.h>
+#endif
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -23,6 +29,7 @@ 
 static inline uint64_t
 rte_rdtsc(void)
 {
+#ifdef RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT
 	union {
 		uint64_t tsc_64;
 		RTE_STD_C11
@@ -32,7 +39,6 @@ 
 		};
 	} tsc;
 
-#ifdef RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT
 	if (unlikely(rte_cycles_vmware_tsc_map)) {
 		/* ecx = 0x10000 corresponds to the physical TSC for VMware */
 		asm volatile("rdpmc" :
@@ -42,11 +48,7 @@ 
 		return tsc.tsc_64;
 	}
 #endif
-
-	asm volatile("rdtsc" :
-		     "=a" (tsc.lo_32),
-		     "=d" (tsc.hi_32));
-	return tsc.tsc_64;
+	return __rdtsc();
 }
 
 static inline uint64_t