diff mbox series

[03/17] stack: use previous value atomic fetch operations

Message ID	1677718068-2412-4-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: dev@dpdk.org Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, Tyler Retzlaff <roretzla@linux.microsoft.com> Subject: [PATCH 03/17] stack: use previous value atomic fetch operations Date: Wed, 1 Mar 2023 16:47:34 -0800 Message-Id: <1677718068-2412-4-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com> References: <1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com> Precedence: list Errors-To: dev-bounces@dpdk.org
Series	use __atomic operations returning previous value \| [00/17] use __atomic operations returning previous value [01/17] vhost: use previous value atomic fetch operations [02/17] telemetry: use previous value atomic fetch operations [03/17] stack: use previous value atomic fetch operations [04/17] eal: use previous value atomic fetch operations [05/17] distributor: use previous value atomic fetch operations [06/17] bbdev: use previous value atomic fetch operations [07/17] examples/vhost: use previous value atomic fetch operations [08/17] net/virtio: use previous value atomic fetch operations [09/17] net/octeontx: use previous value atomic fetch operations [10/17] net/mlx5: use previous value atomic fetch operations [11/17] net/iavf: use previous value atomic fetch operations [12/17] net/cxgbe: use previous value atomic fetch operations [13/17] drivers/event: use previous value atomic fetch operations [14/17] dma/skeleton: use previous value atomic fetch operations [15/17] drivers/common: use previous value atomic fetch operations [16/17] app/test: use previous value atomic fetch operations [17/17] test-eventdev: use previous value atomic fetch operations

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Tyler Retzlaff March 2, 2023, 12:47 a.m. UTC

  Use __atomic_fetch_{add,and,or,sub,xor} instead of
__atomic_{add,and,or,sub,xor}_fetch when we have no interest in the
result of the operation.

Reduces unnecessary codegen that provided the result of the atomic
operation that was not used.

Change brings closer alignment with atomics available in C11 standard
and will reduce review effort when they are integrated.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/stack/rte_stack_lf_c11.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/lib/stack/rte_stack_lf_c11.h b/lib/stack/rte_stack_lf_c11.h
index 8403196..687a6f6 100644
--- a/lib/stack/rte_stack_lf_c11.h
+++ b/lib/stack/rte_stack_lf_c11.h
@@ -66,7 +66,7 @@ 
 	/* Ensure the stack modifications are not reordered with respect
 	 * to the LIFO len update.
 	 */
-	__atomic_add_fetch(&list->len, num, __ATOMIC_RELEASE);
+	__atomic_fetch_add(&list->len, num, __ATOMIC_RELEASE);
 }
 
 static __rte_always_inline struct rte_stack_lf_elem *