[dpdk-dev,v6,08/10] hash: remove duplicated code
Commit Message
The following patch is needed and will be squashed to fix some doxygen issues:
Comments
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, June 16, 2015 10:33 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 08/10] hash: remove duplicated code
>
> The following patch is needed and will be squashed to fix some doxygen
> issues:
>
> --- a/lib/librte_hash/rte_jhash.h
> +++ b/lib/librte_hash/rte_jhash.h
> @@ -306,13 +306,13 @@ rte_jhash2(const uint32_t *k, uint32_t length,
> uint32_t initval)
> * with seeds. If you pass in (*pb)=0, the output (*pc) will be
> * the same as the return value from rte_jhash.
> *
> - * @param k
> + * @param key
> * Key to calculate hash of.
> * @param length
> * Length of key in bytes.
> * @param pc
> * IN: seed OUT: primary hash value.
> - * @param pc
> + * @param pb
> * IN: second seed OUT: secondary hash value.
> */
> static inline void
> @@ -464,7 +464,7 @@ rte_jhash_2hashes(const void *key, uint32_t length,
> uint32_t *pc, uint32_t *pb)
> * Length of key in units of 4 bytes.
> * @param pc
> * IN: seed OUT: primary hash value.
> - * @param pc
> + * @param pb
> * IN: second seed OUT: secondary hash value.
> */
> static inline void
Thanks for spotting this!
Are you going to do it yourself or you want me to do it and send a v7?
Pablo
2015-06-16 10:31, De Lara Guarch, Pablo:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > The following patch is needed and will be squashed to fix some doxygen
> > issues:
|...]
|> Thanks for spotting this!
> Are you going to do it yourself or you want me to do it and send a v7?
Already squashed with patch 7:
http://dpdk.org/browse/dpdk/commit/?id=8718219a8737b8
@@ -306,13 +306,13 @@ rte_jhash2(const uint32_t *k, uint32_t length, uint32_t initval)
* with seeds. If you pass in (*pb)=0, the output (*pc) will be
* the same as the return value from rte_jhash.
*
- * @param k
+ * @param key
* Key to calculate hash of.
* @param length
* Length of key in bytes.
* @param pc
* IN: seed OUT: primary hash value.
- * @param pc
+ * @param pb
* IN: second seed OUT: secondary hash value.
*/
static inline void
@@ -464,7 +464,7 @@ rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc, uint32_t *pb)
* Length of key in units of 4 bytes.
* @param pc
* IN: seed OUT: primary hash value.
- * @param pc
+ * @param pb
* IN: second seed OUT: secondary hash value.
*/
static inline void