[v6,01/27] net/nfp: fix CPP bridge service requirement

Message ID 1666339323-24016-2-git-send-email-chaoyong.he@corigine.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series add the basic rte_flow offload support of nfp PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Chaoyong He Oct. 21, 2022, 8:01 a.m. UTC
  The CPP(Command Pull Push) bridge service is needed for some debug tools,
and should be optional, so remove the mandatory requirement of service
lcore parameter.

Fixes: b18804219537 ("net/nfp: add initial flower firmware support")

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
---
 drivers/net/nfp/nfp_ethdev.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
  

Patch

diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index f11a1b6..f25d6a1 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -1066,11 +1066,8 @@ 
 
 	/* register the CPP bridge service here for primary use */
 	ret = nfp_enable_cpp_service(pf_dev->cpp);
-	if (ret != 0) {
-		PMD_INIT_LOG(ERR, "Enable cpp service failed.");
-		ret = -EINVAL;
-		goto hwqueues_cleanup;
-	}
+	if (ret != 0)
+		PMD_INIT_LOG(INFO, "Enable cpp service failed.");
 
 	return 0;
 
@@ -1208,13 +1205,6 @@ 
 		goto sym_tbl_cleanup;
 	}
 
-	/* Register the CPP bridge service for the secondary too */
-	ret = nfp_enable_cpp_service(cpp);
-	if (ret != 0) {
-		PMD_INIT_LOG(ERR, "Enable cpp service failed.");
-		ret = -EINVAL;
-	}
-
 sym_tbl_cleanup:
 	free(sym_tbl);