diff mbox series

[v3] doc: announce changes to rte_eth_set_queue_rate_limit API

Message ID 1657891507-15525-1-git-send-email-skoteshwar@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v3] doc: announce changes to rte_eth_set_queue_rate_limit API |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-unit-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Satha Koteswara Rao Kottidi July 15, 2022, 1:25 p.m. UTC 
  From: Satha Rao <skoteshwar@marvell.com>

rte_eth_set_queue_rate_limit argument rate modified to uint32_t
to support more than 64Gbps.

Signed-off-by: Satha Rao <skoteshwar@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---

v2: Modified rate to uint32_t as per review comments
v3: api in subject line changed to API

---

 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Andrew Rybchenko July 15, 2022, 2:23 p.m. UTC | #1 
On 7/15/22 16:25, skoteshwar@marvell.com wrote:
> From: Satha Rao <skoteshwar@marvell.com>
> 
> rte_eth_set_queue_rate_limit argument rate modified to uint32_t
> to support more than 64Gbps.
> 
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> 
> v2: Modified rate to uint32_t as per review comments
> v3: api in subject line changed to API
> 
> ---
> 
>   doc/guides/rel_notes/deprecation.rst | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c..36e0f67 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -125,3 +125,8 @@ Deprecation Notices
>     applications should be updated to use the ``dmadev`` library instead,
>     with the underlying HW-functionality being provided by the ``ioat`` or
>     ``idxd`` dma drivers
> +
> +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` in Mbps.
> +  This parameter declared as uint16_t, queue rate limited to 64Gbps. ``rate``
> +  parameter will be modified to uint32_t in DPDK 22.11 so that it can work for
> +  more than 64Gbps.

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Ajit Khaparde July 15, 2022, 4:29 p.m. UTC | #2 
On Fri, Jul 15, 2022 at 7:23 AM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> On 7/15/22 16:25, skoteshwar@marvell.com wrote:
> > From: Satha Rao <skoteshwar@marvell.com>
> >
> > rte_eth_set_queue_rate_limit argument rate modified to uint32_t
> > to support more than 64Gbps.
> >
> > Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> >
> > v2: Modified rate to uint32_t as per review comments
> > v3: api in subject line changed to API
> >
> > ---
> >
> >   doc/guides/rel_notes/deprecation.rst | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index 4e5b23c..36e0f67 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -125,3 +125,8 @@ Deprecation Notices
> >     applications should be updated to use the ``dmadev`` library instead,
> >     with the underlying HW-functionality being provided by the ``ioat`` or
> >     ``idxd`` dma drivers
> > +
> > +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` in Mbps.
> > +  This parameter declared as uint16_t, queue rate limited to 64Gbps. ``rate``
> > +  parameter will be modified to uint32_t in DPDK 22.11 so that it can work for
> > +  more than 64Gbps.
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Thomas Monjalon July 16, 2022, 6:05 p.m. UTC | #3 
15/07/2022 18:29, Ajit Khaparde:
> On Fri, Jul 15, 2022 at 7:23 AM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
> >
> > On 7/15/22 16:25, skoteshwar@marvell.com wrote:
> > > From: Satha Rao <skoteshwar@marvell.com>
> > >
> > > rte_eth_set_queue_rate_limit argument rate modified to uint32_t
> > > to support more than 64Gbps.
> > >
> > > Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> > > Acked-by: Jerin Jacob <jerinj@marvell.com>
[...]
> > > +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` in Mbps.
> > > +  This parameter declared as uint16_t, queue rate limited to 64Gbps. ``rate``
> > > +  parameter will be modified to uint32_t in DPDK 22.11 so that it can work for
> > > +  more than 64Gbps.
> >
> > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

With a bit of English grammar rewording,

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c..36e0f67 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -125,3 +125,8 @@  Deprecation Notices
   applications should be updated to use the ``dmadev`` library instead,
   with the underlying HW-functionality being provided by the ``ioat`` or
   ``idxd`` dma drivers
+
+* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` in Mbps.
+  This parameter declared as uint16_t, queue rate limited to 64Gbps. ``rate``
+  parameter will be modified to uint32_t in DPDK 22.11 so that it can work for
+  more than 64Gbps.