[v7,3/6] baseband/acc100: remove RTE prefix for internal macro

Message ID 1654036307-182860-4-git-send-email-nicolas.chautru@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series drivers/baseband: PMD to support ACC100/ACC101 devices |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Chautru, Nicolas May 31, 2022, 10:31 p.m. UTC
  Cosmetic update to remove RTE_ prefix for a define
kept internal.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 drivers/baseband/acc100/rte_acc100_pmd.c | 4 ++--
 drivers/baseband/acc100/rte_acc100_pmd.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
  

Comments

Maxime Coquelin June 1, 2022, 2:11 p.m. UTC | #1
On 6/1/22 00:31, Nicolas Chautru wrote:
> Cosmetic update to remove RTE_ prefix for a define
> kept internal.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   drivers/baseband/acc100/rte_acc100_pmd.c | 4 ++--
>   drivers/baseband/acc100/rte_acc100_pmd.h | 6 +++---
>   2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index 32c8bc2..210028b 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -1133,7 +1133,7 @@
>   /* ACC100 PCI PF address map */
>   static struct rte_pci_id pci_id_acc100_pf_map[] = {
>   	{
> -		RTE_PCI_DEVICE(RTE_ACC100_VENDOR_ID, RTE_ACC100_PF_DEVICE_ID)
> +		RTE_PCI_DEVICE(ACC100_VENDOR_ID, ACC100_PF_DEVICE_ID)
>   	},
>   	{.device_id = 0},
>   };
> @@ -1141,7 +1141,7 @@
>   /* ACC100 PCI VF address map */
>   static struct rte_pci_id pci_id_acc100_vf_map[] = {
>   	{
> -		RTE_PCI_DEVICE(RTE_ACC100_VENDOR_ID, RTE_ACC100_VF_DEVICE_ID)
> +		RTE_PCI_DEVICE(ACC100_VENDOR_ID, ACC100_VF_DEVICE_ID)
>   	},
>   	{.device_id = 0},
>   };
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.h b/drivers/baseband/acc100/rte_acc100_pmd.h
> index 071b37c..b3956e9 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.h
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.h
> @@ -27,9 +27,9 @@
>   #define ACC100VF_DRIVER_NAME           intel_acc100_vf
>   
>   /* ACC100 PCI vendor & device IDs */
> -#define RTE_ACC100_VENDOR_ID           (0x8086)
> -#define RTE_ACC100_PF_DEVICE_ID        (0x0d5c)
> -#define RTE_ACC100_VF_DEVICE_ID        (0x0d5d)
> +#define ACC100_VENDOR_ID           (0x8086)
> +#define ACC100_PF_DEVICE_ID        (0x0d5c)
> +#define ACC100_VF_DEVICE_ID        (0x0d5d)
>   
>   /* Values used in filling in descriptors */
>   #define ACC100_DMA_DESC_TYPE           2

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
  
Akhil Goyal June 1, 2022, 5:15 p.m. UTC | #2
Hi Maxime,
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
Do you have any more comments on other patches of this series?
If not, please ack other patches as well.
  
Maxime Coquelin June 2, 2022, 12:57 p.m. UTC | #3
Hi Akhil,

On 6/1/22 19:15, Akhil Goyal wrote:
> Hi Maxime,
>>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
> Do you have any more comments on other patches of this series?
> If not, please ack other patches as well.
> 

I'm done with my review of the series.

Regards
Maxime
  

Patch

diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
index 32c8bc2..210028b 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -1133,7 +1133,7 @@ 
 /* ACC100 PCI PF address map */
 static struct rte_pci_id pci_id_acc100_pf_map[] = {
 	{
-		RTE_PCI_DEVICE(RTE_ACC100_VENDOR_ID, RTE_ACC100_PF_DEVICE_ID)
+		RTE_PCI_DEVICE(ACC100_VENDOR_ID, ACC100_PF_DEVICE_ID)
 	},
 	{.device_id = 0},
 };
@@ -1141,7 +1141,7 @@ 
 /* ACC100 PCI VF address map */
 static struct rte_pci_id pci_id_acc100_vf_map[] = {
 	{
-		RTE_PCI_DEVICE(RTE_ACC100_VENDOR_ID, RTE_ACC100_VF_DEVICE_ID)
+		RTE_PCI_DEVICE(ACC100_VENDOR_ID, ACC100_VF_DEVICE_ID)
 	},
 	{.device_id = 0},
 };
diff --git a/drivers/baseband/acc100/rte_acc100_pmd.h b/drivers/baseband/acc100/rte_acc100_pmd.h
index 071b37c..b3956e9 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.h
+++ b/drivers/baseband/acc100/rte_acc100_pmd.h
@@ -27,9 +27,9 @@ 
 #define ACC100VF_DRIVER_NAME           intel_acc100_vf
 
 /* ACC100 PCI vendor & device IDs */
-#define RTE_ACC100_VENDOR_ID           (0x8086)
-#define RTE_ACC100_PF_DEVICE_ID        (0x0d5c)
-#define RTE_ACC100_VF_DEVICE_ID        (0x0d5d)
+#define ACC100_VENDOR_ID           (0x8086)
+#define ACC100_PF_DEVICE_ID        (0x0d5c)
+#define ACC100_VF_DEVICE_ID        (0x0d5d)
 
 /* Values used in filling in descriptors */
 #define ACC100_DMA_DESC_TYPE           2