diff mbox series

[v1] config/arm: split aarch32 march

Message ID 1636113390-23253-1-git-send-email-juraj.linkes@pantheon.tech (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] config/arm: split aarch32 march |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-spell-check-testing warning Testing issues
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues

Commit Message

Juraj Linkeš Nov. 5, 2021, 11:56 a.m. UTC 
  Aarch32 config got overlooked when splitting march in a previous parch.

Fixes: 95e0f23022a3 ("config/arm: split -march into arch and features")
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 config/arm/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ruifeng Wang Nov. 8, 2021, 5:33 a.m. UTC | #1 
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Friday, November 5, 2021 7:57 PM
> To: thomas@monjalon.net; david.marchand@redhat.com;
> bruce.richardson@intel.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; fengchengwen@huawei.com;
> ferruh.yigit@intel.com; jerinjacobk@gmail.com; jerinj@marvell.com;
> pbhagavatula@marvell.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] config/arm: split aarch32 march
> 
> Aarch32 config got overlooked when splitting march in a previous parch.
> 
> Fixes: 95e0f23022a3 ("config/arm: split -march into arch and features")
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
Thomas Monjalon Nov. 8, 2021, 8:18 a.m. UTC | #2 
It is not strictly -march only (-mfpu as well).

08/11/2021 06:33, Ruifeng Wang:
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > 
> > Aarch32 config got overlooked when splitting march in a previous parch.

s/parch/patch/

> > Fixes: 95e0f23022a3 ("config/arm: split -march into arch and features")

blank line missing here

> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > ---
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

Applied with rewording, thanks.
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index d22b41e096..213324d262 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -43,7 +43,8 @@  implementer_generic = {
             'compiler_options': ['-moutline-atomics']
         },
         'generic_aarch32': {
-            'machine_args': ['-march=armv8-a', '-mfpu=neon'],
+            'march': 'armv8-a',
+            'compiler_options': ['-mfpu=neon'],
             'flags': [
                 ['RTE_ARCH_ARM_NEON_MEMCPY', false],
                 ['RTE_ARCH_STRICT_ALIGN', true],