diff mbox series

[v8,06/11] app/test: temporarily "skip" one cmdline test case

Message ID 1635216361-23641-7-git-send-email-jizh@linux.microsoft.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series app/test: enable subset of tests on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Jie Zhou Oct. 26, 2021, 2:45 a.m. UTC 
  cmdline tests pass except one failure at the test_cmdline_socket_fns
test case with error: failed to open /dev/null for reading!

Temporarily "skip" this case while enable all other passing cases.

Issue is tracked internally and will add the corresponding case on
Windows in future.

Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
 app/test/test_cmdline_lib.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Dmitry Kozlyuk Nov. 23, 2021, 10:02 p.m. UTC | #1 
2021-10-25 19:45 (UTC-0700), Jie Zhou:
> cmdline tests pass except one failure at the test_cmdline_socket_fns
> test case with error: failed to open /dev/null for reading!

Can't it be something like this?

#ifndef RTE_EXEC_ENV_WINDOWS
#define NULL_INPUT "/dev/null"
#else
#define NULL_INPUT "NUL"
#endif
Jie Zhou Dec. 1, 2021, 12:30 a.m. UTC | #2 
On Wed, Nov 24, 2021 at 01:02:13AM +0300, Dmitry Kozlyuk wrote:
> 2021-10-25 19:45 (UTC-0700), Jie Zhou:
> > cmdline tests pass except one failure at the test_cmdline_socket_fns
> > test case with error: failed to open /dev/null for reading!
> 
> Can't it be something like this?
> 
> #ifndef RTE_EXEC_ENV_WINDOWS
> #define NULL_INPUT "/dev/null"
> #else
> #define NULL_INPUT "NUL"
> #endif

Yes, it works. Thanks!
diff mbox series

Patch

diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c
index 4715edc341..eb54ef06d7 100644
--- a/app/test/test_cmdline_lib.c
+++ b/app/test/test_cmdline_lib.c
@@ -146,6 +146,9 @@  test_cmdline_vt100_fns(void)
 static int
 test_cmdline_socket_fns(void)
 {
+#ifdef RTE_EXEC_ENV_WINDOWS
+	return 0;
+#else
 	cmdline_parse_ctx_t ctx;
 	struct cmdline *cl;
 
@@ -184,6 +187,7 @@  test_cmdline_socket_fns(void)
 	printf("Error: function accepted null parameter!\n");
 	cmdline_free(cl);
 	return -1;
+#endif
 }
 
 static int