diff mbox series

[v18,8/8] maintainers: add for dmadev

Message ID 1630580057-29295-9-git-send-email-fengchengwen@huawei.com (mailing list archive)
State Superseded
Headers show
Series support dmadev | expand

Checks

Context Check Description
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-spell-check-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/checkpatch warning coding style issues

Commit Message

fengchengwen Sept. 2, 2021, 10:54 a.m. UTC
This patch add myself as dmadev's maintainer and update release notes.

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 MAINTAINERS                            | 7 +++++++
 doc/guides/rel_notes/release_21_11.rst | 5 +++++
 2 files changed, 12 insertions(+)

Comments

Bruce Richardson Sept. 2, 2021, 11:51 a.m. UTC | #1
On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
> This patch add myself as dmadev's maintainer and update release notes.
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---

Just in case you are doing any further revisions of this patchset, the
maintainers entry, and RN entry, generally is added in the first patch, so
squash this patch into patch #1.
fengchengwen Sept. 2, 2021, 1:39 p.m. UTC | #2
Fix in v19

I think there many patches wait for dmadev framework upstream, so
could you help review unreviewd patches (like dma/skeleton and app/test)?

Also, we have developed the dma driver for hisilicon, and corresponding test
app (like examples/vhost and testpmd) is being developed.

examples/vhost: will extend support dmadev type.
testpmd: will introduces some dma control commands and the dma forwarding mode.
         the dma forwarding mode process:
              // 1st: call rte_eth_rx_burst
              // 2st: post received packet to dma, move data to another packet
              // 3st: set newcopyed rte_mbuf header
              // 4st: free received packet
              // 5st: get dma completed request and associate it rte_mbuf
              // 6st: send 5st's rte_mbuf to nic

@Maxime @Chenbo @Xiaoyun Like to hear your opinion.


On 2021/9/2 19:51, Bruce Richardson wrote:
> On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
>> This patch add myself as dmadev's maintainer and update release notes.
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---
> 
> Just in case you are doing any further revisions of this patchset, the
> maintainers entry, and RN entry, generally is added in the first patch, so
> squash this patch into patch #1.
> .
>
Maxime Coquelin Sept. 3, 2021, 12:59 p.m. UTC | #3
Hi,

On 9/2/21 3:39 PM, fengchengwen wrote:
> Fix in v19
> 
> I think there many patches wait for dmadev framework upstream, so
> could you help review unreviewd patches (like dma/skeleton and app/test)?

Thanks for all the work, it looks really promising!

> Also, we have developed the dma driver for hisilicon, and corresponding test
> app (like examples/vhost and testpmd) is being developed.
> 
> examples/vhost: will extend support dmadev type.

I think Sunil has posted RFC for Vhost lib and example, you might want
to have a look to avoid duplicate work.

> testpmd: will introduces some dma control commands and the dma forwarding mode.
>          the dma forwarding mode process:
>               // 1st: call rte_eth_rx_burst
>               // 2st: post received packet to dma, move data to another packet
>               // 3st: set newcopyed rte_mbuf header
>               // 4st: free received packet
>               // 5st: get dma completed request and associate it rte_mbuf
>               // 6st: send 5st's rte_mbuf to nic
> 
> @Maxime @Chenbo @Xiaoyun Like to hear your opinion.

We might also think of adding async support to Vhost PMD, that would be
another way to test dmadev with testpmd.

Thanks,
Maxime

> 
> On 2021/9/2 19:51, Bruce Richardson wrote:
>> On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
>>> This patch add myself as dmadev's maintainer and update release notes.
>>>
>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---
>>
>> Just in case you are doing any further revisions of this patchset, the
>> maintainers entry, and RN entry, generally is added in the first patch, so
>> squash this patch into patch #1.
>> .
>>
>
fengchengwen Sept. 4, 2021, 7:02 a.m. UTC | #4
On 2021/9/3 20:59, Maxime Coquelin wrote:
> Hi,
> 
> On 9/2/21 3:39 PM, fengchengwen wrote:
>> Fix in v19
>>
>> I think there many patches wait for dmadev framework upstream, so
>> could you help review unreviewd patches (like dma/skeleton and app/test)?
> 
> Thanks for all the work, it looks really promising!
> 
>> Also, we have developed the dma driver for hisilicon, and corresponding test
>> app (like examples/vhost and testpmd) is being developed.
>>
>> examples/vhost: will extend support dmadev type.
> 
> I think Sunil has posted RFC for Vhost lib and example, you might want
> to have a look to avoid duplicate work.

Got it, thanks

> 
>> testpmd: will introduces some dma control commands and the dma forwarding mode.
>>          the dma forwarding mode process:
>>               // 1st: call rte_eth_rx_burst
>>               // 2st: post received packet to dma, move data to another packet
>>               // 3st: set newcopyed rte_mbuf header
>>               // 4st: free received packet
>>               // 5st: get dma completed request and associate it rte_mbuf
>>               // 6st: send 5st's rte_mbuf to nic
>>
>> @Maxime @Chenbo @Xiaoyun Like to hear your opinion.
> 
> We might also think of adding async support to Vhost PMD, that would be
> another way to test dmadev with testpmd.

OK

> 
> Thanks,
> Maxime
> 
>>
>> On 2021/9/2 19:51, Bruce Richardson wrote:
>>> On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
>>>> This patch add myself as dmadev's maintainer and update release notes.
>>>>
>>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---
>>>
>>> Just in case you are doing any further revisions of this patchset, the
>>> maintainers entry, and RN entry, generally is added in the first patch, so
>>> squash this patch into patch #1.
>>> .
>>>
>>
> 
> .
>
Xiaoyun Li Sept. 6, 2021, 1:46 a.m. UTC | #5
Hi

> -----Original Message-----
> From: fengchengwen <fengchengwen@huawei.com>
> Sent: Saturday, September 4, 2021 15:02
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
> jerinj@marvell.com; jerinjacobk@gmail.com; andrew.rybchenko@oktetlabs.ru;
> dev@dpdk.org; mb@smartsharesystems.com; nipun.gupta@nxp.com;
> hemant.agrawal@nxp.com; honnappa.nagarahalli@arm.com;
> david.marchand@redhat.com; sburla@marvell.com; pkapoor@marvell.com;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Walsh, Conor
> <conor.walsh@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Subject: Re: [PATCH v18 8/8] maintainers: add for dmadev
> 
> On 2021/9/3 20:59, Maxime Coquelin wrote:
> > Hi,
> >
> > On 9/2/21 3:39 PM, fengchengwen wrote:
> >> Fix in v19
> >>
> >> I think there many patches wait for dmadev framework upstream, so
> >> could you help review unreviewd patches (like dma/skeleton and app/test)?
> >
> > Thanks for all the work, it looks really promising!
> >
> >> Also, we have developed the dma driver for hisilicon, and
> >> corresponding test app (like examples/vhost and testpmd) is being developed.
> >>
> >> examples/vhost: will extend support dmadev type.
> >
> > I think Sunil has posted RFC for Vhost lib and example, you might want
> > to have a look to avoid duplicate work.
> 
> Got it, thanks
> 
> >
> >> testpmd: will introduces some dma control commands and the dma
> forwarding mode.
> >>          the dma forwarding mode process:
> >>               // 1st: call rte_eth_rx_burst
> >>               // 2st: post received packet to dma, move data to another packet
> >>               // 3st: set newcopyed rte_mbuf header
> >>               // 4st: free received packet
> >>               // 5st: get dma completed request and associate it rte_mbuf
> >>               // 6st: send 5st's rte_mbuf to nic
> >>
> >> @Maxime @Chenbo @Xiaoyun Like to hear your opinion.

What're some dma control commands? Can you give some examples here?

And the fwding mode in testpmd sounds like a function test to verify functions of dmadev.
Why don't you just test in app/test like test_eventdev or test_cryptodev? What's the purpose of this dma forwarding mode since it's just dma-copy from one mbuf to another?

> >
> > We might also think of adding async support to Vhost PMD, that would
> > be another way to test dmadev with testpmd.

+1 on this. This makes more sense.

> 
> OK
> 
> >
> > Thanks,
> > Maxime
> >
> >>
> >> On 2021/9/2 19:51, Bruce Richardson wrote:
> >>> On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
> >>>> This patch add myself as dmadev's maintainer and update release notes.
> >>>>
> >>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---
> >>>
> >>> Just in case you are doing any further revisions of this patchset,
> >>> the maintainers entry, and RN entry, generally is added in the first
> >>> patch, so squash this patch into patch #1.
> >>> .
> >>>
> >>
> >
> > .
> >
Xia, Chenbo Sept. 6, 2021, 2:03 a.m. UTC | #6
Hi,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Friday, September 3, 2021 8:59 PM
> To: fengchengwen <fengchengwen@huawei.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
> jerinj@marvell.com; jerinjacobk@gmail.com; andrew.rybchenko@oktetlabs.ru;
> dev@dpdk.org; mb@smartsharesystems.com; nipun.gupta@nxp.com;
> hemant.agrawal@nxp.com; honnappa.nagarahalli@arm.com;
> david.marchand@redhat.com; sburla@marvell.com; pkapoor@marvell.com; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; Walsh, Conor
> <conor.walsh@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Subject: Re: [PATCH v18 8/8] maintainers: add for dmadev
> 
> Hi,
> 
> On 9/2/21 3:39 PM, fengchengwen wrote:
> > Fix in v19
> >
> > I think there many patches wait for dmadev framework upstream, so
> > could you help review unreviewd patches (like dma/skeleton and app/test)?
> 
> Thanks for all the work, it looks really promising!
> 
> > Also, we have developed the dma driver for hisilicon, and corresponding test
> > app (like examples/vhost and testpmd) is being developed.
> >
> > examples/vhost: will extend support dmadev type.
> 
> I think Sunil has posted RFC for Vhost lib and example, you might want
> to have a look to avoid duplicate work.
> 
> > testpmd: will introduces some dma control commands and the dma forwarding
> mode.
> >          the dma forwarding mode process:
> >               // 1st: call rte_eth_rx_burst
> >               // 2st: post received packet to dma, move data to another
> packet
> >               // 3st: set newcopyed rte_mbuf header
> >               // 4st: free received packet
> >               // 5st: get dma completed request and associate it rte_mbuf
> >               // 6st: send 5st's rte_mbuf to nic
> >
> > @Maxime @Chenbo @Xiaoyun Like to hear your opinion.
> 
> We might also think of adding async support to Vhost PMD, that would be
> another way to test dmadev with testpmd.

+1 for this. I would prefer support in vhost pmd so that it could be tested with
testpmd.

About the testpmd patches, if it's for testing dma device itself, usually we create a new
app (now testpmd only tests ethdev). If vhost pmd also needs some user input, just
make it a devarg. Make sense to you?

Thanks,
Chenbo

> 
> Thanks,
> Maxime
> 
> >
> > On 2021/9/2 19:51, Bruce Richardson wrote:
> >> On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
> >>> This patch add myself as dmadev's maintainer and update release notes.
> >>>
> >>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---
> >>
> >> Just in case you are doing any further revisions of this patchset, the
> >> maintainers entry, and RN entry, generally is added in the first patch, so
> >> squash this patch into patch #1.
> >> .
> >>
> >
fengchengwen Sept. 6, 2021, 8 a.m. UTC | #7
On 2021/9/6 9:46, Li, Xiaoyun wrote:
> Hi
> 
>> -----Original Message-----
>> From: fengchengwen <fengchengwen@huawei.com>
>> Sent: Saturday, September 4, 2021 15:02
>> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Richardson, Bruce
>> <bruce.richardson@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> jerinj@marvell.com; jerinjacobk@gmail.com; andrew.rybchenko@oktetlabs.ru;
>> dev@dpdk.org; mb@smartsharesystems.com; nipun.gupta@nxp.com;
>> hemant.agrawal@nxp.com; honnappa.nagarahalli@arm.com;
>> david.marchand@redhat.com; sburla@marvell.com; pkapoor@marvell.com;
>> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Walsh, Conor
>> <conor.walsh@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> Subject: Re: [PATCH v18 8/8] maintainers: add for dmadev
>>
>> On 2021/9/3 20:59, Maxime Coquelin wrote:
>>> Hi,
>>>
>>> On 9/2/21 3:39 PM, fengchengwen wrote:
>>>> Fix in v19
>>>>
>>>> I think there many patches wait for dmadev framework upstream, so
>>>> could you help review unreviewd patches (like dma/skeleton and app/test)?
>>>
>>> Thanks for all the work, it looks really promising!
>>>
>>>> Also, we have developed the dma driver for hisilicon, and
>>>> corresponding test app (like examples/vhost and testpmd) is being developed.
>>>>
>>>> examples/vhost: will extend support dmadev type.
>>>
>>> I think Sunil has posted RFC for Vhost lib and example, you might want
>>> to have a look to avoid duplicate work.
>>
>> Got it, thanks
>>
>>>
>>>> testpmd: will introduces some dma control commands and the dma
>> forwarding mode.
>>>>          the dma forwarding mode process:
>>>>               // 1st: call rte_eth_rx_burst
>>>>               // 2st: post received packet to dma, move data to another packet
>>>>               // 3st: set newcopyed rte_mbuf header
>>>>               // 4st: free received packet
>>>>               // 5st: get dma completed request and associate it rte_mbuf
>>>>               // 6st: send 5st's rte_mbuf to nic
>>>>
>>>> @Maxime @Chenbo @Xiaoyun Like to hear your opinion.
> 
> What're some dma control commands? Can you give some examples here?

It is only a plan. Our test team reports that some test points, such as configuring the queue depth, are required.

Based on the current discussion, we are not prepared to support this feature, this thread could be closed.

> 
> And the fwding mode in testpmd sounds like a function test to verify functions of dmadev.
> Why don't you just test in app/test like test_eventdev or test_cryptodev? What's the purpose of this dma forwarding mode since it's just dma-copy from one mbuf to another?
> 
>>>
>>> We might also think of adding async support to Vhost PMD, that would
>>> be another way to test dmadev with testpmd.
> 
> +1 on this. This makes more sense.
> 
>>
>> OK
>>
>>>
>>> Thanks,
>>> Maxime
>>>
>>>>
>>>> On 2021/9/2 19:51, Bruce Richardson wrote:
>>>>> On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
>>>>>> This patch add myself as dmadev's maintainer and update release notes.
>>>>>>
>>>>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---
>>>>>
>>>>> Just in case you are doing any further revisions of this patchset,
>>>>> the maintainers entry, and RN entry, generally is added in the first
>>>>> patch, so squash this patch into patch #1.
>>>>> .
>>>>>
>>>>
>>>
>>> .
>>>
fengchengwen Sept. 6, 2021, 8:01 a.m. UTC | #8
On 2021/9/6 10:03, Xia, Chenbo wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Friday, September 3, 2021 8:59 PM
>> To: fengchengwen <fengchengwen@huawei.com>; Richardson, Bruce
>> <bruce.richardson@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> jerinj@marvell.com; jerinjacobk@gmail.com; andrew.rybchenko@oktetlabs.ru;
>> dev@dpdk.org; mb@smartsharesystems.com; nipun.gupta@nxp.com;
>> hemant.agrawal@nxp.com; honnappa.nagarahalli@arm.com;
>> david.marchand@redhat.com; sburla@marvell.com; pkapoor@marvell.com; Ananyev,
>> Konstantin <konstantin.ananyev@intel.com>; Walsh, Conor
>> <conor.walsh@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> Subject: Re: [PATCH v18 8/8] maintainers: add for dmadev
>>
>> Hi,
>>
>> On 9/2/21 3:39 PM, fengchengwen wrote:
>>> Fix in v19
>>>
>>> I think there many patches wait for dmadev framework upstream, so
>>> could you help review unreviewd patches (like dma/skeleton and app/test)?
>>
>> Thanks for all the work, it looks really promising!
>>
>>> Also, we have developed the dma driver for hisilicon, and corresponding test
>>> app (like examples/vhost and testpmd) is being developed.
>>>
>>> examples/vhost: will extend support dmadev type.
>>
>> I think Sunil has posted RFC for Vhost lib and example, you might want
>> to have a look to avoid duplicate work.
>>
>>> testpmd: will introduces some dma control commands and the dma forwarding
>> mode.
>>>          the dma forwarding mode process:
>>>               // 1st: call rte_eth_rx_burst
>>>               // 2st: post received packet to dma, move data to another
>> packet
>>>               // 3st: set newcopyed rte_mbuf header
>>>               // 4st: free received packet
>>>               // 5st: get dma completed request and associate it rte_mbuf
>>>               // 6st: send 5st's rte_mbuf to nic
>>>
>>> @Maxime @Chenbo @Xiaoyun Like to hear your opinion.
>>
>> We might also think of adding async support to Vhost PMD, that would be
>> another way to test dmadev with testpmd.
> 
> +1 for this. I would prefer support in vhost pmd so that it could be tested with
> testpmd.
> 
> About the testpmd patches, if it's for testing dma device itself, usually we create a new
> app (now testpmd only tests ethdev). If vhost pmd also needs some user input, just
> make it a devarg. Make sense to you?

Got it, thanks

> 
> Thanks,
> Chenbo
> 
>>
>> Thanks,
>> Maxime
>>
>>>
>>> On 2021/9/2 19:51, Bruce Richardson wrote:
>>>> On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
>>>>> This patch add myself as dmadev's maintainer and update release notes.
>>>>>
>>>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---
>>>>
>>>> Just in case you are doing any further revisions of this patchset, the
>>>> maintainers entry, and RN entry, generally is added in the first patch, so
>>>> squash this patch into patch #1.
>>>> .
>>>>
>>>
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 7be9658..17763c8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -496,6 +496,13 @@  F: drivers/raw/skeleton/
 F: app/test/test_rawdev.c
 F: doc/guides/prog_guide/rawdev.rst
 
+DMA device API - EXPERIMENTAL
+M: Chengwen Feng <fengchengwen@huawei.com>
+F: lib/dmadev/
+F: drivers/dma/skeleton/
+F: app/test/test_dmadev*
+F: doc/guides/prog_guide/dmadev.rst
+
 
 Memory Pool Drivers
 -------------------
diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
index d707a55..78b9691 100644
--- a/doc/guides/rel_notes/release_21_11.rst
+++ b/doc/guides/rel_notes/release_21_11.rst
@@ -55,6 +55,11 @@  New Features
      Also, make sure to start the actual text at the margin.
      =======================================================
 
+* **Added dmadev library support.**
+
+  The dmadev library provides a DMA device framework for management and
+  provision of hardware and software DMA devices.
+
 
 Removed Items
 -------------