diff mbox series

doc: announce IPsec xform struct changes

Message ID 1627973317-231-1-git-send-email-anoobj@marvell.com (mailing list archive)
State Accepted, archived
Headers
Series doc: announce IPsec xform struct changes |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-spell-check-testing warning Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Anoob Joseph Aug. 3, 2021, 6:48 a.m. UTC 
  IPsec xform struct would be updated to include IPsec SA lifetime
configuration. The existing member 'esn_soft_limit' would only track
ESN. And as sequence number control is getting introduced,
'esn_soft_limit' may not indicate the number of packets processed.
Replace that with a new structure to cover all lifetime cases with
support for specifying both soft and hard lifetimes.

ESN control introduced by: http://patches.dpdk.org/project/dpdk/patch/20210713133542.3550525-4-radu.nicolau@intel.com/

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Akhil Goyal Aug. 4, 2021, 5:01 p.m. UTC | #1 
> IPsec xform struct would be updated to include IPsec SA lifetime
> configuration. The existing member 'esn_soft_limit' would only track
> ESN. And as sequence number control is getting introduced,
> 'esn_soft_limit' may not indicate the number of packets processed.
> Replace that with a new structure to cover all lifetime cases with
> support for specifying both soft and hard lifetimes.
> 
> ESN control introduced by:
> http://patches.dpdk.org/project/dpdk/patch/20210713133542.3550525-4-
> radu.nicolau@intel.com/
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>

@Konstantin Ananyev, @Hemant Agrawal: Could you please Ack.
Ananyev, Konstantin Aug. 4, 2021, 5:35 p.m. UTC | #2 
> > IPsec xform struct would be updated to include IPsec SA lifetime
> > configuration. The existing member 'esn_soft_limit' would only track
> > ESN. And as sequence number control is getting introduced,
> > 'esn_soft_limit' may not indicate the number of packets processed.
> > Replace that with a new structure to cover all lifetime cases with
> > support for specifying both soft and hard lifetimes.
> >
> > ESN control introduced by:
> > http://patches.dpdk.org/project/dpdk/patch/20210713133542.3550525-4-
> > radu.nicolau@intel.com/
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> 

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Jerin Jacob Aug. 7, 2021, 1:32 p.m. UTC | #3 
On Wed, Aug 4, 2021 at 11:05 PM Ananyev, Konstantin
<konstantin.ananyev@intel.com> wrote:
>
>
>
> > > IPsec xform struct would be updated to include IPsec SA lifetime
> > > configuration. The existing member 'esn_soft_limit' would only track
> > > ESN. And as sequence number control is getting introduced,
> > > 'esn_soft_limit' may not indicate the number of packets processed.
> > > Replace that with a new structure to cover all lifetime cases with
> > > support for specifying both soft and hard lifetimes.
> > >
> > > ESN control introduced by:
> > > http://patches.dpdk.org/project/dpdk/patch/20210713133542.3550525-4-
> > > radu.nicolau@intel.com/
> > >
> > > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > > ---
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>
Thomas Monjalon Aug. 7, 2021, 5:13 p.m. UTC | #4 
> > > > IPsec xform struct would be updated to include IPsec SA lifetime
> > > > configuration. The existing member 'esn_soft_limit' would only track
> > > > ESN. And as sequence number control is getting introduced,
> > > > 'esn_soft_limit' may not indicate the number of packets processed.
> > > > Replace that with a new structure to cover all lifetime cases with
> > > > support for specifying both soft and hard lifetimes.
> > > >
> > > > ESN control introduced by:
> > > > http://patches.dpdk.org/project/dpdk/patch/20210713133542.3550525-4-
> > > > radu.nicolau@intel.com/
> > > >
> > > > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>

That's a lot of acks from Marvell but looks OK.

Applied, thanks.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6a35c76..7dbc088 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -151,3 +151,8 @@  Deprecation Notices
 * security: The functions ``rte_security_set_pkt_metadata`` and
   ``rte_security_get_userdata`` will be made inline functions and additional
   flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
+
+* security: The IPsec configuration structure
+  ``struct rte_security_ipsec_xform`` will be updated with new members to allow
+  SA lifetime configuration. A new structure would be introduced to replace the
+  current member, ``esn_soft_limit``.