diff mbox series

[v3,2/2] eal: fix service core index validity

Message ID 1620187807-40049-3-git-send-email-fengchengwen@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series fix bugs for librte eal |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Chengwen Feng May 5, 2021, 4:10 a.m. UTC 
  This patch adds checking for service core index validity when parsing
service corelist.

Fixes: 7dbd7a6413ef ("service: add -S corelist option")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v2->v3:
* change patch's author
---
 lib/eal/common/eal_common_options.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Van Haaren, Harry May 5, 2021, 10:43 a.m. UTC | #1 
> -----Original Message-----
> From: Chengwen Feng <fengchengwen@huawei.com>
> Sent: Wednesday, May 5, 2021 5:10 AM
> To: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
> skori@marvell.com; jerinj@marvell.com; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> stephen@networkplumber.org
> Cc: dev@dpdk.org; linuxarm@openeuler.org
> Subject: [PATCH v3 2/2] eal: fix service core index validity
> 
> This patch adds checking for service core index validity when parsing
> service corelist.
> 
> Fixes: 7dbd7a6413ef ("service: add -S corelist option")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Thanks,

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Thomas Monjalon May 5, 2021, 9:23 p.m. UTC | #2 
05/05/2021 12:43, Van Haaren, Harry:
> From: Chengwen Feng <fengchengwen@huawei.com>
> > 
> > This patch adds checking for service core index validity when parsing
> > service corelist.
> > 
> > Fixes: 7dbd7a6413ef ("service: add -S corelist option")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Thanks,
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Series applied, thanks.
diff mbox series

Patch

diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
index 66f9114..97ab6e0 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -758,10 +758,10 @@  static int
 eal_parse_service_corelist(const char *corelist)
 {
 	struct rte_config *cfg = rte_eal_get_configuration();
-	int i, idx = 0;
+	int i;
 	unsigned count = 0;
 	char *end = NULL;
-	int min, max;
+	uint32_t min, max, idx;
 	uint32_t taken_lcore_count = 0;
 
 	if (corelist == NULL)
@@ -785,6 +785,8 @@  eal_parse_service_corelist(const char *corelist)
 		idx = strtoul(corelist, &end, 10);
 		if (errno || end == NULL)
 			return -1;
+		if (idx >= RTE_MAX_LCORE)
+			return -1;
 		while (isblank(*end))
 			end++;
 		if (*end == '-') {