From patchwork Fri Apr 30 20:14:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 92580 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A63EBA0546; Fri, 30 Apr 2021 22:10:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7D084113D; Fri, 30 Apr 2021 22:10:27 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 0DBD94110A for ; Fri, 30 Apr 2021 22:10:25 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id s22so29044775pgk.6 for ; Fri, 30 Apr 2021 13:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SDY4bbAy555dJfNSmTFacJ6z77dmkcIj1YR2xwGY2bo=; b=fCsZSHQA90Jeo4KVBchm54NTJhykCsK18xNfhS9czfXM+BBUW1STNoP4MN0BsVkvmk jDnaVcva4qacQw862wOK4iTmle7cgyj+X9FU3Thv2xNd+OrZA6t613HYI+lEuEJrfdyk Qu/vZ+DO383V+4xJP5kv6ehVkziIS42VUS8Hg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SDY4bbAy555dJfNSmTFacJ6z77dmkcIj1YR2xwGY2bo=; b=d+4fUjKhCBGoJ09RI1ZJbW35TiH8LMe54QyAV2dFRuz42ikvn/E7+2R0NzrNb6Bfmf 4cacJzgG/hE8l1arrjRuLpzHAmtHnvuADG0Ld8RkEGMyERBYoWGnPh1RJykgyoGuXb8w pvzMKOrlRkKN8MX1RpPnhi3x83GUA3ttblVtLFNz/MJC9dVNgXWFCQ49YOj6BMA7UFrN OBr0CI+3FzfD3GmbvM+A4Nrwu5U0Q5zyLV8049haIn6k1CJICcHvHZMTPGz4FivTeQwk lCOER0qJDA7JOUBdxpr7+tTmaYj4zz2QKoMQ3EgYXnxewzYlzUZEQUScgJJZ6K1+sEO8 lkqA== X-Gm-Message-State: AOAM532xsAzCW4InAPCgOzMus/khaSFMxdApZYtTyPXfB8xw6NhZBVlw 3qQXD8+MMk+lzemecVQ53/3iecioDUOWw3tnd0wbeenaYV+wkOkSodqNABi41QSDa51BmYr64Qb QI7MkadRb9oi2ysSyPUxkfBkAfCaZOZ9xEXwGzcqhPNUif+zM+CW+EWfCFrKr1Ns= X-Google-Smtp-Source: ABdhPJyhkszKe+s9CmdBY5ljXRFKjjJH7IrVr7wXgHc0cTpxEN9ayjALAjSe6epWMZXRyOqArijbxw== X-Received: by 2002:a63:6a05:: with SMTP id f5mr6164125pgc.433.1619813423739; Fri, 30 Apr 2021 13:10:23 -0700 (PDT) Received: from u099.swdvt.lab.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id j12sm3430587pfc.17.2021.04.30.13.10.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Apr 2021 13:10:22 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Ajit Khaparde , stable@dpdk.org Date: Fri, 30 Apr 2021 13:14:11 -0700 Message-Id: <1619813653-5161-3-git-send-email-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1619813653-5161-1-git-send-email-ajit.khaparde@broadcom.com> References: <1619813653-5161-1-git-send-email-ajit.khaparde@broadcom.com> X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH 2/4] net/bnxt: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Return value where return value of rte_pci_read_config was not checked. Fix it. Coverity issue: 349919 Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 6dfb33c..4068271 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4129,13 +4129,17 @@ uint32_t bnxt_read_fw_status_reg(struct bnxt *bp, uint32_t index) struct bnxt_error_recovery_info *info = bp->recovery_info; uint32_t reg = info->status_regs[index]; uint32_t type, offset, val = 0; + int ret = 0; type = BNXT_FW_STATUS_REG_TYPE(reg); offset = BNXT_FW_STATUS_REG_OFF(reg); switch (type) { case BNXT_FW_STATUS_REG_TYPE_CFG: - rte_pci_read_config(bp->pdev, &val, sizeof(val), offset); + ret = rte_pci_read_config(bp->pdev, &val, sizeof(val), offset); + if (ret < 0) + PMD_DRV_LOG(ERR, "Failed to read PCI offset %#x", + offset); break; case BNXT_FW_STATUS_REG_TYPE_GRC: offset = info->mapped_status_regs[index];