From patchwork Fri Apr 30 20:14:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 92579 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE968A0546; Fri, 30 Apr 2021 22:10:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34A414112E; Fri, 30 Apr 2021 22:10:26 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id A07D74013F for ; Fri, 30 Apr 2021 22:10:23 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id z6-20020a17090a1706b0290155e8a752d8so2324649pjd.4 for ; Fri, 30 Apr 2021 13:10:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SO52AseYWBvCHVHWz3u69NWIN4MJ8fb0lKORxQ1O+Fg=; b=cEwm66elDwcYdtKUkCos7lQIASwzAaBIY0IeLxbudvOf3lSRmdISsSGlLVpBcijKRp 9PCzVhpF2+FHxinL1cgZCGXg4Ba5vI1sG/Sx9W8k3rfK0lTI9+Jg+xlnEJzM8CsB3ALl u8GTBQj5tQmZBUHv3jEyTAKM4lcyN5Wiq4iRo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SO52AseYWBvCHVHWz3u69NWIN4MJ8fb0lKORxQ1O+Fg=; b=mxm3TD6v6oh/CROtAZ2ODVyYkW1+dbexPopmRWd9fa8DJmdkjKegfXrFPVhWdoL+0y YlYqx4GwsD1HnICFX7WjuxA+CJyr4MSLdf0SXTtpoZ68ajqJl6+0Rxi7MlRCfPBVNfIZ xEwUDLbI2STaWcLe2JgOOy7YT1DsfybqfWcoTHi/1BuVAEWRxDVkASRY6lv3BmhnX8Vv YmVFsQJyecA1vcHTEYE6PX8SzL2Na3ZdzG3svZJ8hNHj/+CcNwAyQA+zX1oVvKohSVNC fXjho3vXF3Y1O+4IOalykr/AJHLhyMrQKcjosS6OD1Du0x56vO5O2v+2FvIULWCXkNxj TQlQ== X-Gm-Message-State: AOAM531fQNmjkDBFsrNHZYbpZvYFyg4xH0IKhs8NM9+i0U1+0btLth+X yCcqzHZDry/kxbFWjqyJ+iFQHSoedt6c5K7qwcwZI+d5Zk5OQM9Gl+crv1gTqciOq0D4Ce4rn3r RMWc42spozviHdzLe9at74wfaylNuHUeJkU3Jm2PcoHRxtawc/wQYQ0gDEkVxkbM= X-Google-Smtp-Source: ABdhPJznt1IE9vhcreYdABFl0qUmmW3lc95M4xrL5gTxBJWKCuwNHd5eVZyKNeQXQbh2BbPysSmTkA== X-Received: by 2002:a17:90b:1646:: with SMTP id il6mr16631544pjb.27.1619813422391; Fri, 30 Apr 2021 13:10:22 -0700 (PDT) Received: from u099.swdvt.lab.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id j12sm3430587pfc.17.2021.04.30.13.10.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Apr 2021 13:10:21 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Ajit Khaparde , stable@dpdk.org Date: Fri, 30 Apr 2021 13:14:10 -0700 Message-Id: <1619813653-5161-2-git-send-email-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1619813653-5161-1-git-send-email-ajit.khaparde@broadcom.com> References: <1619813653-5161-1-git-send-email-ajit.khaparde@broadcom.com> X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH 1/4] net/bnxt: fix mismatched type comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" dev_info.max_mac_addrs is of type uint32_t. But the counter i is of type uint16_t. This mismatch may cause the loop condition may always be true. Change the loop counter variable to uint32_t. Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index dba5b9f..6dfb33c 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -3959,7 +3959,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp) struct rte_ether_addr *addr; uint64_t pool_mask; uint32_t pool = 0; - uint16_t i; + uint32_t i; int rc; if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp))