diff mbox series

[1/2] eventdev: remove redundant setting thread name

Message ID 1619775278-25857-2-git-send-email-humin29@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series bugfix for lib eventdev |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

humin (Q) April 30, 2021, 9:34 a.m. UTC 
  From: Chengwen Feng <fengchengwen@huawei.com>

The thread name already set by rte_ctrl_thread_create() API, so remove
the call of rte_thread_setname() API.

Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Jerin Jacob May 1, 2021, 12:38 p.m. UTC | #1 
On Fri, Apr 30, 2021 at 3:04 PM Min Hu (Connor) <humin29@huawei.com> wrote:
>
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> The thread name already set by rte_ctrl_thread_create() API, so remove
> the call of rte_thread_setname() API.
>
> Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Reviewed-by: Jerin Jacob <jerinj@marvell.com>



> ---
>  lib/eventdev/rte_event_eth_rx_adapter.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index ca166a6..d317e89 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -1432,10 +1432,8 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)
>
>         err = rte_ctrl_thread_create(&rx_adapter->rx_intr_thread, thread_name,
>                                 NULL, rxa_intr_thread, rx_adapter);
> -       if (!err) {
> -               rte_thread_setname(rx_adapter->rx_intr_thread, thread_name);
> +       if (!err)
>                 return 0;
> -       }
>
>         RTE_EDEV_LOG_ERR("Failed to create interrupt thread err = %d\n", err);
>  error:
> --
> 2.7.4
>
diff mbox series

Patch

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index ca166a6..d317e89 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -1432,10 +1432,8 @@  rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)
 
 	err = rte_ctrl_thread_create(&rx_adapter->rx_intr_thread, thread_name,
 				NULL, rxa_intr_thread, rx_adapter);
-	if (!err) {
-		rte_thread_setname(rx_adapter->rx_intr_thread, thread_name);
+	if (!err)
 		return 0;
-	}
 
 	RTE_EDEV_LOG_ERR("Failed to create interrupt thread err = %d\n", err);
 error: