[v3,1/3] examples/flow_classify: fix check of port and core

  According to the comments and logging, the author just hope user to use
the core and device which are in the same numa node for optimal
performance. If not, A warning gives out.

For example in flow_classify:
./build/flow_classify -a 0000:7d:00.1  -l 93
Here:
0000:7d:00.1 is on numa node 0.
core 93  is on numa node 3.

The two are not in same numa node, but no warning gives out in old codes.

This patch can fix it.

Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 examples/flow_classify/flow_classify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Thursday, April 29, 2021 1:51 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; thomas@monjalon.net
> Subject: [PATCH v3 1/3] examples/flow_classify: fix check of port and core
> 
> According to the comments and logging, the author just hope user to use the
> core and device which are in the same numa node for optimal performance.
> If not, A warning gives out.
> 
> For example in flow_classify:
> ./build/flow_classify -a 0000:7d:00.1  -l 93
> Here:
> 0000:7d:00.1 is on numa node 0.
> core 93  is on numa node 3.
> 
> The two are not in same numa node, but no warning gives out in old codes.
> 
> This patch can fix it.
> 
> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Tested-by: Bernard Iremonger <bernard.iremonger@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
  

Thanks Bernard .

Hi, Thomas, Ferruh, any other comments?

在 2021/4/29 17:07, Iremonger, Bernard 写道:
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Thursday, April 29, 2021 1:51 AM
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Iremonger, Bernard
>> <bernard.iremonger@intel.com>; thomas@monjalon.net
>> Subject: [PATCH v3 1/3] examples/flow_classify: fix check of port and core
>>
>> According to the comments and logging, the author just hope user to use the
>> core and device which are in the same numa node for optimal performance.
>> If not, A warning gives out.
>>
>> For example in flow_classify:
>> ./build/flow_classify -a 0000:7d:00.1  -l 93
>> Here:
>> 0000:7d:00.1 is on numa node 0.
>> core 93  is on numa node 3.
>>
>> The two are not in same numa node, but no warning gives out in old codes.
>>
>> This patch can fix it.
>>
>> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Tested-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> 
> .
>
  

Hi,

29/04/2021 11:37, Min Hu (Connor):
> Thanks Bernard .
> 
> Hi, Thomas, Ferruh, any other comments?

No need to ask for more comments after each ack.
We are very busy and we'll come to this patch on time.
You are sending a lot of fixes. That's very good
but we need time to digest them :)
Thanks
  

在 2021/4/29 19:44, Thomas Monjalon 写道:
> Hi,
> 
> 29/04/2021 11:37, Min Hu (Connor):
>> Thanks Bernard .
>>
>> Hi, Thomas, Ferruh, any other comments?
> 
> No need to ask for more comments after each ack.
> We are very busy and we'll come to this patch on time.
> You are sending a lot of fixes. That's very good
> but we need time to digest them :)
> Thanks
> 
Hi, Thomas,
	Sorry for that. I will be waiting more patiently in future.
	Thanks.
> 
> .
>