diff mbox series

app/bbdev: fix wrong variable

Message ID 1619163776-39125-1-git-send-email-humin29@huawei.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series app/bbdev: fix wrong variable |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

humin (Q) April 23, 2021, 7:42 a.m. UTC 
  This patch corrected misused variable.

Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 app/test-bbdev/test_bbdev_perf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chautru, Nicolas April 23, 2021, 6:50 p.m. UTC | #1 
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Friday, April 23, 2021 12:43 AM
> 
> This patch corrected misused variable.
> 
> Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Thanks

Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>

> ---
>  app/test-bbdev/test_bbdev_perf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-
> bbdev/test_bbdev_perf.c
> index 45b85b9..b8bf512 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -372,14 +372,14 @@ check_dev_cap(const struct rte_bbdev_info
> *dev_info)
>  			if (nb_harq_inputs > cap->num_buffers_hard_out) {
>  				printf(
>  					"Too many HARQ inputs defined: %u,
> max: %u\n",
> -					nb_hard_outputs,
> +					nb_harq_inputs,
>  					cap->num_buffers_hard_out);
>  				return TEST_FAILED;
>  			}
>  			if (nb_harq_outputs > cap->num_buffers_hard_out)
> {
>  				printf(
>  					"Too many HARQ outputs defined:
> %u, max: %u\n",
> -					nb_hard_outputs,
> +					nb_harq_outputs,
>  					cap->num_buffers_hard_out);
>  				return TEST_FAILED;
>  			}
> --
> 2.7.4
Thomas Monjalon April 25, 2021, 4:30 p.m. UTC | #2 
Chautru, Nicolas:
> From: Min Hu (Connor) <humin29@huawei.com>
> > 
> > This patch corrected misused variable.
> > 
> > Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Thanks
> 
> Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>

It is not enough. The commit log must described what was broken in which case.
humin (Q) April 26, 2021, 12:57 a.m. UTC | #3 
在 2021/4/26 0:30, Thomas Monjalon 写道:
> Chautru, Nicolas:
>> From: Min Hu (Connor) <humin29@huawei.com>
>>>
>>> This patch corrected misused variable.
>>>
>>> Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>
>> Thanks
>>
>> Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
> 
> It is not enough. The commit log must described what was broken in which case.
> 
Hi, fixed in v2, thanks.
>
diff mbox series

Patch

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 45b85b9..b8bf512 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -372,14 +372,14 @@  check_dev_cap(const struct rte_bbdev_info *dev_info)
 			if (nb_harq_inputs > cap->num_buffers_hard_out) {
 				printf(
 					"Too many HARQ inputs defined: %u, max: %u\n",
-					nb_hard_outputs,
+					nb_harq_inputs,
 					cap->num_buffers_hard_out);
 				return TEST_FAILED;
 			}
 			if (nb_harq_outputs > cap->num_buffers_hard_out) {
 				printf(
 					"Too many HARQ outputs defined: %u, max: %u\n",
-					nb_hard_outputs,
+					nb_harq_outputs,
 					cap->num_buffers_hard_out);
 				return TEST_FAILED;
 			}